[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Set full span layout parameter on SearchCardView

2017-07-27 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/368104 )

Change subject: Set full span layout parameter on SearchCardView
..


Set full span layout parameter on SearchCardView

Bug: T171328
Change-Id: I55250b2be2c4d87f0384db44bf95e48e834d75b4
---
M app/src/main/java/org/wikipedia/feed/view/FeedAdapter.java
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Dbrant: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/app/src/main/java/org/wikipedia/feed/view/FeedAdapter.java 
b/app/src/main/java/org/wikipedia/feed/view/FeedAdapter.java
index e27e567..13552bc 100644
--- a/app/src/main/java/org/wikipedia/feed/view/FeedAdapter.java
+++ b/app/src/main/java/org/wikipedia/feed/view/FeedAdapter.java
@@ -3,6 +3,7 @@
 import android.content.Context;
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
+import android.support.v7.widget.StaggeredGridLayoutManager;
 import android.view.View;
 import android.view.ViewGroup;
 
@@ -66,6 +67,11 @@
 
 @Override public void onViewAttachedToWindow(DefaultViewHolder holder) {
 super.onViewAttachedToWindow(holder);
+if (holder.getView() instanceof SearchCardView) {
+StaggeredGridLayoutManager.LayoutParams layoutParams
+= (StaggeredGridLayoutManager.LayoutParams) 
holder.getView().getLayoutParams();
+layoutParams.setFullSpan(true);
+}
 holder.getView().setCallback(callback);
 if (callback != null) {
 callback.onShowCard(holder.getView().getCard());

-- 
To view, visit https://gerrit.wikimedia.org/r/368104
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I55250b2be2c4d87f0384db44bf95e48e834d75b4
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Set full span layout parameter on SearchCardView

2017-07-26 Thread Mholloway (Code Review) 
Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368104 )

Change subject: Set full span layout parameter on SearchCardView
..

Set full span layout parameter on SearchCardView

Bug: T171328
Change-Id: I55250b2be2c4d87f0384db44bf95e48e834d75b4
---
M app/src/main/java/org/wikipedia/feed/view/FeedAdapter.java
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/04/368104/1

diff --git a/app/src/main/java/org/wikipedia/feed/view/FeedAdapter.java 
b/app/src/main/java/org/wikipedia/feed/view/FeedAdapter.java
index e27e567..13552bc 100644
--- a/app/src/main/java/org/wikipedia/feed/view/FeedAdapter.java
+++ b/app/src/main/java/org/wikipedia/feed/view/FeedAdapter.java
@@ -3,6 +3,7 @@
 import android.content.Context;
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
+import android.support.v7.widget.StaggeredGridLayoutManager;
 import android.view.View;
 import android.view.ViewGroup;
 
@@ -66,6 +67,11 @@
 
 @Override public void onViewAttachedToWindow(DefaultViewHolder holder) {
 super.onViewAttachedToWindow(holder);
+if (holder.getView() instanceof SearchCardView) {
+StaggeredGridLayoutManager.LayoutParams layoutParams
+= (StaggeredGridLayoutManager.LayoutParams) 
holder.getView().getLayoutParams();
+layoutParams.setFullSpan(true);
+}
 holder.getView().setCallback(callback);
 if (callback != null) {
 callback.onShowCard(holder.getView().getCard());

-- 
To view, visit https://gerrit.wikimedia.org/r/368104
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I55250b2be2c4d87f0384db44bf95e48e834d75b4
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits