[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Show error message in a scrollable view in landscape mode

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371970 )

Change subject: Show error message in a scrollable view in landscape mode
..


Show error message in a scrollable view in landscape mode

To solve the problem of the error view that can not be seen completely when the 
device is offline is added a NestedScrollView.

Bug: T172701
Change-Id: I0f2e53de4179a8d33dfd52abe66290bbe706ddae
---
M app/src/main/res/layout/view_wiki_error.xml
1 file changed, 67 insertions(+), 55 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/app/src/main/res/layout/view_wiki_error.xml 
b/app/src/main/res/layout/view_wiki_error.xml
index cb514f0..e890a3d 100644
--- a/app/src/main/res/layout/view_wiki_error.xml
+++ b/app/src/main/res/layout/view_wiki_error.xml
@@ -2,71 +2,83 @@
 http://schemas.android.com/apk/res/android;
 xmlns:app="http://schemas.android.com/apk/res-auto;
 xmlns:tools="http://schemas.android.com/tools;
-tools:parentTag="LinearLayout"
-tools:orientation="vertical"
+tools:layout_height="wrap_content"
 tools:layout_width="wrap_content"
-tools:layout_height="wrap_content">
+tools:orientation="vertical"
+tools:parentTag="LinearLayout">
 
-
+android:layout_height="match_parent"
+android:fillViewport="true">
 
-
+android:orientation="vertical">
 
-
+
 
-
+
 
-
-
+
 
-
+
 
-
+
+
 
-
-
+
+
+
+
+
+
+
+
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0f2e53de4179a8d33dfd52abe66290bbe706ddae
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Jcasariego 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Show error message in a scrollable view in landscape mode

[Jcasariego (Code Review)]

Jcasariego has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371970 )

Change subject: Show error message in a scrollable view in landscape mode
..

Show error message in a scrollable view in landscape mode

To solve the problem of the error view that can not be seen completely when the 
device is offline is added a NestedScrollView.

Bug: T172701
Change-Id: I0f2e53de4179a8d33dfd52abe66290bbe706ddae
---
M app/src/main/res/layout/view_wiki_error.xml
1 file changed, 67 insertions(+), 55 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/70/371970/1

diff --git a/app/src/main/res/layout/view_wiki_error.xml 
b/app/src/main/res/layout/view_wiki_error.xml
index cb514f0..e890a3d 100644
--- a/app/src/main/res/layout/view_wiki_error.xml
+++ b/app/src/main/res/layout/view_wiki_error.xml
@@ -2,71 +2,83 @@
 http://schemas.android.com/apk/res/android;
 xmlns:app="http://schemas.android.com/apk/res-auto;
 xmlns:tools="http://schemas.android.com/tools;
-tools:parentTag="LinearLayout"
-tools:orientation="vertical"
+tools:layout_height="wrap_content"
 tools:layout_width="wrap_content"
-tools:layout_height="wrap_content">
+tools:orientation="vertical"
+tools:parentTag="LinearLayout">
 
-
+android:layout_height="match_parent"
+android:fillViewport="true">
 
-
+android:orientation="vertical">
 
-
+
 
-
+
 
-
-
+
 
-
+
 
-
+
+
 
-
-
+
+
+
+
+
+
+
+
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f2e53de4179a8d33dfd52abe66290bbe706ddae
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Jcasariego 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits