[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Upgrade to Support Library v25.0.0
jenkins-bot has submitted this change and it was merged.
Change subject: Upgrade to Support Library v25.0.0
..
Upgrade to Support Library v25.0.0
Upgrade the Support Libraries to v25.0.0[0], buildToolsVersion to
v25.0.0[1], and compileSdkVersion to 25. There were several bugs
mentioned in the Android subreddit[2,3,4,5] but none I could repro in
the app. There was one noteworthy new feature added mentioned in the
release notes that is not tracked in Phabricator:
The new DiffUtil class can calculate the difference between two
collections, and can dispatch a list of update operations that are
suitable to be consumed by a RecyclerView.Adapter.
The paradigm for Gradle dependencies is unclear. The Topeka[6] example
doesn't match the library breakdown by feature[7].
The upgrade does not seem to have affected any of the Spoon or unit
screenshot tests.
[0] https://developer.android.com/topic/libraries/support-library/revisions.html
[1] https://developer.android.com/studio/releases/build-tools.html
[2]
https://www.reddit.com/r/androiddev/comments/500cx9/android_design_support_2420_update_password/
[3]
https://www.reddit.com/r/androiddev/comments/52m6ac/android_support_library_revision_2421_released/
[4]
https://www.reddit.com/r/androiddev/comments/4y70e7/android_support_library_v242_released/
[5]
https://www.reddit.com/r/androiddev/comments/58czcd/support_lib_25_with_bottomnavigationview/
[6]
https://github.com/googlesamples/android-topeka/blob/ed5573691843d6afde4086f86ed2f7659016ec9b/app/build.gradle
[7] https://developer.android.com/topic/libraries/support-library/features.html
Bug: T144318
Change-Id: Ibdf76a6b640b5cb749caaf2b3e4bb3186d6fa710
---
M app/build.gradle
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
Mholloway: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/build.gradle b/app/build.gradle
index e5271d5..755a549 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -40,9 +40,9 @@
final JavaVersion JAVA_VERSION = JavaVersion.VERSION_1_7
android {
// Keep version in sync with /project.properties
-compileSdkVersion 24
+compileSdkVersion 25
-buildToolsVersion '23.0.3'
+buildToolsVersion '25.0.0'
compileOptions {
sourceCompatibility = JAVA_VERSION
targetCompatibility = JAVA_VERSION
@@ -167,7 +167,7 @@
String okHttpVersion = '3.4.1'
String retrofitVersion = '2.1.0'
-String supportVersion = '24.1.1'
+String supportVersion = '25.0.0'
String espressoVersion = '2.2.2'
String butterKnifeVersion = '8.4.0'
String frescoVersion = '0.13.0'
@@ -175,13 +175,18 @@
String mockitoCore = 'org.mockito:mockito-core:1.9.5'
String leakCanaryVersion = '1.5'
-compile "com.android.support:appcompat-v7:$supportVersion" // includes
support-v4
+compile "com.android.support:support-compat:$supportVersion"
+compile "com.android.support:support-core-utils:$supportVersion"
+compile "com.android.support:support-core-ui:$supportVersion"
+compile "com.android.support:support-fragment:$supportVersion"
+
compile "com.android.support:cardview-v7:$supportVersion"
compile "com.android.support:design:$supportVersion"
compile "com.android.support:recyclerview-v7:$supportVersion"
compile "com.android.support:percent:$supportVersion"
compile "com.android.support:palette-v7:$supportVersion"
compile "com.android.support:preference-v14:$supportVersion"
+
compile "com.facebook.fresco:animated-gif:$frescoVersion"
compile "com.facebook.fresco:fresco:$frescoVersion"
compile "com.facebook.fresco:imagepipeline-okhttp3:$frescoVersion"
--
To view, visit https://gerrit.wikimedia.org/r/319486
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdf76a6b640b5cb749caaf2b3e4bb3186d6fa710
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski
Gerrit-Reviewer: BearND
Gerrit-Reviewer: Brion VIBBER
Gerrit-Reviewer: Dbrant
Gerrit-Reviewer: Mholloway
Gerrit-Reviewer: Niedzielski
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Upgrade to Support Library v25.0.0
Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319486
Change subject: Upgrade to Support Library v25.0.0
..
Upgrade to Support Library v25.0.0
Upgrade the Support Libraries to v25.0.0[0], buildToolsVersion to
v25.0.0[1], and compileSdkVersion to 25. There were several bugs
mentioned in the Android subreddit[2,3,4,5] but none I could repro in
the app. There was one noteworthy new feature added mentioned in the
release notes that is not tracked in Phabricator:
The new DiffUtil class can calculate the difference between two
collections, and can dispatch a list of update operations that are
suitable to be consumed by a RecyclerView.Adapter.
The paradigm for Gradle dependencies is unclear. The Topeka[6] example
doesn't match the library breakdown by feature[7].
The upgrade does not seem to have affected any of the Spoon or unit
screenshot tests.
[0] https://developer.android.com/topic/libraries/support-library/revisions.html
[1] https://developer.android.com/studio/releases/build-tools.html
[2]
https://www.reddit.com/r/androiddev/comments/500cx9/android_design_support_2420_update_password/
[3]
https://www.reddit.com/r/androiddev/comments/52m6ac/android_support_library_revision_2421_released/
[4]
https://www.reddit.com/r/androiddev/comments/4y70e7/android_support_library_v242_released/
[5]
https://www.reddit.com/r/androiddev/comments/58czcd/support_lib_25_with_bottomnavigationview/
[6]
https://github.com/googlesamples/android-topeka/blob/ed5573691843d6afde4086f86ed2f7659016ec9b/app/build.gradle
[7] https://developer.android.com/topic/libraries/support-library/features.html
Bug: T144318
Change-Id: Ibdf76a6b640b5cb749caaf2b3e4bb3186d6fa710
---
M app/build.gradle
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/86/319486/1
diff --git a/app/build.gradle b/app/build.gradle
index e5271d5..755a549 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -40,9 +40,9 @@
final JavaVersion JAVA_VERSION = JavaVersion.VERSION_1_7
android {
// Keep version in sync with /project.properties
-compileSdkVersion 24
+compileSdkVersion 25
-buildToolsVersion '23.0.3'
+buildToolsVersion '25.0.0'
compileOptions {
sourceCompatibility = JAVA_VERSION
targetCompatibility = JAVA_VERSION
@@ -167,7 +167,7 @@
String okHttpVersion = '3.4.1'
String retrofitVersion = '2.1.0'
-String supportVersion = '24.1.1'
+String supportVersion = '25.0.0'
String espressoVersion = '2.2.2'
String butterKnifeVersion = '8.4.0'
String frescoVersion = '0.13.0'
@@ -175,13 +175,18 @@
String mockitoCore = 'org.mockito:mockito-core:1.9.5'
String leakCanaryVersion = '1.5'
-compile "com.android.support:appcompat-v7:$supportVersion" // includes
support-v4
+compile "com.android.support:support-compat:$supportVersion"
+compile "com.android.support:support-core-utils:$supportVersion"
+compile "com.android.support:support-core-ui:$supportVersion"
+compile "com.android.support:support-fragment:$supportVersion"
+
compile "com.android.support:cardview-v7:$supportVersion"
compile "com.android.support:design:$supportVersion"
compile "com.android.support:recyclerview-v7:$supportVersion"
compile "com.android.support:percent:$supportVersion"
compile "com.android.support:palette-v7:$supportVersion"
compile "com.android.support:preference-v14:$supportVersion"
+
compile "com.facebook.fresco:animated-gif:$frescoVersion"
compile "com.facebook.fresco:fresco:$frescoVersion"
compile "com.facebook.fresco:imagepipeline-okhttp3:$frescoVersion"
--
To view, visit https://gerrit.wikimedia.org/r/319486
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdf76a6b640b5cb749caaf2b3e4bb3186d6fa710
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
