[MediaWiki-commits] [Gerrit] build: Clean up fileExists config - change (oojs/ui)

2014-11-18 Thread Krinkle (Code Review) 
Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/174306

Change subject: build: Clean up fileExists config
..

build: Clean up fileExists config

Follows-up 7205b2a8. Avoid hardcoding invididual keys of this
object when it should use all keys (easy to go out of sync).

Change-Id: Icd055f44d4226cab504376067a6eddd75dcd3d46
---
M Gruntfile.js
1 file changed, 10 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/06/174306/1

diff --git a/Gruntfile.js b/Gruntfile.js
index 6d51162..4240c86 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -87,12 +87,16 @@
tmp: 'dist/tmp'
},
fileExists: {
-   src: modules['oojs-ui'].scripts.concat(
-   originalLessFiles['dist/oojs-ui-apex.css'],
-   originalLessFiles['dist/oojs-ui-apex.svg.css'],
-   originalLessFiles['dist/oojs-ui-mediawiki.css'],
-   
originalLessFiles['dist/oojs-ui-mediawiki.svg.css']
-   )
+   src: ( function () {
+   var distFile,
+   files = 
modules['oojs-ui'].scripts.slice();
+
+   for ( distFile in originalLessFiles ) {
+   files.push.apply( files, 
originalLessFiles[distFile] );
+   }
+
+   return files;
+   }() )
},
concat: {
options: {

-- 
To view, visit https://gerrit.wikimedia.org/r/174306
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd055f44d4226cab504376067a6eddd75dcd3d46
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Krinkle krinklem...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] build: Clean up fileExists config - change (oojs/ui)

2014-11-18 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: build: Clean up fileExists config
..


build: Clean up fileExists config

Follows-up 7205b2a8. Avoid hardcoding invididual keys of this
object when it should use all keys (easy to go out of sync).

Change-Id: Icd055f44d4226cab504376067a6eddd75dcd3d46
---
M Gruntfile.js
1 file changed, 10 insertions(+), 6 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Gruntfile.js b/Gruntfile.js
index 6d51162..4240c86 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -87,12 +87,16 @@
tmp: 'dist/tmp'
},
fileExists: {
-   src: modules['oojs-ui'].scripts.concat(
-   originalLessFiles['dist/oojs-ui-apex.css'],
-   originalLessFiles['dist/oojs-ui-apex.svg.css'],
-   originalLessFiles['dist/oojs-ui-mediawiki.css'],
-   
originalLessFiles['dist/oojs-ui-mediawiki.svg.css']
-   )
+   src: ( function () {
+   var distFile,
+   files = 
modules['oojs-ui'].scripts.slice();
+
+   for ( distFile in originalLessFiles ) {
+   files.push.apply( files, 
originalLessFiles[distFile] );
+   }
+
+   return files;
+   }() )
},
concat: {
options: {

-- 
To view, visit https://gerrit.wikimedia.org/r/174306
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd055f44d4226cab504376067a6eddd75dcd3d46
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Krinkle krinklem...@gmail.com
Gerrit-Reviewer: Jforrester jforres...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits