[MediaWiki-commits] [Gerrit] ganglia: Fix PEP8 violations - change (operations/puppet)

2016-05-28 Thread Ori.livneh (Code Review) 
Ori.livneh has submitted this change and it was merged.

Change subject: ganglia: Fix PEP8 violations
..


ganglia: Fix PEP8 violations

* F401 'stat' imported but unused
* F401 'traceback' imported but unused
* F811 redefinition of unused 'os' from line 50
* F841 local variable 'e' is assigned to but never used

Change-Id: I5e7f01eb6061ec5446deba77abfab54f0ca54c42
---
M modules/ganglia/files/plugins/diskstat.py
M modules/ganglia/files/plugins/udp2log_socket.py
2 files changed, 1 insertion(+), 4 deletions(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved



diff --git a/modules/ganglia/files/plugins/diskstat.py 
b/modules/ganglia/files/plugins/diskstat.py
index 12af913..d4a5efb 100644
--- a/modules/ganglia/files/plugins/diskstat.py
+++ b/modules/ganglia/files/plugins/diskstat.py
@@ -45,7 +45,6 @@
 
 import time
 import subprocess
-import traceback
 import logging
 import os
 import stat
@@ -529,7 +528,6 @@
 
 if __name__ == '__main__':
 from optparse import OptionParser
-import os
 
 logging.debug('running from cmd line')
 parser = OptionParser()
diff --git a/modules/ganglia/files/plugins/udp2log_socket.py 
b/modules/ganglia/files/plugins/udp2log_socket.py
index 2721464..7da7011 100644
--- a/modules/ganglia/files/plugins/udp2log_socket.py
+++ b/modules/ganglia/files/plugins/udp2log_socket.py
@@ -25,7 +25,6 @@
 from threading import Timer
 import logging
 import os
-import stat
 
 
 UPDATE_INTERVAL = 5  # seconds
@@ -57,7 +56,7 @@
 p_index = False
 try:
 p_index = cmd.index('-p')
-except ValueError, e:
+except ValueError:
 continue
 ports.append(int(cmd[p_index + 1]))
 return ports

-- 
To view, visit https://gerrit.wikimedia.org/r/291179
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5e7f01eb6061ec5446deba77abfab54f0ca54c42
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BryanDavis 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] ganglia: Fix PEP8 violations - change (operations/puppet)

2016-05-27 Thread BryanDavis (Code Review) 
BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291179

Change subject: ganglia: Fix PEP8 violations
..

ganglia: Fix PEP8 violations

* F401 'stat' imported but unused
* F401 'traceback' imported but unused
* F811 redefinition of unused 'os' from line 50
* F841 local variable 'e' is assigned to but never used

Change-Id: I5e7f01eb6061ec5446deba77abfab54f0ca54c42
---
M modules/ganglia/files/plugins/diskstat.py
M modules/ganglia/files/plugins/udp2log_socket.py
2 files changed, 1 insertion(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/79/291179/1

diff --git a/modules/ganglia/files/plugins/diskstat.py 
b/modules/ganglia/files/plugins/diskstat.py
index 12af913..d4a5efb 100644
--- a/modules/ganglia/files/plugins/diskstat.py
+++ b/modules/ganglia/files/plugins/diskstat.py
@@ -45,7 +45,6 @@
 
 import time
 import subprocess
-import traceback
 import logging
 import os
 import stat
@@ -529,7 +528,6 @@
 
 if __name__ == '__main__':
 from optparse import OptionParser
-import os
 
 logging.debug('running from cmd line')
 parser = OptionParser()
diff --git a/modules/ganglia/files/plugins/udp2log_socket.py 
b/modules/ganglia/files/plugins/udp2log_socket.py
index 2721464..7da7011 100644
--- a/modules/ganglia/files/plugins/udp2log_socket.py
+++ b/modules/ganglia/files/plugins/udp2log_socket.py
@@ -25,7 +25,6 @@
 from threading import Timer
 import logging
 import os
-import stat
 
 
 UPDATE_INTERVAL = 5  # seconds
@@ -57,7 +56,7 @@
 p_index = False
 try:
 p_index = cmd.index('-p')
-except ValueError, e:
+except ValueError:
 continue
 ports.append(int(cmd[p_index + 1]))
 return ports

-- 
To view, visit https://gerrit.wikimedia.org/r/291179
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e7f01eb6061ec5446deba77abfab54f0ca54c42
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BryanDavis 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits