[MediaWiki-commits] [Gerrit] i18n: give grep a chance to find the usages - change (mediawiki...Wikibase)

2014-02-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: i18n: give grep a chance to find the usages
..


i18n: give grep a chance to find the usages

Change-Id: I81644dd310b2fb91c0def8a348e91f467654a74a
---
M lib/includes/ClaimDifferenceVisualizer.php
M lib/includes/changes/EntityChange.php
M lib/includes/formatters/QuantityDetailsFormatter.php
M repo/includes/ClaimHtmlGenerator.php
M repo/includes/MultiLangConstraintDetector.php
M repo/includes/content/EntityContent.php
M repo/includes/specials/SpecialMergeItems.php
M repo/includes/specials/SpecialModifyTerm.php
M repo/includes/specials/SpecialMyLanguageFallbackChain.php
9 files changed, 22 insertions(+), 3 deletions(-)

Approvals:
  WikidataJenkins: Verified
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/includes/ClaimDifferenceVisualizer.php 
b/lib/includes/ClaimDifferenceVisualizer.php
index 367dc5a..bbe7980 100644
--- a/lib/includes/ClaimDifferenceVisualizer.php
+++ b/lib/includes/ClaimDifferenceVisualizer.php
@@ -224,6 +224,8 @@
$rank = ClaimSerializer::serializeRank( $rank );
}
 
+   // Messages: wikibase-diffview-rank-preferred, 
wikibase-diffview-rank-normal,
+   // wikibase-diffview-rank-deprecated
$msg = wfMessage( 'wikibase-diffview-rank-' . $rank );
return $msg-inLanguage( $this-langCode )-parse();
}
diff --git a/lib/includes/changes/EntityChange.php 
b/lib/includes/changes/EntityChange.php
index d68e747..d4a3df7 100644
--- a/lib/includes/changes/EntityChange.php
+++ b/lib/includes/changes/EntityChange.php
@@ -193,6 +193,8 @@
if ( $comment !== null ) {
$this-comment = $comment;
} else {
+   // Messages: wikibase-comment-add, 
wikibase-comment-remove, wikibase-comment-linked,
+   // wikibase-comment-unlink, wikibase-comment-restore, 
wikibase-comment-update
$this-comment = 'wikibase-comment-' . 
$this-getAction();
}
}
diff --git a/lib/includes/formatters/QuantityDetailsFormatter.php 
b/lib/includes/formatters/QuantityDetailsFormatter.php
index 3a5c63d..952c40a 100644
--- a/lib/includes/formatters/QuantityDetailsFormatter.php
+++ b/lib/includes/formatters/QuantityDetailsFormatter.php
@@ -86,6 +86,8 @@
protected function getFieldLabel( $fieldName ) {
$lang = $this-getOption( ValueFormatter::OPT_LANG );
 
+   // Messages: wikibase-quantitydetails-amount, 
wikibase-quantitydetails-upperbound,
+   // wikibase-quantitydetails-lowerbound, 
wikibase-quantitydetails-unit
$key = 'wikibase-quantitydetails-' . strtolower( $fieldName );
$msg = wfMessage( $key )-inLanguage( $lang );
 
diff --git a/repo/includes/ClaimHtmlGenerator.php 
b/repo/includes/ClaimHtmlGenerator.php
index 6cd49dc..3e7e254 100644
--- a/repo/includes/ClaimHtmlGenerator.php
+++ b/repo/includes/ClaimHtmlGenerator.php
@@ -102,6 +102,8 @@
if( is_a( $claim, 'Wikibase\Statement' ) ) {
$serializedRank = ClaimSerializer::serializeRank( 
$claim-getRank() );
 
+   // Messages: wikibase-statementview-rank-preferred, 
wikibase-statementview-rank-normal,
+   // wikibase-statementview-rank-deprecated
$rankHtml = wfTemplate( 'wb-rankselector',
'wb-rankselector-' . $serializedRank,
wfMessage( 'wikibase-statementview-rank-' . 
$serializedRank )-text()
diff --git a/repo/includes/MultiLangConstraintDetector.php 
b/repo/includes/MultiLangConstraintDetector.php
index 0527454..ab224f1 100644
--- a/repo/includes/MultiLangConstraintDetector.php
+++ b/repo/includes/MultiLangConstraintDetector.php
@@ -145,7 +145,7 @@
}
);
$langValues = $wgLang-semicolonList( 
$langValues );
-   // Give grep a chance to find the usages: 
wikibase-error-constraint-violation-label,
+   // Messages: 
wikibase-error-constraint-violation-label,
// 
wikibase-error-constraint-violation-description, 
wikibase-error-constraint-violation-aliases
$status-fatal(
'wikibase-error-constraint-violation-' 
. $section,
diff --git a/repo/includes/content/EntityContent.php 
b/repo/includes/content/EntityContent.php
index 16b71ad..9634e2e 100644
--- a/repo/includes/content/EntityContent.php
+++ b/repo/includes/content/EntityContent.php
@@ -719,8 +719,7 @@
 */
foreach ( $foundLabels as $foundLabel ) {
if (

[MediaWiki-commits] [Gerrit] i18n: give grep a chance to find the usages - change (mediawiki...Wikibase)

2014-02-03 Thread Shirayuki (Code Review) 
Shirayuki has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/110950

Change subject: i18n: give grep a chance to find the usages
..

i18n: give grep a chance to find the usages

Change-Id: I81644dd310b2fb91c0def8a348e91f467654a74a
---
M lib/includes/ClaimDifferenceVisualizer.php
M lib/includes/changes/EntityChange.php
M lib/includes/formatters/QuantityDetailsFormatter.php
M repo/includes/ClaimHtmlGenerator.php
M repo/includes/MultiLangConstraintDetector.php
M repo/includes/content/EntityContent.php
M repo/includes/specials/SpecialMergeItems.php
M repo/includes/specials/SpecialModifyTerm.php
M repo/includes/specials/SpecialMyLanguageFallbackChain.php
9 files changed, 22 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/50/110950/1

diff --git a/lib/includes/ClaimDifferenceVisualizer.php 
b/lib/includes/ClaimDifferenceVisualizer.php
index 367dc5a..bbe7980 100644
--- a/lib/includes/ClaimDifferenceVisualizer.php
+++ b/lib/includes/ClaimDifferenceVisualizer.php
@@ -224,6 +224,8 @@
$rank = ClaimSerializer::serializeRank( $rank );
}
 
+   // Messages: wikibase-diffview-rank-preferred, 
wikibase-diffview-rank-normal,
+   // wikibase-diffview-rank-deprecated
$msg = wfMessage( 'wikibase-diffview-rank-' . $rank );
return $msg-inLanguage( $this-langCode )-parse();
}
diff --git a/lib/includes/changes/EntityChange.php 
b/lib/includes/changes/EntityChange.php
index d68e747..d4a3df7 100644
--- a/lib/includes/changes/EntityChange.php
+++ b/lib/includes/changes/EntityChange.php
@@ -193,6 +193,8 @@
if ( $comment !== null ) {
$this-comment = $comment;
} else {
+   // Messages: wikibase-comment-add, 
wikibase-comment-remove, wikibase-comment-linked,
+   // wikibase-comment-unlink, wikibase-comment-restore, 
wikibase-comment-update
$this-comment = 'wikibase-comment-' . 
$this-getAction();
}
}
diff --git a/lib/includes/formatters/QuantityDetailsFormatter.php 
b/lib/includes/formatters/QuantityDetailsFormatter.php
index 3a5c63d..952c40a 100644
--- a/lib/includes/formatters/QuantityDetailsFormatter.php
+++ b/lib/includes/formatters/QuantityDetailsFormatter.php
@@ -86,6 +86,8 @@
protected function getFieldLabel( $fieldName ) {
$lang = $this-getOption( ValueFormatter::OPT_LANG );
 
+   // Messages: wikibase-quantitydetails-amount, 
wikibase-quantitydetails-upperbound,
+   // wikibase-quantitydetails-lowerbound, 
wikibase-quantitydetails-unit
$key = 'wikibase-quantitydetails-' . strtolower( $fieldName );
$msg = wfMessage( $key )-inLanguage( $lang );
 
diff --git a/repo/includes/ClaimHtmlGenerator.php 
b/repo/includes/ClaimHtmlGenerator.php
index 6cd49dc..3e7e254 100644
--- a/repo/includes/ClaimHtmlGenerator.php
+++ b/repo/includes/ClaimHtmlGenerator.php
@@ -102,6 +102,8 @@
if( is_a( $claim, 'Wikibase\Statement' ) ) {
$serializedRank = ClaimSerializer::serializeRank( 
$claim-getRank() );
 
+   // Messages: wikibase-statementview-rank-preferred, 
wikibase-statementview-rank-normal,
+   // wikibase-statementview-rank-deprecated
$rankHtml = wfTemplate( 'wb-rankselector',
'wb-rankselector-' . $serializedRank,
wfMessage( 'wikibase-statementview-rank-' . 
$serializedRank )-text()
diff --git a/repo/includes/MultiLangConstraintDetector.php 
b/repo/includes/MultiLangConstraintDetector.php
index 0527454..ab224f1 100644
--- a/repo/includes/MultiLangConstraintDetector.php
+++ b/repo/includes/MultiLangConstraintDetector.php
@@ -145,7 +145,7 @@
}
);
$langValues = $wgLang-semicolonList( 
$langValues );
-   // Give grep a chance to find the usages: 
wikibase-error-constraint-violation-label,
+   // Messages: 
wikibase-error-constraint-violation-label,
// 
wikibase-error-constraint-violation-description, 
wikibase-error-constraint-violation-aliases
$status-fatal(
'wikibase-error-constraint-violation-' 
. $section,
diff --git a/repo/includes/content/EntityContent.php 
b/repo/includes/content/EntityContent.php
index 16b71ad..9634e2e 100644
--- a/repo/includes/content/EntityContent.php
+++ b/repo/includes/content/EntityContent.php
@@ -719,8 +719,7 @@
 */
foreach ( $foundLabels as $foundLabel ) {