[MediaWiki-commits] [Gerrit] i18nize [[Special:RandomInCategory]] submit button - change (mediawiki/core)

2015-07-05 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: i18nize [[Special:RandomInCategory]] submit button
..


i18nize [[Special:RandomInCategory]] submit button

This commit fixes a regression caused by an earlier refactor of the
Special:RandomInCategory page, which introduced message reuse. This
commit splits the message again.

Bug: T101717
Change-Id: Iabfe172b2e1d8464262b244337789bca388460f8
---
M includes/specials/SpecialRandomInCategory.php
M languages/i18n/en.json
M languages/i18n/qqq.json
3 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Umherirrender: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specials/SpecialRandomInCategory.php 
b/includes/specials/SpecialRandomInCategory.php
index b5c9e19..e21eaeb 100644
--- a/includes/specials/SpecialRandomInCategory.php
+++ b/includes/specials/SpecialRandomInCategory.php
@@ -89,6 +89,10 @@
return false;
}
 
+   protected function alterForm( HTMLForm $form ) {
+   $form->setSubmitTextMsg( 'randomincategory-submit' );
+   }
+
protected function setParameter( $par ) {
// if subpage present, fake form submission
$this->onSubmit( array( 'category' => $par ) );
diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index 2a22479..3a47bce 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -1575,6 +1575,7 @@
"randomincategory-nopages": "There are no pages in the 
[[:Category:$1|$1]] category.",
"randomincategory-category": "Category:",
"randomincategory-legend": "Random page in category",
+   "randomincategory-submit": "Go",
"randomredirect": "Random redirect",
"randomredirect-nopages": "There are no redirects in the namespace 
\"$1\".",
"statistics": "Statistics",
diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json
index 777c7f1..915e1750 100644
--- a/languages/i18n/qqq.json
+++ b/languages/i18n/qqq.json
@@ -1745,6 +1745,7 @@
"randomincategory-nopages": "Message shown from 
[[Special:RandomInCategory]] if the category is empty.\n\nParameters:\n* $1 - 
the category name (without the namespace prefix)",
"randomincategory-category": "Shown on [[Special:RandomInCategory]] as 
a label for a text box allowing the user to input a category 
name.\n{{Identical|Category}}",
"randomincategory-legend": "Used as fieldset label for the form on 
[[Special:RandomInCategory]].",
+   "randomincategory-submit": "Used as label for the Submit button on 
[[Special:RandomInCategory]].\n{{Identical|Go}}",
"randomredirect": "{{doc-special|RandomRedirect}}",
"randomredirect-nopages": "Parameters:\n* $1 - list of namespaces\n* $2 
- (Unused) number of namespaces\nSee also:\n* {{msg-mw|Randompage-nopages}}",
"statistics": "{{doc-special|Statistics}}\n{{Identical|Statistics}}",

-- 
To view, visit https://gerrit.wikimedia.org/r/216765
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iabfe172b2e1d8464262b244337789bca388460f8
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Microchip08 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Microchip08 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] i18nize [[Special:RandomInCategory]] submit button - change (mediawiki/core)

2015-06-08 Thread Microchip08 (Code Review)
Microchip08 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/216765

Change subject: i18nize [[Special:RandomInCategory]] submit button
..

i18nize [[Special:RandomInCategory]] submit button

This commit fixes a regression caused by an earlier refactor of the
Special:RandomInCategory page, which introduced message reuse. This
commit splits the message again.

Bug: T101717
Change-Id: Iabfe172b2e1d8464262b244337789bca388460f8
---
M includes/specials/SpecialRandomInCategory.php
M languages/i18n/en.json
M languages/i18n/qqq.json
3 files changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/65/216765/1

diff --git a/includes/specials/SpecialRandomInCategory.php 
b/includes/specials/SpecialRandomInCategory.php
index b5c9e19..7e6043b 100644
--- a/includes/specials/SpecialRandomInCategory.php
+++ b/includes/specials/SpecialRandomInCategory.php
@@ -89,6 +89,10 @@
return false;
}
 
+   public function alterForm( $form ) {
+   $form->setSubmitTextMsg( 'randomincategory-submit' );
+   }
+
protected function setParameter( $par ) {
// if subpage present, fake form submission
$this->onSubmit( array( 'category' => $par ) );
diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index d632b9f..887d5fe 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -1576,6 +1576,7 @@
"randomincategory-nopages": "There are no pages in the 
[[:Category:$1|$1]] category.",
"randomincategory-category": "Category:",
"randomincategory-legend": "Random page in category",
+   "randomincategory-submit": "Go",
"randomredirect": "Random redirect",
"randomredirect-nopages": "There are no redirects in the namespace 
\"$1\".",
"statistics": "Statistics",
diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json
index cd2e0e2..e906f35 100644
--- a/languages/i18n/qqq.json
+++ b/languages/i18n/qqq.json
@@ -1746,6 +1746,7 @@
"randomincategory-nopages": "Message shown from 
[[Special:RandomInCategory]] if the category is empty.\n\nParameters:\n* $1 - 
the category name (without the namespace prefix)",
"randomincategory-category": "Shown on [[Special:RandomInCategory]] as 
a label for a text box allowing the user to input a category 
name.\n{{Identical|Category}}",
"randomincategory-legend": "Used as fieldset label for the form on 
[[Special:RandomInCategory]].",
+   "randomincategory-submit": "Used as label for the Submit button on 
[[Special:RandomInCategory]].\n{{Identical|Go}}",
"randomredirect": "{{doc-special|RandomRedirect}}",
"randomredirect-nopages": "Parameters:\n* $1 - list of namespaces\n* $2 
- (Unused) number of namespaces\nSee also:\n* {{msg-mw|Randompage-nopages}}",
"statistics": "{{doc-special|Statistics}}\n{{Identical|Statistics}}",

-- 
To view, visit https://gerrit.wikimedia.org/r/216765
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabfe172b2e1d8464262b244337789bca388460f8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Microchip08 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits