Jeroen De Dauw has submitted this change and it was merged.
Change subject: jqPlot re-factoring Part II (relates to bug 35627) (major)
..
jqPlot re-factoring Part II (relates to bug 35627) (major)
## Description
Part II of the re-factoring effort was to ensure that the jqplot printer
and its JavaScript plug-ins are used throughout RL, eliminate identical
code among jqplotbar and jqplotpie classes, and make use of the
same JavaScript for both jqplot.series and jqplot.chart class.
The consequence is that jqplotbar and jqplotpie merged into the
jqplotchart class.
Additional message items will be posted in a subsequent commit to
avoid conflicts with l18n.
A more comprehensive description can be found under [1] and [2]
## Notes
[1] http://www.semantic-mediawiki.org/wiki/Help:Jqplotseries_format
[2] http://www.semantic-mediawiki.org/wiki/Help:Jqplotchart_format
## Patchsets
+1 initial commit, added test files
+2 kill whitespaces
+3 reinstated the overriden $moduleTemplate definitions
+4 rearranged and merged js files (avoid dublicate code saving
15% of code), jshint checked (all its conditions are met)
+5 kill whitespaces
Change-Id: I3c8847aa9072f7302346f0b272e3bba15cac3298
---
M SRF_Hooks.php
M SRF_Resources.php
M SRF_Settings.php
M SemanticResultFormats.php
D formats/jqplot/README.md
M formats/jqplot/SRF_jqPlot.php
D formats/jqplot/SRF_jqPlotBar.php
A formats/jqplot/SRF_jqPlotChart.php
D formats/jqplot/SRF_jqPlotPie.php
M formats/jqplot/SRF_jqPlotSeries.php
A formats/jqplot/resources/ext.srf.jqlpot.general.css
D formats/jqplot/resources/ext.srf.jqplot.bar.js
D formats/jqplot/resources/ext.srf.jqplot.bubble.js
A formats/jqplot/resources/ext.srf.jqplot.chart.js
D formats/jqplot/resources/ext.srf.jqplot.pie.js
M formats/jqplot/resources/ext.srf.jqplot.themes.js
R resources/jquery.jqplot/excanvas.min.js
R resources/jquery.jqplot/jqPlot.Copyright
R resources/jquery.jqplot/jqPlot.MIT LICENSE
R resources/jquery.jqplot/jqplot.barRenderer.min.js
R resources/jquery.jqplot/jqplot.bubbleRenderer.min.js
R resources/jquery.jqplot/jqplot.canvasAxisLabelRenderer.min.js
R resources/jquery.jqplot/jqplot.canvasAxisTickRenderer.min.js
R resources/jquery.jqplot/jqplot.canvasTextRenderer.min.js
R resources/jquery.jqplot/jqplot.categoryAxisRenderer.min.js
A resources/jquery.jqplot/jqplot.cursor.min.js
R resources/jquery.jqplot/jqplot.donutRenderer.min.js
A resources/jquery.jqplot/jqplot.enhancedLegendRenderer.min.js
R resources/jquery.jqplot/jqplot.highlighter.min.js
R resources/jquery.jqplot/jqplot.json2.min.js
R resources/jquery.jqplot/jqplot.pieRenderer.min.js
R resources/jquery.jqplot/jqplot.pointLabels.min.js
R resources/jquery.jqplot/jqplot.trendline.min.js
R resources/jquery.jqplot/jquery.jqplot.css
R resources/jquery.jqplot/jquery.jqplot.min.js
A tests/phpunit/formats/jqPlotChartTest.php
A tests/phpunit/formats/jqPlotSeriesTest.php
37 files changed, 1,411 insertions(+), 1,382 deletions(-)
Approvals:
Mwjames: Looks good to me, but someone else must approve
Jeroen De Dauw: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/17436
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c8847aa9072f7302346f0b272e3bba15cac3298
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/SemanticResultFormats
Gerrit-Branch: master
Gerrit-Owner: Mwjames
Gerrit-Reviewer: Jeroen De Dauw
Gerrit-Reviewer: Mwjames
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
