[MediaWiki-commits] [Gerrit] jquery.delayedBind → jquery.throttle-debounce - change (mediawiki...MassMessage)

2014-02-24 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: jquery.delayedBind → jquery.throttle-debounce
..


jquery.delayedBind → jquery.throttle-debounce

The former was deprecated in core. This breaks compatibility with MW1.23.

Change-Id: Ib1496e3c7abcd72c7abd7521061abf5042208eb3
---
M MassMessage.php
M modules/ext.MassMessage.badhtml.js
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/MassMessage.php b/MassMessage.php
index f7ba866..ea345ad 100644
--- a/MassMessage.php
+++ b/MassMessage.php
@@ -58,7 +58,7 @@
'author' = 'Kunal Mehta',
'url' = 'https://www.mediawiki.org/wiki/Extension:MassMessage',
'descriptionmsg' = 'massmessage-desc',
-   'version' = '0.0.2',
+   'version' = '0.0.3',
 );
 $dir = dirname( __FILE__ );
 
@@ -99,7 +99,7 @@
'dependencies' = array(
'jquery.byteLimit',
'jquery.ui.autocomplete',
-   'jquery.delayedBind',
+   'jquery.throttle-debounce',
'mediawiki.jqueryMsg',
),
'localBasePath' = $dir . '/modules',
diff --git a/modules/ext.MassMessage.badhtml.js 
b/modules/ext.MassMessage.badhtml.js
index a4acbf4..5efa7d2 100644
--- a/modules/ext.MassMessage.badhtml.js
+++ b/modules/ext.MassMessage.badhtml.js
@@ -12,7 +12,7 @@
.addClass( 'warningbox' );
$msg.after( $warnings );
$warnings.hide();
-   $msg.delayedBind( 500, 'keyup', function( ) {
+   $msg.on( 'keyup', $.debounce( 500, function( ) {
var code, matches, tags, possibles, tag;
code = $.trim( $msg.val() );
if( code === '' ) {
@@ -65,7 +65,7 @@
} else {
$warnings.hide();
}
-   });
+   } ) );
});
 
 }( mediaWiki, jQuery ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/115222
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1496e3c7abcd72c7abd7521061abf5042208eb3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MassMessage
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński matma@gmail.com
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] jquery.delayedBind → jquery.throttle-debounce - change (mediawiki...MassMessage)

2014-02-24 Thread Code Review 
Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/115222

Change subject: jquery.delayedBind → jquery.throttle-debounce
..

jquery.delayedBind → jquery.throttle-debounce

The former was deprecated in core. This breaks compatibility with MW1.23.

Change-Id: Ib1496e3c7abcd72c7abd7521061abf5042208eb3
---
M MassMessage.php
M modules/ext.MassMessage.badhtml.js
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage 
refs/changes/22/115222/1

diff --git a/MassMessage.php b/MassMessage.php
index f7ba866..cef60e0 100644
--- a/MassMessage.php
+++ b/MassMessage.php
@@ -99,7 +99,7 @@
'dependencies' = array(
'jquery.byteLimit',
'jquery.ui.autocomplete',
-   'jquery.delayedBind',
+   'jquery.throttle-debounce',
'mediawiki.jqueryMsg',
),
'localBasePath' = $dir . '/modules',
diff --git a/modules/ext.MassMessage.badhtml.js 
b/modules/ext.MassMessage.badhtml.js
index a4acbf4..5efa7d2 100644
--- a/modules/ext.MassMessage.badhtml.js
+++ b/modules/ext.MassMessage.badhtml.js
@@ -12,7 +12,7 @@
.addClass( 'warningbox' );
$msg.after( $warnings );
$warnings.hide();
-   $msg.delayedBind( 500, 'keyup', function( ) {
+   $msg.on( 'keyup', $.debounce( 500, function( ) {
var code, matches, tags, possibles, tag;
code = $.trim( $msg.val() );
if( code === '' ) {
@@ -65,7 +65,7 @@
} else {
$warnings.hide();
}
-   });
+   } ) );
});
 
 }( mediaWiki, jQuery ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/115222
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1496e3c7abcd72c7abd7521061abf5042208eb3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MassMessage
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński matma@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits