[MediaWiki-commits] [Gerrit] json syntax error with escaped single quotes - change (mediawiki...VisualEditor)
jenkins-bot has submitted this change and it was merged. Change subject: json syntax error with escaped single quotes .. json syntax error with escaped single quotes visualeditor-dialog-meta-settings-newsectioneditlink-default message has an escaped single quote which PHP json_decode() complains about with a syntax error. Since the string is between double quotes, I am removing the backslash and PHP json_decode() is happy again. You can try it using the PHP based linter in integration/jenkins.git as bin/json-lint.php Bug: 58279 Change-Id: Ife1e4723ba9e65b351d65a8691f4c8b8126cc867 --- M modules/ve-mw/i18n/qqq.json 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve-mw/i18n/qqq.json b/modules/ve-mw/i18n/qqq.json index 3cc9db1..78da413 100644 --- a/modules/ve-mw/i18n/qqq.json +++ b/modules/ve-mw/i18n/qqq.json @@ -85,7 +85,7 @@ "visualeditor-dialog-meta-settings-index-force": "Label for the option for indexing to be forced on.", "visualeditor-dialog-meta-settings-index-label": "Prompt to let the user set the indexing behaviour.", "visualeditor-dialog-meta-settings-label": "Title for the page settings dialog section.\n\nFollowed by the following labels:\n* {{msg-mw|Visualeditor-dialog-meta-settings-toc-default}}\n* {{msg-mw|Visualeditor-dialog-meta-settings-toc-force}}\n* {{msg-mw|Visualeditor-dialog-meta-settings-toc-disable}}\n{{Identical|Page settings}}", -"visualeditor-dialog-meta-settings-newsectioneditlink-default": "Label for the option to have the namespace\'s default new section creating link behaviour.", +"visualeditor-dialog-meta-settings-newsectioneditlink-default": "Label for the option to have the namespace's default new section creating link behaviour.", "visualeditor-dialog-meta-settings-newsectioneditlink-disable": "Label for the option to prevent the display of a new section creating link.", "visualeditor-dialog-meta-settings-newsectioneditlink-force": "Label for the option to force the display of a new section creating link.", "visualeditor-dialog-meta-settings-newsectioneditlink-label": "Prompt to let the user set the new section creating link behaviour.", -- To view, visit https://gerrit.wikimedia.org/r/114464 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife1e4723ba9e65b351d65a8691f4c8b8126cc867 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Hashar Gerrit-Reviewer: Jforrester Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] json syntax error with escaped single quotes - change (mediawiki...VisualEditor)
Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/114464 Change subject: json syntax error with escaped single quotes .. json syntax error with escaped single quotes visualeditor-dialog-meta-settings-newsectioneditlink-default message has an escaped single quote which PHP json_decode() complains about with a syntax error. Since the string is between double quotes, I am removing the backslash and PHP json_decode() is happy again. You can try it using the PHP based linter in integration/jenkins.git as bin/json-lint.php Bug: 58279 Change-Id: Ife1e4723ba9e65b351d65a8691f4c8b8126cc867 --- M modules/ve-mw/i18n/qqq.json 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/64/114464/1 diff --git a/modules/ve-mw/i18n/qqq.json b/modules/ve-mw/i18n/qqq.json index 3cc9db1..78da413 100644 --- a/modules/ve-mw/i18n/qqq.json +++ b/modules/ve-mw/i18n/qqq.json @@ -85,7 +85,7 @@ "visualeditor-dialog-meta-settings-index-force": "Label for the option for indexing to be forced on.", "visualeditor-dialog-meta-settings-index-label": "Prompt to let the user set the indexing behaviour.", "visualeditor-dialog-meta-settings-label": "Title for the page settings dialog section.\n\nFollowed by the following labels:\n* {{msg-mw|Visualeditor-dialog-meta-settings-toc-default}}\n* {{msg-mw|Visualeditor-dialog-meta-settings-toc-force}}\n* {{msg-mw|Visualeditor-dialog-meta-settings-toc-disable}}\n{{Identical|Page settings}}", -"visualeditor-dialog-meta-settings-newsectioneditlink-default": "Label for the option to have the namespace\'s default new section creating link behaviour.", +"visualeditor-dialog-meta-settings-newsectioneditlink-default": "Label for the option to have the namespace's default new section creating link behaviour.", "visualeditor-dialog-meta-settings-newsectioneditlink-disable": "Label for the option to prevent the display of a new section creating link.", "visualeditor-dialog-meta-settings-newsectioneditlink-force": "Label for the option to force the display of a new section creating link.", "visualeditor-dialog-meta-settings-newsectioneditlink-label": "Prompt to let the user set the new section creating link behaviour.", -- To view, visit https://gerrit.wikimedia.org/r/114464 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ife1e4723ba9e65b351d65a8691f4c8b8126cc867 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Hashar ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits