[MediaWiki-commits] [Gerrit] marvin[master]: Update: add initial page models and unmarshallers
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/382350 ) Change subject: Update: add initial page models and unmarshallers .. Update: add initial page models and unmarshallers - Add page models and unmarshallers. These can and probably need to be tightened up more but we also need to iterate. The API is hairy. - Stop linting *.test.json. MCS JSON responses may contain unescaped control characters which causes the JSON plugin to fail with "error: This character may get silently deleted by one or more browsers; bad-json". The plugin does not appear to respect the rule severity setting so it cannot be individually disabled. - Update PageSummary model to leverage the common parts of Page. - Rename summary input and expected result JSON files to conform to new convention. - Update summary BASE_URL to conform to new convention. Bug: T173321 Change-Id: Ide7ce6567ca188534b55786833f1889e2cee3dbf --- M .eslintignore M src/common/data-clients/page-summary-data-client.ts A src/common/marshallers/page-body-expected.test.json A src/common/marshallers/page-body-restbase.test.json A src/common/marshallers/page-expected.test.json A src/common/marshallers/page-lead-expected.test.json A src/common/marshallers/page-lead-restbase.test.json A src/common/marshallers/page-restbase.test.json R src/common/marshallers/page-summary-expected.test.json R src/common/marshallers/page-summary-restbase.test.json M src/common/marshallers/page-unmarshaller.test.ts M src/common/marshallers/page-unmarshaller.ts M src/common/marshallers/restbase.ts M src/common/models/page/image.ts A src/common/models/page/page-base.ts A src/common/models/page/page.ts M src/common/models/page/summary.ts A src/common/models/page/user.ts 18 files changed, 2,778 insertions(+), 45 deletions(-) Approvals: Jhernandez: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/382350 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide7ce6567ca188534b55786833f1889e2cee3dbf Gerrit-PatchSet: 1 Gerrit-Project: marvin Gerrit-Branch: master Gerrit-Owner: Niedzielski Gerrit-Reviewer: Jhernandez Gerrit-Reviewer: Sniedzielski Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] marvin[master]: Update: add initial page models and unmarshallers
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382350 ) Change subject: Update: add initial page models and unmarshallers .. Update: add initial page models and unmarshallers - Add page models and unmarshallers. These can and probably need to be tightened up more but we also need to iterate. The API is hairy. - Stop linting *.test.json. MCS JSON responses may contain unescaped control characters which causes the JSON plugin to fail with "error: This character may get silently deleted by one or more browsers; bad-json". The plugin does not appear to respect the rule severity setting so it cannot be individually disabled. - Update PageSummary model to leverage the common parts of Page. - Rename summary input and expected result JSON files to conform to new convention. - Update summary BASE_URL to conform to new convention. Bug: T173321 Change-Id: Ide7ce6567ca188534b55786833f1889e2cee3dbf --- M .eslintignore M src/common/data-clients/page-summary-data-client.ts A src/common/marshallers/page-body-expected.test.json A src/common/marshallers/page-body-restbase.test.json A src/common/marshallers/page-expected.test.json A src/common/marshallers/page-lead-expected.test.json A src/common/marshallers/page-lead-restbase.test.json A src/common/marshallers/page-restbase.test.json R src/common/marshallers/page-summary-expected.test.json R src/common/marshallers/page-summary-restbase.test.json M src/common/marshallers/page-unmarshaller.test.ts M src/common/marshallers/page-unmarshaller.ts M src/common/marshallers/restbase.ts M src/common/models/page/image.ts A src/common/models/page/page-base.ts A src/common/models/page/page.ts M src/common/models/page/summary.ts A src/common/models/page/user.ts 18 files changed, 2,778 insertions(+), 45 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/50/382350/1 -- To view, visit https://gerrit.wikimedia.org/r/382350 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ide7ce6567ca188534b55786833f1889e2cee3dbf Gerrit-PatchSet: 1 Gerrit-Project: marvin Gerrit-Branch: master Gerrit-Owner: Niedzielski Gerrit-Reviewer: Sniedzielski ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
