[MediaWiki-commits] [Gerrit] marvin[master]: Update: show image on image File pages
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/392078 )
Change subject: Update: show image on image File pages
..
Update: show image on image File pages
Add the missing image to File namespace pages.
https://www.mediawiki.org/wiki/Parsoid/Known_differences_with_PHP_parser_output#Differences_because_of_implementation_differences_or_functionality_gaps
Bug: T179829
Bug: T153801
Bug: T148118
Change-Id: I1289296431bc958927bd690eac6afbd442780df5
---
M package.json
A src/common/marshallers/page/file-page-lead-expected.test.json
A src/common/marshallers/page/file-page-lead-restbase.test.json
M src/common/marshallers/page/page-unmarshaller.test.ts
M src/common/marshallers/page/page-unmarshaller.ts
M src/common/marshallers/restbase.ts
M src/common/models/page/page-base.ts
M src/common/models/page/page.ts
M src/common/pages/wiki.tsx
9 files changed, 199 insertions(+), 5 deletions(-)
Approvals:
Jhernandez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/package.json b/package.json
index 72e1e48..4272f71 100644
--- a/package.json
+++ b/package.json
@@ -131,7 +131,7 @@
},
{
"path": "dist/public/pages/wiki.*.js",
- "maxSize": "3.3KB"
+ "maxSize": "3.6KB"
}
]
}
diff --git a/src/common/marshallers/page/file-page-lead-expected.test.json
b/src/common/marshallers/page/file-page-lead-expected.test.json
new file mode 100644
index 000..36f0fbc
--- /dev/null
+++ b/src/common/marshallers/page/file-page-lead-expected.test.json
@@ -0,0 +1,59 @@
+
+{
+ "pageID": 1228779,
+ "titleID": "File:Muybridge_race_horse_animated.gif",
+ "titleText": "File:Muybridge race horse animated.gif",
+ "titleHTML": "File:Muybridge race horse animated.gif",
+ "lastModified": "2017-03-22T17:20:33Z",
+ "descriptionText": "",
+ "etag": {
+"revision": 802006980,
+"timeID": "4f754377-a235-11e7-a776-efb84f18649a"
+ },
+ "revision": 238166671,
+ "namespace": 6,
+ "mainPage": false,
+ "disambiguationPage": false,
+ "lastModifier": {
+"anonymous": false,
+"user": "Kaldari",
+"gender": "unknown"
+ },
+ "permissions": {},
+ "editable": true,
+ "languageCount": 0,
+ "thumbnail": [
+{ "url":
"//upload.wikimedia.org/wikipedia/commons/d/dd/Muybridge_race_horse_animated.gif",
"width": 320 },
+{ "url":
"//upload.wikimedia.org/wikipedia/commons/d/dd/Muybridge_race_horse_animated.gif",
"width": 640 },
+{ "url":
"//upload.wikimedia.org/wikipedia/commons/d/dd/Muybridge_race_horse_animated.gif",
"width": 800 },
+{ "url":
"//upload.wikimedia.org/wikipedia/commons/d/dd/Muybridge_race_horse_animated.gif",
"width": 1024 }
+ ],
+ "fileImage": {
+"thumbnail": {
+ "url":
"https://upload.wikimedia.org/wikipedia/commons/d/dd/Muybridge_race_horse_animated.gif";,
+ "width": 300,
+ "height": 200,
+ "landscape": true
+},
+"url":
"https://upload.wikimedia.org/wikipedia/commons/d/dd/Muybridge_race_horse_animated.gif";
+ },
+ "sections": [
+{
+ "index": 0,
+ "level": 0,
+ "fragment": "",
+ "titleHTML": "",
+ "contentHTML": "\n\n\n\n\n\n\n\n\nPOTY\n\n\n\n\n\nThis
is a featured picture on Wikimedia Commons (Featured pictures) and is considered one of the finest images.\n\nWikipedia\n\n\nThis is a featured picture on the Arabic language
Wikipedia (https://en.wikipedia.org/wiki/ar:ويكيبيديا:صور%20مختارة\";
title=\"w:ar:ويكيبيديا:صور مختارة\" class=\"external\">صور مختارة) and is
https://en.wikipedia.org/wiki/ar:ويكيبيديا:ترشيحات_الصور_المختارة/Muybridge%20race%20horse%20animated.gif\";
title=\"w:ar:ويكيبيديا:ترشيحات الصور المختارة/Muybridge race horse
animated.gif\" class=\"external\">considered one of the finest
images.This is a featured picture on the German language
Wikipedia (https://en.wikipedia.org/wiki/de:Wikipedia:Exzellente%20Bilder\";
title=\"w:de:Wikipedia:Exzellente Bilder\" class=\"external\">Exzellente
Bilder) and is https://en.wikipedia.org/wiki/de:Wikipedia:Kandidaten%20für%20exzellente%20Bilder/Muybridge%20race%20horse%20animated.gif\";
title=\"w:de:Wikipedia:Kandidaten für exzellente Bilder/Muybridge race horse
animated.gif\" class=\"external\">considered one of the finest
images.This is a featured picture on the English language
Wikipedia (https://en.wikipedia.org/wiki/en:Wikipedia:Featured%20pictures\";
title=\"w:en:Wikipedia:Featured pictures\" class=\"external\">Featured
pictures) and is https://en.wikipedia.org/wiki/en:Wikipedia:Featured%20picture%20candidates/Muybridge%20galloping%20horse\";
title=\"w:en:Wikipedia:Featured picture candidates/Muybridge galloping horse\"
class=\"external\">considered one of the finest images.This is a featured picture on the Spanish language
Wikipedia (https://en.wikipedia.org/wiki/es:Wikipedia:Recursos%20destacados\";
title=\"w:es:Wikipedia:Recursos destacados\" class=\"external\">Recursos
destacados) and is https:
[MediaWiki-commits] [Gerrit] marvin[master]: Update: show image on image File pages
Niedzielski has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392078 )
Change subject: Update: show image on image File pages
..
Update: show image on image File pages
Add the missing image to File namespace pages.
https://www.mediawiki.org/wiki/Parsoid/Known_differences_with_PHP_parser_output#Differences_because_of_implementation_differences_or_functionality_gaps
Bug: T179829
Bug: T153801
Bug: T148118
Change-Id: I1289296431bc958927bd690eac6afbd442780df5
---
M package.json
A src/common/marshallers/page/file-page-lead-expected.test.json
A src/common/marshallers/page/file-page-lead-restbase.test.json
M src/common/marshallers/page/page-unmarshaller.test.ts
M src/common/marshallers/page/page-unmarshaller.ts
M src/common/marshallers/restbase.ts
M src/common/models/page/page-base.ts
M src/common/models/page/page.ts
A src/common/pages/wiki.css
M src/common/pages/wiki.tsx
10 files changed, 217 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/78/392078/1
diff --git a/package.json b/package.json
index 72e1e48..4272f71 100644
--- a/package.json
+++ b/package.json
@@ -131,7 +131,7 @@
},
{
"path": "dist/public/pages/wiki.*.js",
- "maxSize": "3.3KB"
+ "maxSize": "3.6KB"
}
]
}
diff --git a/src/common/marshallers/page/file-page-lead-expected.test.json
b/src/common/marshallers/page/file-page-lead-expected.test.json
new file mode 100644
index 000..36f0fbc
--- /dev/null
+++ b/src/common/marshallers/page/file-page-lead-expected.test.json
@@ -0,0 +1,59 @@
+
+{
+ "pageID": 1228779,
+ "titleID": "File:Muybridge_race_horse_animated.gif",
+ "titleText": "File:Muybridge race horse animated.gif",
+ "titleHTML": "File:Muybridge race horse animated.gif",
+ "lastModified": "2017-03-22T17:20:33Z",
+ "descriptionText": "",
+ "etag": {
+"revision": 802006980,
+"timeID": "4f754377-a235-11e7-a776-efb84f18649a"
+ },
+ "revision": 238166671,
+ "namespace": 6,
+ "mainPage": false,
+ "disambiguationPage": false,
+ "lastModifier": {
+"anonymous": false,
+"user": "Kaldari",
+"gender": "unknown"
+ },
+ "permissions": {},
+ "editable": true,
+ "languageCount": 0,
+ "thumbnail": [
+{ "url":
"//upload.wikimedia.org/wikipedia/commons/d/dd/Muybridge_race_horse_animated.gif",
"width": 320 },
+{ "url":
"//upload.wikimedia.org/wikipedia/commons/d/dd/Muybridge_race_horse_animated.gif",
"width": 640 },
+{ "url":
"//upload.wikimedia.org/wikipedia/commons/d/dd/Muybridge_race_horse_animated.gif",
"width": 800 },
+{ "url":
"//upload.wikimedia.org/wikipedia/commons/d/dd/Muybridge_race_horse_animated.gif",
"width": 1024 }
+ ],
+ "fileImage": {
+"thumbnail": {
+ "url":
"https://upload.wikimedia.org/wikipedia/commons/d/dd/Muybridge_race_horse_animated.gif";,
+ "width": 300,
+ "height": 200,
+ "landscape": true
+},
+"url":
"https://upload.wikimedia.org/wikipedia/commons/d/dd/Muybridge_race_horse_animated.gif";
+ },
+ "sections": [
+{
+ "index": 0,
+ "level": 0,
+ "fragment": "",
+ "titleHTML": "",
+ "contentHTML": "\n\n\n\n\n\n\n\n\nPOTY\n\n\n\n\n\nThis
is a featured picture on Wikimedia Commons (Featured pictures) and is considered one of the finest images.\n\nWikipedia\n\n\nThis is a featured picture on the Arabic language
Wikipedia (https://en.wikipedia.org/wiki/ar:ويكيبيديا:صور%20مختارة\";
title=\"w:ar:ويكيبيديا:صور مختارة\" class=\"external\">صور مختارة) and is
https://en.wikipedia.org/wiki/ar:ويكيبيديا:ترشيحات_الصور_المختارة/Muybridge%20race%20horse%20animated.gif\";
title=\"w:ar:ويكيبيديا:ترشيحات الصور المختارة/Muybridge race horse
animated.gif\" class=\"external\">considered one of the finest
images.This is a featured picture on the German language
Wikipedia (https://en.wikipedia.org/wiki/de:Wikipedia:Exzellente%20Bilder\";
title=\"w:de:Wikipedia:Exzellente Bilder\" class=\"external\">Exzellente
Bilder) and is https://en.wikipedia.org/wiki/de:Wikipedia:Kandidaten%20für%20exzellente%20Bilder/Muybridge%20race%20horse%20animated.gif\";
title=\"w:de:Wikipedia:Kandidaten für exzellente Bilder/Muybridge race horse
animated.gif\" class=\"external\">considered one of the finest
images.This is a featured picture on the English language
Wikipedia (https://en.wikipedia.org/wiki/en:Wikipedia:Featured%20pictures\";
title=\"w:en:Wikipedia:Featured pictures\" class=\"external\">Featured
pictures) and is https://en.wikipedia.org/wiki/en:Wikipedia:Featured%20picture%20candidates/Muybridge%20galloping%20horse\";
title=\"w:en:Wikipedia:Featured picture candidates/Muybridge galloping horse\"
class=\"external\">considered one of the finest images.This is a featured picture on the Spanish language
Wikipedia (https://en.wikipedia.org/wiki/es:Wikipedia:Recursos%20destacados\";
title=\"w:es:Wikipedia:Recursos destacados\" class=\"external\">Recursos
desta
