[MediaWiki-commits] [Gerrit] mediawiki/core[master]: UploadBase::getTitle can return null

2017-04-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348793 )

Change subject: UploadBase::getTitle can return null
..


UploadBase::getTitle can return null

Change-Id: I5bd94f6233476bda43a01155f6e7d6df420412e2
---
M includes/upload/UploadBase.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/upload/UploadBase.php b/includes/upload/UploadBase.php
index 2c0afdf..55fb685 100644
--- a/includes/upload/UploadBase.php
+++ b/includes/upload/UploadBase.php
@@ -798,7 +798,7 @@
 * Returns the title of the file to be uploaded. Sets mTitleError in 
case
 * the name was illegal.
 *
-* @return Title The title of the file or null in case the name was 
illegal
+* @return Title|null The title of the file or null in case the name 
was illegal
 */
public function getTitle() {
if ( $this->mTitle !== false ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/348793
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5bd94f6233476bda43a01155f6e7d6df420412e2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: UploadBase::getTitle can return null

2017-04-18 Thread Addshore (Code Review) 
Addshore has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348793 )

Change subject: UploadBase::getTitle can return null
..

UploadBase::getTitle can return null

Change-Id: I5bd94f6233476bda43a01155f6e7d6df420412e2
---
M includes/upload/UploadBase.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/93/348793/1

diff --git a/includes/upload/UploadBase.php b/includes/upload/UploadBase.php
index 2c0afdf..55fb685 100644
--- a/includes/upload/UploadBase.php
+++ b/includes/upload/UploadBase.php
@@ -798,7 +798,7 @@
 * Returns the title of the file to be uploaded. Sets mTitleError in 
case
 * the name was illegal.
 *
-* @return Title The title of the file or null in case the name was 
illegal
+* @return Title|null The title of the file or null in case the name 
was illegal
 */
public function getTitle() {
if ( $this->mTitle !== false ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/348793
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bd94f6233476bda43a01155f6e7d6df420412e2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits