[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Align "What's this" vertically

2017-09-06 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/357517 )

Change subject: Align "What's this" vertically
..


Align "What's this" vertically

Bug: T165627
Change-Id: I4da04ec48dfe1ad67379d79083e3f1fff431c8a2
---
M 
resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterMenuSectionOptionWidget.less
1 file changed, 7 insertions(+), 12 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mooeypoo: Looks good to me, approved



diff --git 
a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterMenuSectionOptionWidget.less
 
b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterMenuSectionOptionWidget.less
index 964f27e..23ef2c4 100644
--- 
a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterMenuSectionOptionWidget.less
+++ 
b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterMenuSectionOptionWidget.less
@@ -12,25 +12,20 @@
color: #555a5d;
.box-sizing( border-box );
display: inline-block;
-   line-height: normal;
}
}
 
&-whatsThisButton {
margin-left: 1.5em;
-   &.oo-ui-buttonElement {
-   vertical-align: text-bottom;
 
-   & > .oo-ui-buttonElement-button {
-   font-weight: normal;
-   // Override OOUI's definitions for button
-   border-color: transparent;
-   padding: 0;
+   &.oo-ui-buttonElement > .oo-ui-buttonElement-button {
+   font-weight: normal;
+   border: 0; // Override OOUI `border` needed for 
frameless keyboard focus
+   padding: 0;
 
-   &:focus {
-   box-shadow: none;
-   outline: 0;
-   }
+   &:focus {
+   box-shadow: none;
+   outline: 0;
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/357517
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4da04ec48dfe1ad67379d79083e3f1fff431c8a2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Mooeypoo 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Align "What's this" vertically

2017-06-06 Thread VolkerE (Code Review)
VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/357517 )

Change subject: Align "What's this" vertically
..

Align "What's this" vertically

Bug: T165627
Change-Id: I4da04ec48dfe1ad67379d79083e3f1fff431c8a2
---
M 
resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterMenuSectionOptionWidget.less
1 file changed, 7 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/17/357517/1

diff --git 
a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterMenuSectionOptionWidget.less
 
b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterMenuSectionOptionWidget.less
index 964f27e..23ef2c4 100644
--- 
a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterMenuSectionOptionWidget.less
+++ 
b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterMenuSectionOptionWidget.less
@@ -12,25 +12,20 @@
color: #555a5d;
.box-sizing( border-box );
display: inline-block;
-   line-height: normal;
}
}
 
&-whatsThisButton {
margin-left: 1.5em;
-   &.oo-ui-buttonElement {
-   vertical-align: text-bottom;
 
-   & > .oo-ui-buttonElement-button {
-   font-weight: normal;
-   // Override OOUI's definitions for button
-   border-color: transparent;
-   padding: 0;
+   &.oo-ui-buttonElement > .oo-ui-buttonElement-button {
+   font-weight: normal;
+   border: 0; // Override OOUI `border` needed for 
frameless keyboard focus
+   padding: 0;
 
-   &:focus {
-   box-shadow: none;
-   outline: 0;
-   }
+   &:focus {
+   box-shadow: none;
+   outline: 0;
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/357517
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4da04ec48dfe1ad67379d79083e3f1fff431c8a2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits