[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Deprecate various ResourceLoader modules

2016-08-11 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Deprecate various ResourceLoader modules
..


Deprecate various ResourceLoader modules

Various modules in MediaWiki core replicate functionality elsewhere.
To improve consistency with how we build things and how things appear
in the frontend we need to guide engineers and gadget developers to use
the same libraries. No deprecation dates are given for these modules
but this is hoped to be the starting point for some good conversations
that will guide us to better frontend development

If a module depends on a deprecated module, it itself is not marked
as deprecated

Bug: T142418
Change-Id: Ibbfcfde64072e7d3e3ee5ecb7f966fd889259798
---
M resources/Resources.php
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/Resources.php b/resources/Resources.php
index 1558ee6..d3e58e1 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -333,6 +333,9 @@
'targets' => [ 'desktop', 'mobile' ],
],
'jquery.jStorage' => [
+   'deprecated' => [
+   'message' => 'Please use "mediawiki.storage" instead.',
+   ],
'scripts' => 'resources/lib/jquery/jquery.jStorage.js',
'dependencies' => 'json',
],
@@ -370,6 +373,7 @@
/* jQuery Tipsy */
 
'jquery.tipsy' => [
+   'deprecated' => true,
'scripts' => 'resources/src/jquery.tipsy/jquery.tipsy.js',
'styles' => 'resources/src/jquery.tipsy/jquery.tipsy.css',
],
@@ -377,6 +381,9 @@
/* jQuery UI */
 
'jquery.ui.core' => [
+   'deprecated' => [
+   'message' => 'Please use "mediawiki.ui.button" or 
"oojs-ui" instead.',
+   ],
'scripts' => 'resources/lib/jquery.ui/jquery.ui.core.js',
'dependencies' => [
'jquery.ui.core.styles',
@@ -655,11 +662,13 @@
'group' => 'jquery.ui',
],
'jquery.ui.widget' => [
+   'deprecated' => true,
'scripts' => 'resources/lib/jquery.ui/jquery.ui.widget.js',
'group' => 'jquery.ui',
],
// Effects
'jquery.effects.core' => [
+   'deprecated' => true,
'scripts' => 'resources/lib/jquery.ui/jquery.ui.effect.js',
'group' => 'jquery.ui',
],

-- 
To view, visit https://gerrit.wikimedia.org/r/302732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbfcfde64072e7d3e3ee5ecb7f966fd889259798
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Trevor Parscal 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Deprecate various ResourceLoader modules

2016-08-03 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/302732

Change subject: Deprecate various ResourceLoader modules
..

Deprecate various ResourceLoader modules

Various modules in MediaWiki core replicate functionality elsewhere.
To improve consistency with how we build things and how things appear
in the frontend we need to guide engineers and gadget developers to use
the same libraries. No deprecation dates are given for these modules
but this is hoped to be the starting point for some good conversations
that will guide us to better frontend development

Change-Id: Ibbfcfde64072e7d3e3ee5ecb7f966fd889259798
---
M resources/Resources.php
1 file changed, 37 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/32/302732/1

diff --git a/resources/Resources.php b/resources/Resources.php
index 1558ee6..90384d1 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -370,6 +370,7 @@
/* jQuery Tipsy */
 
'jquery.tipsy' => [
+   'deprecated' => true,
'scripts' => 'resources/src/jquery.tipsy/jquery.tipsy.js',
'styles' => 'resources/src/jquery.tipsy/jquery.tipsy.css',
],
@@ -377,6 +378,7 @@
/* jQuery UI */
 
'jquery.ui.core' => [
+   'deprecated' => true,
'scripts' => 'resources/lib/jquery.ui/jquery.ui.core.js',
'dependencies' => [
'jquery.ui.core.styles',
@@ -394,6 +396,7 @@
'group' => 'jquery.ui',
],
'jquery.ui.accordion' => [
+   'deprecated' => true,
'scripts' => 'resources/lib/jquery.ui/jquery.ui.accordion.js',
'dependencies' => [
'jquery.ui.core',
@@ -405,6 +408,7 @@
'group' => 'jquery.ui',
],
'jquery.ui.autocomplete' => [
+   'deprecated' => true,
'scripts' => 
'resources/lib/jquery.ui/jquery.ui.autocomplete.js',
'dependencies' => [
'jquery.ui.core',
@@ -418,6 +422,9 @@
'group' => 'jquery.ui',
],
'jquery.ui.button' => [
+   'deprecated' => [
+   'message' => 'Please use "mediawiki.ui.button" or 
"oojs-ui" instead.',
+   ],
'scripts' => 'resources/lib/jquery.ui/jquery.ui.button.js',
'dependencies' => [
'jquery.ui.core',
@@ -429,6 +436,7 @@
'group' => 'jquery.ui',
],
'jquery.ui.datepicker' => [
+   'deprecated' => true,
'scripts' => 'resources/lib/jquery.ui/jquery.ui.datepicker.js',
'dependencies' => 'jquery.ui.core',
'skinStyles' => [
@@ -508,6 +516,7 @@
'group' => 'jquery.ui',
],
'jquery.ui.dialog' => [
+   'deprecated' => true,
'scripts' => 'resources/lib/jquery.ui/jquery.ui.dialog.js',
'dependencies' => [
'jquery.ui.core',
@@ -524,6 +533,7 @@
'group' => 'jquery.ui',
],
'jquery.ui.draggable' => [
+   'deprecated' => true,
'scripts' => 'resources/lib/jquery.ui/jquery.ui.draggable.js',
'dependencies' => [
'jquery.ui.core',
@@ -533,6 +543,7 @@
'group' => 'jquery.ui',
],
'jquery.ui.droppable' => [
+   'deprecated' => true,
'scripts' => 'resources/lib/jquery.ui/jquery.ui.droppable.js',
'dependencies' => [
'jquery.ui.core',
@@ -543,6 +554,7 @@
'group' => 'jquery.ui',
],
'jquery.ui.menu' => [
+   'deprecated' => true,
'scripts' => 'resources/lib/jquery.ui/jquery.ui.menu.js',
'dependencies' => [
'jquery.ui.core',
@@ -555,11 +567,13 @@
'group' => 'jquery.ui',
],
'jquery.ui.mouse' => [
+   'deprecated' => true,
'scripts' => 'resources/lib/jquery.ui/jquery.ui.mouse.js',
'dependencies' => 'jquery.ui.widget',
'group' => 'jquery.ui',
],
'jquery.ui.position' => [
+   'deprecated' => true,
'scripts' => 'resources/lib/jquery.ui/jquery.ui.position.js',
'group' => 'jquery.ui',
],
@@ -575,6 +589,7 @@
'group' => 'jquery.ui',
],
'jquery.ui.resizable' => [
+   'deprecated' => true,
'scripts' => 'resources/lib/jquery.ui/jquery.ui.resizable.js',
'dependencies' => [
'jquery.ui.core',
@@ -587,6 +602,7 @@
'group' => 'jquery.ui',
],