[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ESLint ecmaVersion setting is not needed if env is es6

2017-11-28 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/391548 )

Change subject: ESLint ecmaVersion setting is not needed if env is es6
..


ESLint ecmaVersion setting is not needed if env is es6

From ESLint documentation:

"Specifying Environments:
es6 - enable all ECMAScript 6 features except for modules
(this automatically sets the ecmaVersion parser option to 6)."

https://eslint.org/docs/user-guide/configuring#specifying-environments

Bug: T139740
Change-Id: Ie675a8a75c09857003d100d7ff92922deebe753e
---
M tests/selenium/.eslintrc.json
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Phuedx: Looks good to me, approved



diff --git a/tests/selenium/.eslintrc.json b/tests/selenium/.eslintrc.json
index db736b7..85fc310 100644
--- a/tests/selenium/.eslintrc.json
+++ b/tests/selenium/.eslintrc.json
@@ -5,9 +5,6 @@
"mocha": true,
"node": true
},
-   "parserOptions": {
-   "ecmaVersion": 6
-   },
"globals": {
"browser": false
},

-- 
To view, visit https://gerrit.wikimedia.org/r/391548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie675a8a75c09857003d100d7ff92922deebe753e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Phuedx 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ESLint ecmaVersion setting is not needed if env is es6

2017-11-15 Thread Zfilipin (Code Review) 
Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391548 )

Change subject: ESLint ecmaVersion setting is not needed if env is es6
..

ESLint ecmaVersion setting is not needed if env is es6

From ESLint documentation:

"Specifying Environments:
es6 - enable all ECMAScript 6 features except for modules
(this automatically sets the ecmaVersion parser option to 6)."

https://eslint.org/docs/user-guide/configuring#specifying-environments

Bug: T139740
Change-Id: Ie675a8a75c09857003d100d7ff92922deebe753e
---
M tests/selenium/.eslintrc.json
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/48/391548/1

diff --git a/tests/selenium/.eslintrc.json b/tests/selenium/.eslintrc.json
index db736b7..85fc310 100644
--- a/tests/selenium/.eslintrc.json
+++ b/tests/selenium/.eslintrc.json
@@ -5,9 +5,6 @@
"mocha": true,
"node": true
},
-   "parserOptions": {
-   "ecmaVersion": 6
-   },
"globals": {
"browser": false
},

-- 
To view, visit https://gerrit.wikimedia.org/r/391548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie675a8a75c09857003d100d7ff92922deebe753e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits