[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix comment of get/setLinkRenderer in doxygen

2016-08-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix comment of get/setLinkRenderer in doxygen
..


Fix comment of get/setLinkRenderer in doxygen

Doxygen requires the full qualified name of the class in a comment
or in the @aram/@return annotation, otherwise the class isn't linked
in the resulting output[1]. This commit changes the LinkRenderer
annotations in SpecialPage and Parser to \MediaWiki\Linker\LinkRenderer.

[1] 
https://doc.wikimedia.org/mediawiki-core/master/php/classSpecialPage.html#a3560214f63fc2f20c63b4025db5cd81d

Change-Id: I74cedcd764a6053cc5a0c6d2eedbedb72651f57c
---
M includes/parser/Parser.php
M includes/specialpage/SpecialPage.php
2 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php
index f9eea48..206ad00 100644
--- a/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@ -251,7 +251,7 @@
protected $mProfiler;
 
/**
-* @var LinkRenderer
+* @var \MediaWiki\Linker\LinkRenderer
 */
protected $mLinkRenderer;
 
@@ -882,10 +882,10 @@
}
 
/**
-* Get a LinkRenderer instance to make links with
+* Get a \MediaWiki\Linker\LinkRenderer instance to make links with
 *
 * @since 1.28
-* @return LinkRenderer
+* @return \MediaWiki\Linker\LinkRenderer
 */
public function getLinkRenderer() {
if ( !$this->mLinkRenderer ) {
diff --git a/includes/specialpage/SpecialPage.php 
b/includes/specialpage/SpecialPage.php
index 35ecc6e..99b9f33 100644
--- a/includes/specialpage/SpecialPage.php
+++ b/includes/specialpage/SpecialPage.php
@@ -61,7 +61,7 @@
protected $mContext;
 
/**
-* @var LinkRenderer|null
+* @var \MediaWiki\Linker\LinkRenderer|null
 */
private $linkRenderer;
 
@@ -834,7 +834,7 @@
 
/**
 * @since 1.28
-* @return LinkRenderer
+* @return \MediaWiki\Linker\LinkRenderer
 */
protected function getLinkRenderer() {
if ( $this->linkRenderer ) {
@@ -846,7 +846,7 @@
 
/**
 * @since 1.28
-* @param LinkRenderer $linkRenderer
+* @param \MediaWiki\Linker\LinkRenderer $linkRenderer
 */
public function setLinkRenderer( LinkRenderer $linkRenderer ) {
$this->linkRenderer = $linkRenderer;

-- 
To view, visit https://gerrit.wikimedia.org/r/303810
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I74cedcd764a6053cc5a0c6d2eedbedb72651f57c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow 
Gerrit-Reviewer: Cscott 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix comment of get/setLinkRenderer in doxygen

2016-08-09 Thread Florianschmidtwelzow (Code Review) 
Florianschmidtwelzow has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/303810

Change subject: Fix comment of get/setLinkRenderer in doxygen
..

Fix comment of get/setLinkRenderer in doxygen

Doxygen requires the full qualified name of the class in a comment
or in the @aram/@return annotation, otherwise the class isn't linked
in the resulting output[1]. This commit changes the LinkRenderer
annotations in SpecialPage and Parser to \MediaWiki\Linker\LinkRenderer.

[1] 
https://doc.wikimedia.org/mediawiki-core/master/php/classSpecialPage.html#a3560214f63fc2f20c63b4025db5cd81d

Change-Id: I74cedcd764a6053cc5a0c6d2eedbedb72651f57c
---
M includes/parser/Parser.php
M includes/specialpage/SpecialPage.php
2 files changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/10/303810/1

diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php
index f9eea48..206ad00 100644
--- a/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@ -251,7 +251,7 @@
protected $mProfiler;
 
/**
-* @var LinkRenderer
+* @var \MediaWiki\Linker\LinkRenderer
 */
protected $mLinkRenderer;
 
@@ -882,10 +882,10 @@
}
 
/**
-* Get a LinkRenderer instance to make links with
+* Get a \MediaWiki\Linker\LinkRenderer instance to make links with
 *
 * @since 1.28
-* @return LinkRenderer
+* @return \MediaWiki\Linker\LinkRenderer
 */
public function getLinkRenderer() {
if ( !$this->mLinkRenderer ) {
diff --git a/includes/specialpage/SpecialPage.php 
b/includes/specialpage/SpecialPage.php
index 35ecc6e..99b9f33 100644
--- a/includes/specialpage/SpecialPage.php
+++ b/includes/specialpage/SpecialPage.php
@@ -61,7 +61,7 @@
protected $mContext;
 
/**
-* @var LinkRenderer|null
+* @var \MediaWiki\Linker\LinkRenderer|null
 */
private $linkRenderer;
 
@@ -834,7 +834,7 @@
 
/**
 * @since 1.28
-* @return LinkRenderer
+* @return \MediaWiki\Linker\LinkRenderer
 */
protected function getLinkRenderer() {
if ( $this->linkRenderer ) {
@@ -846,7 +846,7 @@
 
/**
 * @since 1.28
-* @param LinkRenderer $linkRenderer
+* @param \MediaWiki\Linker\LinkRenderer $linkRenderer
 */
public function setLinkRenderer( LinkRenderer $linkRenderer ) {
$this->linkRenderer = $linkRenderer;

-- 
To view, visit https://gerrit.wikimedia.org/r/303810
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I74cedcd764a6053cc5a0c6d2eedbedb72651f57c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits