[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Special:Block: Fix FOUC of bold 'mw-block-hideuser'

2017-04-25 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/350284 )

Change subject: Special:Block: Fix FOUC of bold 'mw-block-hideuser'
..


Special:Block: Fix FOUC of bold 'mw-block-hideuser'

Loading Special:Block/ shows "Confirm block", but
this then becomes bold a second later. This is because the styles
are part of 'mediawiki.special.block' which also contains JavaScript
and is loaded with addModules().

Move the styles to mediawiki.special.css instead.

Change-Id: I1c47256227603a6cde36238fdd7e11205d9494ec
---
M resources/Resources.php
D resources/src/mediawiki.special/mediawiki.special.block.css
M resources/src/mediawiki.special/mediawiki.special.css
3 files changed, 8 insertions(+), 12 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, but someone else must approve



diff --git a/resources/Resources.php b/resources/Resources.php
index 715cdb8..ed048bf 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1896,7 +1896,6 @@
],
'mediawiki.special.block' => [
'scripts' => 
'resources/src/mediawiki.special/mediawiki.special.block.js',
-   'styles' => 
'resources/src/mediawiki.special/mediawiki.special.block.css',
'dependencies' => [
'mediawiki.util',
'mediawiki.htmlform',
diff --git a/resources/src/mediawiki.special/mediawiki.special.block.css 
b/resources/src/mediawiki.special/mediawiki.special.block.css
deleted file mode 100644
index ae557b4..000
--- a/resources/src/mediawiki.special/mediawiki.special.block.css
+++ /dev/null
@@ -1,11 +0,0 @@
-/*!
- * Styling for Special:Block
- */
-
-label[for='mw-input-wpConfirm'] {
-   font-weight: bold;
-}
-
-tr.mw-block-hideuser {
-   font-weight: bold;
-}
diff --git a/resources/src/mediawiki.special/mediawiki.special.css 
b/resources/src/mediawiki.special/mediawiki.special.css
index 354ee20..36dfee6 100644
--- a/resources/src/mediawiki.special/mediawiki.special.css
+++ b/resources/src/mediawiki.special/mediawiki.special.css
@@ -35,6 +35,14 @@
text-align: right;
 }
 
+label[for='mw-input-wpConfirm'] {
+   font-weight: bold;
+}
+
+tr.mw-block-hideuser {
+   font-weight: bold;
+}
+
 /* Special:BlockList */
 table.mw-blocklist span.mw-usertoollinks,
 span.mw-blocklist-actions {

-- 
To view, visit https://gerrit.wikimedia.org/r/350284
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c47256227603a6cde36238fdd7e11205d9494ec
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Special:Block: Fix FOUC of bold 'mw-block-hideuser'

2017-04-25 Thread Krinkle (Code Review) 
Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/350284 )

Change subject: Special:Block: Fix FOUC of bold 'mw-block-hideuser'
..

Special:Block: Fix FOUC of bold 'mw-block-hideuser'

Loading Special:Block/ shows "Confirm block", but
this then becomes bold a second later. This is because the styles
are part of 'mediawiki.special.block' which also contains JavaScript
and is loaded with addModules().

Move the styles to mediawiki.special.css instead.

Change-Id: I1c47256227603a6cde36238fdd7e11205d9494ec
---
M resources/Resources.php
D resources/src/mediawiki.special/mediawiki.special.block.css
M resources/src/mediawiki.special/mediawiki.special.css
3 files changed, 9 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/84/350284/1

diff --git a/resources/Resources.php b/resources/Resources.php
index 715cdb8..ed048bf 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1896,7 +1896,6 @@
],
'mediawiki.special.block' => [
'scripts' => 
'resources/src/mediawiki.special/mediawiki.special.block.js',
-   'styles' => 
'resources/src/mediawiki.special/mediawiki.special.block.css',
'dependencies' => [
'mediawiki.util',
'mediawiki.htmlform',
diff --git a/resources/src/mediawiki.special/mediawiki.special.block.css 
b/resources/src/mediawiki.special/mediawiki.special.block.css
deleted file mode 100644
index ae557b4..000
--- a/resources/src/mediawiki.special/mediawiki.special.block.css
+++ /dev/null
@@ -1,11 +0,0 @@
-/*!
- * Styling for Special:Block
- */
-
-label[for='mw-input-wpConfirm'] {
-   font-weight: bold;
-}
-
-tr.mw-block-hideuser {
-   font-weight: bold;
-}
diff --git a/resources/src/mediawiki.special/mediawiki.special.css 
b/resources/src/mediawiki.special/mediawiki.special.css
index 354ee20..ae23e3b 100644
--- a/resources/src/mediawiki.special/mediawiki.special.css
+++ b/resources/src/mediawiki.special/mediawiki.special.css
@@ -35,6 +35,15 @@
text-align: right;
 }
 
+label[for='mw-input-wpConfirm'] {
+   font-weight: bold;
+}
+
+tr.mw-block-hideuser {
+   font-weight: bold;
+}
+
+
 /* Special:BlockList */
 table.mw-blocklist span.mw-usertoollinks,
 span.mw-blocklist-actions {

-- 
To view, visit https://gerrit.wikimedia.org/r/350284
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c47256227603a6cde36238fdd7e11205d9494ec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits