[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Try to avoid bogus JobTest failures for PHP 7

[Aaron Schulz (Code Review)]

Aaron Schulz has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394720 )

Change subject: Try to avoid bogus JobTest failures for PHP 7
..

Try to avoid bogus JobTest failures for PHP 7

Change-Id: I07b4bd796a668fef83ebb3e2824ccc608781a6e8
---
M tests/phpunit/includes/jobqueue/JobTest.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/20/394720/1

diff --git a/tests/phpunit/includes/jobqueue/JobTest.php 
b/tests/phpunit/includes/jobqueue/JobTest.php
index 6723a0b..b57300a 100644
--- a/tests/phpunit/includes/jobqueue/JobTest.php
+++ b/tests/phpunit/includes/jobqueue/JobTest.php
@@ -68,7 +68,7 @@
"masterPos" => [
"file" => "db1023-bin.001288",
"pos" => "308257743",
-   "asOfTime" => 1457521464.3814
+   "asOfTime" => (float)strval( 
1457521464.3814 ) // precision consisteny
],
"triggeredRecursive" => true
] ),

-- 
To view, visit https://gerrit.wikimedia.org/r/394720
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I07b4bd796a668fef83ebb3e2824ccc608781a6e8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Try to avoid bogus JobTest failures for PHP 7

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/394720 )

Change subject: Try to avoid bogus JobTest failures for PHP 7
..


Try to avoid bogus JobTest failures for PHP 7

Change-Id: I07b4bd796a668fef83ebb3e2824ccc608781a6e8
---
M tests/phpunit/includes/jobqueue/JobTest.php
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  Krinkle: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/tests/phpunit/includes/jobqueue/JobTest.php 
b/tests/phpunit/includes/jobqueue/JobTest.php
index 6723a0b..e2aacae 100644
--- a/tests/phpunit/includes/jobqueue/JobTest.php
+++ b/tests/phpunit/includes/jobqueue/JobTest.php
@@ -75,8 +75,10 @@
'someCommand  
pages={"932737":[0,"Robert_James_Waller"]} ' .

'rootJobSignature=45868e99bba89064e4483743ebb9b682ef95c1a7 ' .
'rootJobTimestamp=20160309110158 masterPos=' .
-   
'{"file":"db1023-bin.001288","pos":"308257743","asOfTime":1457521464.3814} ' .
-   'triggeredRecursive=1 ' .
+   
'{"file":"db1023-bin.001288","pos":"308257743","asOfTime":' .
+   // Embed dynamically because TestSetup sets 
serialize_precision=17
+   // which, in PHP 7.1 and 7.2, produces 
1457521464.3814001 instead
+   json_encode( 1457521464.3814 ) . '} ' . 
'triggeredRecursive=1 ' .
$requestId
],
];

-- 
To view, visit https://gerrit.wikimedia.org/r/394720
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07b4bd796a668fef83ebb3e2824ccc608781a6e8
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits