[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Typo in a test: '+' instead of '.' to concatenate strings
Seb35 has uploaded a new change for review. https://gerrit.wikimedia.org/r/308332 Change subject: Typo in a test: '+' instead of '.' to concatenate strings .. Typo in a test: '+' instead of '.' to concatenate strings I found it by executing tests with PHP 7.1.0RC1, but even if PHP 7.1.0 is still a RC, this is a typo in PHP language. Change-Id: Ia97f881f8c80a23c51512189d9ca5a012612c532 --- M tests/phpunit/includes/filerepo/file/FileTest.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/32/308332/1 diff --git a/tests/phpunit/includes/filerepo/file/FileTest.php b/tests/phpunit/includes/filerepo/file/FileTest.php index c5fd369..6520610 100644 --- a/tests/phpunit/includes/filerepo/file/FileTest.php +++ b/tests/phpunit/includes/filerepo/file/FileTest.php @@ -206,7 +206,7 @@ ] ], [ [ 'supportsBucketing' => true, - 'tmpBucketedThumbCache' => [ 1024 => '/tmp/shouldnotexist' + rand() ], + 'tmpBucketedThumbCache' => [ 1024 => '/tmp/shouldnotexist' . rand() ], 'thumbnailBucket' => 1024, 'physicalWidth' => 2048, 'expectedPath' => 'fsFilePath', -- To view, visit https://gerrit.wikimedia.org/r/308332 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia97f881f8c80a23c51512189d9ca5a012612c532 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Seb35 ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Typo in a test: '+' instead of '.' to concatenate strings
jenkins-bot has submitted this change and it was merged. Change subject: Typo in a test: '+' instead of '.' to concatenate strings .. Typo in a test: '+' instead of '.' to concatenate strings I found it by executing tests with PHP 7.1.0RC1, but even if PHP 7.1.0 is still a RC, this is a typo in PHP language. Change-Id: Ia97f881f8c80a23c51512189d9ca5a012612c532 --- M tests/phpunit/includes/filerepo/file/FileTest.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilles: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/phpunit/includes/filerepo/file/FileTest.php b/tests/phpunit/includes/filerepo/file/FileTest.php index c5fd369..6520610 100644 --- a/tests/phpunit/includes/filerepo/file/FileTest.php +++ b/tests/phpunit/includes/filerepo/file/FileTest.php @@ -206,7 +206,7 @@ ] ], [ [ 'supportsBucketing' => true, - 'tmpBucketedThumbCache' => [ 1024 => '/tmp/shouldnotexist' + rand() ], + 'tmpBucketedThumbCache' => [ 1024 => '/tmp/shouldnotexist' . rand() ], 'thumbnailBucket' => 1024, 'physicalWidth' => 2048, 'expectedPath' => 'fsFilePath', -- To view, visit https://gerrit.wikimedia.org/r/308332 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia97f881f8c80a23c51512189d9ca5a012612c532 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Seb35 Gerrit-Reviewer: Gilles Gerrit-Reviewer: Seb35 Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
