[MediaWiki-commits] [Gerrit] mediawiki/core[master]: build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0

2017-08-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372906 )

Change subject: build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0
..


build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0

Change-Id: I06010cd6367c1884b5536e7929d3345feba7f305
---
M package.json
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
5 files changed, 8 insertions(+), 10 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mooeypoo: Looks good to me, approved



diff --git a/package.json b/package.json
index 8507238..96a425f 100644
--- a/package.json
+++ b/package.json
@@ -9,7 +9,7 @@
   "devDependencies": {
 "deepmerge": "1.3.2",
 "eslint": "3.12.2",
-"eslint-config-wikimedia": "0.4.0",
+"eslint-config-wikimedia": "0.5.0",
 "grunt": "1.0.1",
 "grunt-banana-checker": "0.6.0",
 "grunt-contrib-copy": "1.0.0",
diff --git 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
index c066a1f..81c8306 100644
--- 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
+++ 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
@@ -42,7 +42,7 @@
/**
 * Get an object representing the state of this item
 *
-* @returns {Object} Object representing the current data state
+* @return {Object} Object representing the current data state
 *  of the object
 */
mw.rcfilters.dm.SavedQueryItemModel.prototype.getState = function () {
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js 
b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
index c24e6c6..209e7c8 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
@@ -458,11 +458,9 @@
this.filtersModel.toggleInvertedNamespaces();
 
if (
-   this.filtersModel.getFiltersByView( 'namespaces' )
-   .filter( function ( filterItem ) {
-   return filterItem.isSelected();
-   } )
-   .length
+   this.filtersModel.getFiltersByView( 'namespaces' 
).filter(
+   function ( filterItem ) { return 
filterItem.isSelected(); }
+   ).length
) {
// Only re-fetch results if there are namespace items 
that are actually selected
this.updateChangesList();
diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
index 70a2227..bb837e0 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
@@ -125,7 +125,7 @@
 * Respond to input keyup event, this is the way to intercept 'escape' 
key
 *
 * @param {jQuery.Event} e Event data
-* @returns {boolean} false
+* @return {boolean} false
 */
mw.rcfilters.ui.SaveFiltersPopupButtonWidget.prototype.onInputKeyup = 
function ( e ) {
if ( e.which === OO.ui.Keys.ESCAPE ) {
diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
index cac1059..3655c16 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
@@ -212,7 +212,7 @@
 * Respond to input keyup event, this is the way to intercept 'escape' 
key
 *
 * @param {jQuery.Event} e Event data
-* @returns {boolean} false
+* @return {boolean} false
 */
mw.rcfilters.ui.SavedLinksListItemWidget.prototype.onInputKeyup = 
function ( e ) {
if ( e.which === OO.ui.Keys.ESCAPE ) {
@@ -307,7 +307,7 @@
/**
 * Get item ID
 *
-* @returns {string} Query identifier
+* @return {string} Query identifier
 */
mw.rcfilters.ui.SavedLinksListItemWidget.prototype.getID = function () {
return this.model.getID();

-- 
To view, visit https://gerrit.wikimedia.org/r/372906
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0

2017-08-21 Thread Jforrester (Code Review) 
Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372906 )

Change subject: build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0
..

build: Bump eslint-config-wikimedia from 0.4.0 to 0.5.0

Change-Id: I06010cd6367c1884b5536e7929d3345feba7f305
---
M package.json
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
5 files changed, 8 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/06/372906/1

diff --git a/package.json b/package.json
index 8507238..96a425f 100644
--- a/package.json
+++ b/package.json
@@ -9,7 +9,7 @@
   "devDependencies": {
 "deepmerge": "1.3.2",
 "eslint": "3.12.2",
-"eslint-config-wikimedia": "0.4.0",
+"eslint-config-wikimedia": "0.5.0",
 "grunt": "1.0.1",
 "grunt-banana-checker": "0.6.0",
 "grunt-contrib-copy": "1.0.0",
diff --git 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
index c066a1f..81c8306 100644
--- 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
+++ 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
@@ -42,7 +42,7 @@
/**
 * Get an object representing the state of this item
 *
-* @returns {Object} Object representing the current data state
+* @return {Object} Object representing the current data state
 *  of the object
 */
mw.rcfilters.dm.SavedQueryItemModel.prototype.getState = function () {
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js 
b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
index c24e6c6..209e7c8 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
@@ -458,11 +458,9 @@
this.filtersModel.toggleInvertedNamespaces();
 
if (
-   this.filtersModel.getFiltersByView( 'namespaces' )
-   .filter( function ( filterItem ) {
-   return filterItem.isSelected();
-   } )
-   .length
+   this.filtersModel.getFiltersByView( 'namespaces' 
).filter(
+   function ( filterItem ) { return 
filterItem.isSelected(); }
+   ).length
) {
// Only re-fetch results if there are namespace items 
that are actually selected
this.updateChangesList();
diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
index 70a2227..bb837e0 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js
@@ -125,7 +125,7 @@
 * Respond to input keyup event, this is the way to intercept 'escape' 
key
 *
 * @param {jQuery.Event} e Event data
-* @returns {boolean} false
+* @return {boolean} false
 */
mw.rcfilters.ui.SaveFiltersPopupButtonWidget.prototype.onInputKeyup = 
function ( e ) {
if ( e.which === OO.ui.Keys.ESCAPE ) {
diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
index cac1059..3655c16 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
@@ -212,7 +212,7 @@
 * Respond to input keyup event, this is the way to intercept 'escape' 
key
 *
 * @param {jQuery.Event} e Event data
-* @returns {boolean} false
+* @return {boolean} false
 */
mw.rcfilters.ui.SavedLinksListItemWidget.prototype.onInputKeyup = 
function ( e ) {
if ( e.which === OO.ui.Keys.ESCAPE ) {
@@ -307,7 +307,7 @@
/**
 * Get item ID
 *
-* @returns {string} Query identifier
+* @return {string} Query identifier
 */
mw.rcfilters.ui.SavedLinksListItemWidget.prototype.getID = function () {
return this.model.getID();

-- 
To view, visit https://gerrit.wikimedia.org/r/372906
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings