[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Fix : Index naming for the Cargo Tables of multi valued fie...

2017-06-24 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/361275 )

Change subject: Fix : Index naming for the Cargo Tables of  multi valued fields.
..


Fix : Index naming for the Cargo Tables of  multi valued fields.

The index name for the Cargo tables of multi valued fields was being generated 
as 'row_id_$fieldname'.
This patch fixes the issue.

Change-Id: I64cbcf10d515205892f5df398c0761a8870e61b3
---
M CargoUtils.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/CargoUtils.php b/CargoUtils.php
index 50ecac6..1579405 100644
--- a/CargoUtils.php
+++ b/CargoUtils.php
@@ -707,7 +707,7 @@
$createSQL .= ' )';
$cdb->query( $createSQL );
$createIndexSQL = 'CREATE INDEX ' .
-   $cdb->addIdentifierQuotes( 
'row_id_$fieldTableName' ) . ' ON ' .
+   $cdb->addIdentifierQuotes( 
"row_id_$fieldTableName" ) . ' ON ' .
$cdb->tableName( $fieldTableName ) .
' (' . $cdb->addIdentifierQuotes( 
'_rowID' ) . ')';
$cdb->query( $createIndexSQL );

-- 
To view, visit https://gerrit.wikimedia.org/r/361275
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I64cbcf10d515205892f5df398c0761a8870e61b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Fz-29 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Fix : Index naming for the Cargo Tables of multi valued fie...

2017-06-24 Thread Fz-29 (Code Review) 
Fz-29 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/361275 )

Change subject: Fix : Index naming for the Cargo Tables of  multi valued fields.
..

Fix : Index naming for the Cargo Tables of  multi valued fields.

The index name for the Cargo tables of multi valued fields was being generated 
as 'row_id_$fieldname'.
This patch fixes the issue.

Change-Id: I64cbcf10d515205892f5df398c0761a8870e61b3
---
M CargoUtils.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo 
refs/changes/75/361275/1

diff --git a/CargoUtils.php b/CargoUtils.php
index 50ecac6..1579405 100644
--- a/CargoUtils.php
+++ b/CargoUtils.php
@@ -707,7 +707,7 @@
$createSQL .= ' )';
$cdb->query( $createSQL );
$createIndexSQL = 'CREATE INDEX ' .
-   $cdb->addIdentifierQuotes( 
'row_id_$fieldTableName' ) . ' ON ' .
+   $cdb->addIdentifierQuotes( 
"row_id_$fieldTableName" ) . ' ON ' .
$cdb->tableName( $fieldTableName ) .
' (' . $cdb->addIdentifierQuotes( 
'_rowID' ) . ')';
$cdb->query( $createIndexSQL );

-- 
To view, visit https://gerrit.wikimedia.org/r/361275
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I64cbcf10d515205892f5df398c0761a8870e61b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Fz-29 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits