[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Keep counts of login errors by type

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Keep counts of login errors by type
..


Keep counts of login errors by type

For obvious reasons: to catch bugs and estimate their impact.
Use the message key as a proxy for error type.

Change-Id: I927e334f19845d0c49ce5870b3e0ff93b06c687b
---
M includes/specials/SpecialCentralLogin.php
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Ori.livneh: Looks good to me, but someone else must approve
  Alex Monk: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specials/SpecialCentralLogin.php 
b/includes/specials/SpecialCentralLogin.php
index da1d70a..77ae66e 100644
--- a/includes/specials/SpecialCentralLogin.php
+++ b/includes/specials/SpecialCentralLogin.php
@@ -1,5 +1,7 @@
 getStatsdDataFactory();
+   $stats->increment( 'centralauth.centrallogin_errors.' . 
$args[0] );
$this->getOutput()->wrapWikiMsg( '$1', 
$args );
$this->getOutput()->addHtml( '' ); // JS only
}

-- 
To view, visit https://gerrit.wikimedia.org/r/313547
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I927e334f19845d0c49ce5870b3e0ff93b06c687b
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: MZMcBride 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Keep counts of login errors by type

[Ori.livneh (Code Review)]

Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/313547

Change subject: Keep counts of login errors by type
..

Keep counts of login errors by type

For obvious reasons: to catch bugs and estimate their impact.
Use the message key as a proxy for error type.

Change-Id: I927e334f19845d0c49ce5870b3e0ff93b06c687b
---
M includes/specials/SpecialCentralLogin.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/47/313547/1

diff --git a/includes/specials/SpecialCentralLogin.php 
b/includes/specials/SpecialCentralLogin.php
index da1d70a..80e3031 100644
--- a/includes/specials/SpecialCentralLogin.php
+++ b/includes/specials/SpecialCentralLogin.php
@@ -307,6 +307,8 @@
 
protected function showError( /* varargs */ ) {
$args = func_get_args();
+   RequestContext::getMain()->getStats()->increment(
+   'centralauth.login_errors.' . $args[0] );
$this->getOutput()->wrapWikiMsg( '$1', 
$args );
$this->getOutput()->addHtml( '' ); // JS only
}

-- 
To view, visit https://gerrit.wikimedia.org/r/313547
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I927e334f19845d0c49ce5870b3e0ff93b06c687b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits