[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Give early error message in Special:CreateCollaborationHub i...

2017-01-14 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/332117 )

Change subject: Give early error message in Special:CreateCollaborationHub if 
not allowed
..


Give early error message in Special:CreateCollaborationHub if not allowed

This only checks createpage right. Other rights may also come into
play which are checked later.

Change-Id: I90dea96145dc26e9ab122def8b631ab56f17dbe9
---
M includes/SpecialCreateCollaborationHub.php
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Brian Wolff: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/SpecialCreateCollaborationHub.php 
b/includes/SpecialCreateCollaborationHub.php
index fd101ef..ab4fe0f 100644
--- a/includes/SpecialCreateCollaborationHub.php
+++ b/includes/SpecialCreateCollaborationHub.php
@@ -9,8 +9,10 @@
 
 class SpecialCreateCollaborationHub extends FormSpecialPage {
 
-   public function __construct() {
-   parent::__construct( 'CreateCollaborationHub' );
+   public function __construct( $name = 'CreateCollaborationHub', $right = 
'createpage' ) {
+   // Note: The right check is primarily for UI. There are
+   // additional checks later on.
+   parent::__construct( $name, $right );
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/332117
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I90dea96145dc26e9ab122def8b631ab56f17dbe9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CollaborationKit
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff 
Gerrit-Reviewer: Brian Wolff 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Give early error message in Special:CreateCollaborationHub i...

2017-01-14 Thread Brian Wolff (Code Review) 
Brian Wolff has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/332117 )

Change subject: Give early error message in Special:CreateCollaborationHub if 
not allowed
..

Give early error message in Special:CreateCollaborationHub if not allowed

This only checks createpage right. Other rights may also come into
play which are checked later.

Change-Id: I90dea96145dc26e9ab122def8b631ab56f17dbe9
---
M includes/SpecialCreateCollaborationHub.php
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CollaborationKit 
refs/changes/17/332117/1

diff --git a/includes/SpecialCreateCollaborationHub.php 
b/includes/SpecialCreateCollaborationHub.php
index fd101ef..ab4fe0f 100644
--- a/includes/SpecialCreateCollaborationHub.php
+++ b/includes/SpecialCreateCollaborationHub.php
@@ -9,8 +9,10 @@
 
 class SpecialCreateCollaborationHub extends FormSpecialPage {
 
-   public function __construct() {
-   parent::__construct( 'CreateCollaborationHub' );
+   public function __construct( $name = 'CreateCollaborationHub', $right = 
'createpage' ) {
+   // Note: The right check is primarily for UI. There are
+   // additional checks later on.
+   parent::__construct( $name, $right );
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/332117
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I90dea96145dc26e9ab122def8b631ab56f17dbe9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CollaborationKit
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits