[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Fix a couple comments

2017-02-14 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/337687 )

Change subject: Fix a couple comments
..


Fix a couple comments

Change-Id: I946c828f02ab58cb94dba59653a290a8016e460e
---
M gateway_common/DataValidator.php
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Cdentinger: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/gateway_common/DataValidator.php b/gateway_common/DataValidator.php
index 567a357..9427dd3 100644
--- a/gateway_common/DataValidator.php
+++ b/gateway_common/DataValidator.php
@@ -576,7 +576,7 @@
/**
 * Performs a Luhn algorithm check on a string.
 *
-* @param $str
+* @param string $str
 *
 * @return bool True if the number was valid according to the algorithm
 */
@@ -602,7 +602,7 @@
 
/**
 * Calculates and returns the card type for a given credit card number.
-* @param numeric $card_num A credit card number.
+* @param int $card_num A credit card number.
 * @return string|bool 'amex', 'mc', 'visa', 'discover', or false.
 */
public static function getCardType( $card_num ) {
@@ -776,7 +776,7 @@
 * component in there so I'm calling it close enough.
 * @param string $value the value that should be zero-padded out to 
$total_length
 * @param int $total_length The fixed number of characters that $value 
should be padded out to
-* @return The zero-padded value, or false if it was too long to work 
with.
+* @return string The zero-padded value, or false if it was too long to 
work with.
 */
static function getZeroPaddedValue( $value, $total_length ) {
//first, trim all leading zeroes off the value.

-- 
To view, visit https://gerrit.wikimedia.org/r/337687
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I946c828f02ab58cb94dba59653a290a8016e460e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: Cdentinger 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Fix a couple comments

2017-02-14 Thread Ejegg (Code Review) 
Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/337687 )

Change subject: Fix a couple comments
..

Fix a couple comments

Change-Id: I946c828f02ab58cb94dba59653a290a8016e460e
---
M gateway_common/DataValidator.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/87/337687/1

diff --git a/gateway_common/DataValidator.php b/gateway_common/DataValidator.php
index 567a357..9427dd3 100644
--- a/gateway_common/DataValidator.php
+++ b/gateway_common/DataValidator.php
@@ -576,7 +576,7 @@
/**
 * Performs a Luhn algorithm check on a string.
 *
-* @param $str
+* @param string $str
 *
 * @return bool True if the number was valid according to the algorithm
 */
@@ -602,7 +602,7 @@
 
/**
 * Calculates and returns the card type for a given credit card number.
-* @param numeric $card_num A credit card number.
+* @param int $card_num A credit card number.
 * @return string|bool 'amex', 'mc', 'visa', 'discover', or false.
 */
public static function getCardType( $card_num ) {
@@ -776,7 +776,7 @@
 * component in there so I'm calling it close enough.
 * @param string $value the value that should be zero-padded out to 
$total_length
 * @param int $total_length The fixed number of characters that $value 
should be padded out to
-* @return The zero-padded value, or false if it was too long to work 
with.
+* @return string The zero-padded value, or false if it was too long to 
work with.
 */
static function getZeroPaddedValue( $value, $total_length ) {
//first, trim all leading zeroes off the value.

-- 
To view, visit https://gerrit.wikimedia.org/r/337687
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I946c828f02ab58cb94dba59653a290a8016e460e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits