[MediaWiki-commits] [Gerrit] mediawiki...Echo[wmf/1.29.0-wmf.18]: Stop badge hacks from messing up the entire page on IE 11 on...

2017-03-31 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/345874 )

Change subject: Stop badge hacks from messing up the entire page on IE 11 on 
MonoBook
..


Stop badge hacks from messing up the entire page on IE 11 on MonoBook

Looks like we're hitting an edge case where positioning with negative
offsets inside an inline-block element results in incorrect rendering.
We're accidentally rendering an invisible overlay over nearly the
entire page. Twiddle the styles until we no longer hit that case.

Minimal example of the IE 11 bug: https://jsfiddle.net/50v6m0kb/3/

Bug: T161869
Change-Id: Id4b6ccc1ec6a11b455d6ab45c5aaa0e8544385f7
---
M modules/nojs/mw.echo.badge.monobook.less
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Reedy: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/nojs/mw.echo.badge.monobook.less 
b/modules/nojs/mw.echo.badge.monobook.less
index aa88898..576d490 100644
--- a/modules/nojs/mw.echo.badge.monobook.less
+++ b/modules/nojs/mw.echo.badge.monobook.less
@@ -4,6 +4,7 @@
 .mw-echo-notifications-badge {
#pt-notifications-notice &,
#pt-notifications-alert & {
+   display: inline-block;
width: 16px;
height: 16px;
top: -@badge-offscreen-offset - 1px;
@@ -31,6 +32,5 @@
 
 #p-personal #pt-notifications-alert,
 #p-personal #pt-notifications-notice {
-   display: inline-block;
margin-right: 0.2em;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/345874
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4b6ccc1ec6a11b455d6ab45c5aaa0e8544385f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: wmf/1.29.0-wmf.18
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[wmf/1.29.0-wmf.18]: Stop badge hacks from messing up the entire page on IE 11 on...

2017-03-31 Thread Reedy (Code Review) 
Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/345874 )

Change subject: Stop badge hacks from messing up the entire page on IE 11 on 
MonoBook
..

Stop badge hacks from messing up the entire page on IE 11 on MonoBook

Looks like we're hitting an edge case where positioning with negative
offsets inside an inline-block element results in incorrect rendering.
We're accidentally rendering an invisible overlay over nearly the
entire page. Twiddle the styles until we no longer hit that case.

Minimal example of the IE 11 bug: https://jsfiddle.net/50v6m0kb/3/

Bug: T161869
Change-Id: Id4b6ccc1ec6a11b455d6ab45c5aaa0e8544385f7
---
M modules/nojs/mw.echo.badge.monobook.less
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/74/345874/1

diff --git a/modules/nojs/mw.echo.badge.monobook.less 
b/modules/nojs/mw.echo.badge.monobook.less
index aa88898..576d490 100644
--- a/modules/nojs/mw.echo.badge.monobook.less
+++ b/modules/nojs/mw.echo.badge.monobook.less
@@ -4,6 +4,7 @@
 .mw-echo-notifications-badge {
#pt-notifications-notice &,
#pt-notifications-alert & {
+   display: inline-block;
width: 16px;
height: 16px;
top: -@badge-offscreen-offset - 1px;
@@ -31,6 +32,5 @@
 
 #p-personal #pt-notifications-alert,
 #p-personal #pt-notifications-notice {
-   display: inline-block;
margin-right: 0.2em;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/345874
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4b6ccc1ec6a11b455d6ab45c5aaa0e8544385f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: wmf/1.29.0-wmf.18
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits