[MediaWiki-commits] [Gerrit] mediawiki...EducationProgram[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1

2017-07-26 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367993 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
..


build: Updating mediawiki/mediawiki-codesniffer to 0.10.1

Change-Id: Ibc12768d9f9cd173b91089bd3bea850db98ba494
---
M EducationProgram.hooks.php
M composer.json
M includes/ArticleAdder.php
M includes/ArticleStore.php
M includes/CourseUndeletionHelper.php
M includes/Events/Event.php
M includes/Events/EventStore.php
M includes/OrgDeletionHelper.php
M includes/RevisionAction.php
M includes/RevisionDiff.php
M includes/RoleObject.php
M includes/UserRolesMessage.php
M includes/Utils.php
M includes/actions/DeleteAction.php
M includes/actions/DeleteOrgAction.php
M includes/actions/EditAction.php
M includes/actions/RestoreAction.php
M includes/actions/UndeleteAction.php
M includes/actions/UndoAction.php
M includes/actions/ViewAction.php
M includes/api/ApiDeleteEducation.php
M includes/api/ApiEnlist.php
M includes/notifications/CampusAddNotification.php
M includes/notifications/CourseTalkNotification.php
M includes/notifications/InstructorAddNotification.php
M includes/notifications/NotificationsManager.php
M includes/notifications/OnlineAddNotification.php
M includes/notifications/StudentAddNotification.php
M includes/pagers/EPPager.php
M includes/rows/Course.php
M includes/rows/EPArticle.php
M includes/rows/EPRevision.php
M includes/rows/Org.php
M includes/rows/PageObject.php
M includes/rows/RevisionedObject.php
M includes/specials/SpecialAmbassadorProfile.php
M includes/specials/SpecialEducationProgram.php
M includes/specials/SpecialEnroll.php
M includes/specials/VerySpecialPage.php
M includes/tables/Orgs.php
M includes/tables/PageTable.php
M phpcs.xml
42 files changed, 74 insertions(+), 75 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/EducationProgram.hooks.php b/EducationProgram.hooks.php
index ae98a26..3d2ea69 100755
--- a/EducationProgram.hooks.php
+++ b/EducationProgram.hooks.php
@@ -405,7 +405,7 @@
 * @param string $error
 * @param string $reason
 *
-* @return boolean
+* @return bool
 */
public static function onAbortMove(
Title $oldTitle, Title $newTitle, User $user, &$error, $reason
diff --git a/composer.json b/composer.json
index 579fe1f..91c6304 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.0",
+   "mediawiki/mediawiki-codesniffer": "0.10.1",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/ArticleAdder.php b/includes/ArticleAdder.php
index 52edb51..8c569a5 100644
--- a/includes/ArticleAdder.php
+++ b/includes/ArticleAdder.php
@@ -59,7 +59,7 @@
 * @param string $pageTitle
 * @param int[] $reviewers Ids of the users that are reviewers for this 
article
 *
-* @return boolean Indicates if the article was actually added. False 
means it already existed.
+* @return bool Indicates if the article was actually added. False 
means it already existed.
 */
public function addArticle(
$actionUser, $courseId, $userId, $pageId, $pageTitle, 
$reviewers = []
diff --git a/includes/ArticleStore.php b/includes/ArticleStore.php
index 4d0c526..3eb1312 100644
--- a/includes/ArticleStore.php
+++ b/includes/ArticleStore.php
@@ -63,7 +63,7 @@
 *
 * @param int|null $articleId
 *
-* @return boolean
+* @return bool
 */
public function hasArticle( $articleId ) {
if ( is_null( $articleId ) ) {
@@ -135,7 +135,7 @@
 *
 * @param EPArticle $article
 *
-* @return boolean
+* @return bool
 * @throws InvalidArgumentException
 */
public function updateArticle( EPArticle $article ) {
@@ -237,7 +237,7 @@
 *
 * @param int $articleId
 *
-* @return boolean Success indicator
+* @return bool Success indicator
 */
public function deleteArticle( $articleId ) {
return $this->getWriteConnection()->delete(
@@ -258,7 +258,7 @@
 * @param int $userId
 * @param int $pageId
 *
-* @return boolean
+* @return bool
 */
public function hasArticleWith( $courseId, $userId, $pageId ) {
return $this->getReadConnection()->selectRow(
@@ -281,7 +281,7 @@
 * @param int[]|int $courseIds
 * @param int[]|int $userIds
 *
-* @return boolean
+* @return bool
 * @throws InvalidArgumentException
 */
public function deleteArticleByCourseAndUsers( $courseIds,

[MediaWiki-commits] [Gerrit] mediawiki...EducationProgram[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1

2017-07-26 Thread Umherirrender (Code Review) 
Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367993 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
..

build: Updating mediawiki/mediawiki-codesniffer to 0.10.1

Change-Id: Ibc12768d9f9cd173b91089bd3bea850db98ba494
---
M EducationProgram.hooks.php
M composer.json
M includes/ArticleAdder.php
M includes/ArticleStore.php
M includes/CourseUndeletionHelper.php
M includes/Events/Event.php
M includes/Events/EventStore.php
M includes/OrgDeletionHelper.php
M includes/RevisionAction.php
M includes/RevisionDiff.php
M includes/RoleObject.php
M includes/UserRolesMessage.php
M includes/Utils.php
M includes/actions/DeleteAction.php
M includes/actions/DeleteOrgAction.php
M includes/actions/EditAction.php
M includes/actions/RestoreAction.php
M includes/actions/UndeleteAction.php
M includes/actions/UndoAction.php
M includes/actions/ViewAction.php
M includes/api/ApiDeleteEducation.php
M includes/api/ApiEnlist.php
M includes/notifications/CampusAddNotification.php
M includes/notifications/CourseTalkNotification.php
M includes/notifications/InstructorAddNotification.php
M includes/notifications/NotificationsManager.php
M includes/notifications/OnlineAddNotification.php
M includes/notifications/StudentAddNotification.php
M includes/pagers/EPPager.php
M includes/rows/Course.php
M includes/rows/EPArticle.php
M includes/rows/EPRevision.php
M includes/rows/Org.php
M includes/rows/PageObject.php
M includes/rows/RevisionedObject.php
M includes/specials/SpecialAmbassadorProfile.php
M includes/specials/SpecialEducationProgram.php
M includes/specials/SpecialEnroll.php
M includes/specials/VerySpecialPage.php
M includes/tables/Orgs.php
M includes/tables/PageTable.php
M phpcs.xml
42 files changed, 74 insertions(+), 75 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EducationProgram 
refs/changes/93/367993/1

diff --git a/EducationProgram.hooks.php b/EducationProgram.hooks.php
index ae98a26..3d2ea69 100755
--- a/EducationProgram.hooks.php
+++ b/EducationProgram.hooks.php
@@ -405,7 +405,7 @@
 * @param string $error
 * @param string $reason
 *
-* @return boolean
+* @return bool
 */
public static function onAbortMove(
Title $oldTitle, Title $newTitle, User $user, &$error, $reason
diff --git a/composer.json b/composer.json
index 579fe1f..91c6304 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.0",
+   "mediawiki/mediawiki-codesniffer": "0.10.1",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/ArticleAdder.php b/includes/ArticleAdder.php
index 52edb51..8c569a5 100644
--- a/includes/ArticleAdder.php
+++ b/includes/ArticleAdder.php
@@ -59,7 +59,7 @@
 * @param string $pageTitle
 * @param int[] $reviewers Ids of the users that are reviewers for this 
article
 *
-* @return boolean Indicates if the article was actually added. False 
means it already existed.
+* @return bool Indicates if the article was actually added. False 
means it already existed.
 */
public function addArticle(
$actionUser, $courseId, $userId, $pageId, $pageTitle, 
$reviewers = []
diff --git a/includes/ArticleStore.php b/includes/ArticleStore.php
index 4d0c526..3eb1312 100644
--- a/includes/ArticleStore.php
+++ b/includes/ArticleStore.php
@@ -63,7 +63,7 @@
 *
 * @param int|null $articleId
 *
-* @return boolean
+* @return bool
 */
public function hasArticle( $articleId ) {
if ( is_null( $articleId ) ) {
@@ -135,7 +135,7 @@
 *
 * @param EPArticle $article
 *
-* @return boolean
+* @return bool
 * @throws InvalidArgumentException
 */
public function updateArticle( EPArticle $article ) {
@@ -237,7 +237,7 @@
 *
 * @param int $articleId
 *
-* @return boolean Success indicator
+* @return bool Success indicator
 */
public function deleteArticle( $articleId ) {
return $this->getWriteConnection()->delete(
@@ -258,7 +258,7 @@
 * @param int $userId
 * @param int $pageId
 *
-* @return boolean
+* @return bool
 */
public function hasArticleWith( $courseId, $userId, $pageId ) {
return $this->getReadConnection()->selectRow(
@@ -281,7 +281,7 @@
 * @param int[]|int $courseIds
 * @param int[]|int $userIds
 *
-* @return boolean
+* @return bool
 * @throws InvalidArgumentException
 */
public function