[MediaWiki-commits] [Gerrit] mediawiki...FeaturedFeeds[master]: Use ParserOutput stateless transforms when available

2017-11-30 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393266 )

Change subject: Use ParserOutput stateless transforms when available
..


Use ParserOutput stateless transforms when available

See MediaWiki core changes Ied5fe1a61 and I78b62ec3.

There's no need to feature-flag the extra parameter in calls to
ParserOutput::getText(), they'll just be ignored if this is merged
first.

Change-Id: I432da8c0686c279b3c2e770f7f9e20248589d6db
---
M FeaturedFeeds.body.php
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/FeaturedFeeds.body.php b/FeaturedFeeds.body.php
index f572aec..bb1d20f 100644
--- a/FeaturedFeeds.body.php
+++ b/FeaturedFeeds.body.php
@@ -310,7 +310,9 @@
private static function staticInit() {
if ( !self::$parserOptions ) {
self::$parserOptions = new ParserOptions();
-   self::$parserOptions->setEditSection( false );
+   if ( !defined( 
'ParserOutput::SUPPORTS_STATELESS_TRANSFORMS' ) ) {
+   self::$parserOptions->setEditSection( false );
+   }
self::$parser = new Parser();
}
}
@@ -427,7 +429,9 @@
if ( !$text ) {
return false;
}
-   $text = self::$parser->parse( $text, $title, 
self::$parserOptions )->getText();
+   $text = self::$parser->parse( $text, $title, 
self::$parserOptions )->getText( [
+   'enableSectionEditLinks' => false,
+   ] );
$ts = new MWTimestamp( $date );
$url = SpecialPage::getTitleFor( 'FeedItem',
$this->name . '/' . $ts->getTimestamp( TS_MW ) . '/' . 
$this->languageCode

-- 
To view, visit https://gerrit.wikimedia.org/r/393266
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I432da8c0686c279b3c2e770f7f9e20248589d6db
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/FeaturedFeeds
Gerrit-Branch: master
Gerrit-Owner: Anomie 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...FeaturedFeeds[master]: Use ParserOutput stateless transforms when available

2017-11-24 Thread Anomie (Code Review)
Anomie has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393266 )

Change subject: Use ParserOutput stateless transforms when available
..

Use ParserOutput stateless transforms when available

See MediaWiki core changes Ied5fe1a61 and I78b62ec3.

There's no need to feature-flag the extra parameter in calls to
ParserOutput::getText(), they'll just be ignored if this is merged
first.

Change-Id: I432da8c0686c279b3c2e770f7f9e20248589d6db
---
M FeaturedFeeds.body.php
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FeaturedFeeds 
refs/changes/66/393266/1

diff --git a/FeaturedFeeds.body.php b/FeaturedFeeds.body.php
index f572aec..63d4fde 100644
--- a/FeaturedFeeds.body.php
+++ b/FeaturedFeeds.body.php
@@ -310,7 +310,9 @@
private static function staticInit() {
if ( !self::$parserOptions ) {
self::$parserOptions = new ParserOptions();
-   self::$parserOptions->setEditSection( false );
+   if ( !defined( 
ParserOutput::SUPPORTS_STATELESS_TRANSFORMS ) ) {
+   self::$parserOptions->setEditSection( false );
+   }
self::$parser = new Parser();
}
}
@@ -427,7 +429,9 @@
if ( !$text ) {
return false;
}
-   $text = self::$parser->parse( $text, $title, 
self::$parserOptions )->getText();
+   $text = self::$parser->parse( $text, $title, 
self::$parserOptions )->getText( [
+   'enableSectionEditLinks' => false,
+   ] );
$ts = new MWTimestamp( $date );
$url = SpecialPage::getTitleFor( 'FeedItem',
$this->name . '/' . $ts->getTimestamp( TS_MW ) . '/' . 
$this->languageCode

-- 
To view, visit https://gerrit.wikimedia.org/r/393266
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I432da8c0686c279b3c2e770f7f9e20248589d6db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FeaturedFeeds
Gerrit-Branch: master
Gerrit-Owner: Anomie 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits