[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: FlaggablePageView#changeSaveButton: Address i18n FIXME, use ...

2017-04-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/346934 )

Change subject: FlaggablePageView#changeSaveButton: Address i18n FIXME, use the 
brackets message
..


FlaggablePageView#changeSaveButton: Address i18n FIXME, use the brackets message

Change-Id: Ia79fb800696bcfde72ae6a56e1004b6f31a085aa
---
M frontend/FlaggablePageView.php
1 file changed, 7 insertions(+), 5 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php
index fa98347..c0bf6f9 100644
--- a/frontend/FlaggablePageView.php
+++ b/frontend/FlaggablePageView.php
@@ -1800,11 +1800,13 @@
$dom = new DOMDocument();
$dom->loadXML( $buttons['save'] ); // load button XML 
from hook
foreach ( $dom->getElementsByTagName( 'input' ) as 
$input ) { // one 
-   $input->setAttribute( 'value', $this->msg( 
'revreview-submitedit' )->text() );
-   // @todo i18n FIXME: Hard coded brackets.
-   $input->setAttribute( 'title', // keep accesskey
-   $this->msg( 
'revreview-submitedit-title' )->text() .
-   ' [' . $this->msg( 
'accesskey-save' )->text() . ']' );
+   $buttonLabel = $this->msg( 
'revreview-submitedit' )->text();
+   $input->setAttribute( 'value', $buttonLabel );
+   // This attempts to re-implement 
Linker::titleAttrib(); TODO, consider a re-use pattern
+   $buttonTitle = $this->msg( 
'revreview-submitedit-title' )->text() . ' ' .
+   $this->msg( 'brackets', $this->msg( 
'accesskey-save' )->text() )->text();
+   $input->setAttribute( 'title', $buttonTitle ); 
// keep accesskey
+
# Change submit button text & title
$buttons['save'] = $dom->saveXML( 
$dom->documentElement );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/346934
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia79fb800696bcfde72ae6a56e1004b6f31a085aa
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: FlaggablePageView#changeSaveButton: Address i18n FIXME, use ...

2017-04-06 Thread Jforrester (Code Review) 
Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/346934 )

Change subject: FlaggablePageView#changeSaveButton: Address i18n FIXME, use the 
brackets message
..

FlaggablePageView#changeSaveButton: Address i18n FIXME, use the brackets message

Change-Id: Ia79fb800696bcfde72ae6a56e1004b6f31a085aa
---
M frontend/FlaggablePageView.php
1 file changed, 7 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs 
refs/changes/34/346934/1

diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php
index fa98347..64cbeae 100644
--- a/frontend/FlaggablePageView.php
+++ b/frontend/FlaggablePageView.php
@@ -1800,11 +1800,13 @@
$dom = new DOMDocument();
$dom->loadXML( $buttons['save'] ); // load button XML 
from hook
foreach ( $dom->getElementsByTagName( 'input' ) as 
$input ) { // one 
-   $input->setAttribute( 'value', $this->msg( 
'revreview-submitedit' )->text() );
-   // @todo i18n FIXME: Hard coded brackets.
-   $input->setAttribute( 'title', // keep accesskey
-   $this->msg( 
'revreview-submitedit-title' )->text() .
-   ' [' . $this->msg( 
'accesskey-save' )->text() . ']' );
+   $buttonLabel = $this->msg( 
'revreview-submitedit' )->text();
+   $input->setAttribute( 'value', $buttonLabel );
+
+   $buttonTitle = $this->msg( 
'revreview-submitedit-title' )->text() .
+   $this->msg( 'brackets', $this->msg( 
'accesskey-save' )->text() )->text();
+   $input->setAttribute( 'title', $buttonTitle ); 
// keep accesskey
+
# Change submit button text & title
$buttons['save'] = $dom->saveXML( 
$dom->documentElement );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/346934
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia79fb800696bcfde72ae6a56e1004b6f31a085aa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits