[MediaWiki-commits] [Gerrit] mediawiki...GlobalUserPage[master]: Use MediaWikiServices to get DBLoadBalancerFactory instead o...

2017-09-24 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/378640 )

Change subject: Use MediaWikiServices to get DBLoadBalancerFactory instead of 
wfGetLB
..


Use MediaWikiServices to get DBLoadBalancerFactory instead of wfGetLB

wfGetLB has been deprecated since 1.27.

Change-Id: I8ef50e410520c2f08252c17e067d1b88146460d1
---
M GlobalUserPage.body.php
M extension.json
2 files changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Jack Phoenix: Looks good to me, but someone else must approve
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/GlobalUserPage.body.php b/GlobalUserPage.body.php
index 18778b0..c491342 100644
--- a/GlobalUserPage.body.php
+++ b/GlobalUserPage.body.php
@@ -1,5 +1,7 @@
 getConnectionRef( DB_REPLICA, [], 
$wgGlobalUserPageDBname );
+   $factory = 
MediaWikiServices::getInstance()->getDBLoadBalancerFactory();
+   $mainLB = $factory->getMainLB( $wgGlobalUserPageDBname );
+
+   $dbr = $mainLB->getConnectionRef( DB_REPLICA, [], 
$wgGlobalUserPageDBname );
$row = $dbr->selectRow(
[ 'page', 'page_props' ],
[ 'page_touched', 'pp_propname' ],
diff --git a/extension.json b/extension.json
index 8e55626..627f8ac 100644
--- a/extension.json
+++ b/extension.json
@@ -1,6 +1,6 @@
 {
"name": "GlobalUserPage",
-   "version": "0.11.0",
+   "version": "0.11.1",
"author": [
"Kunal Mehta",
"Jack Phoenix"

-- 
To view, visit https://gerrit.wikimedia.org/r/378640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8ef50e410520c2f08252c17e067d1b88146460d1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalUserPage
Gerrit-Branch: master
Gerrit-Owner: SamanthaNguyen 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GlobalUserPage[master]: Use MediaWikiServices to get DBLoadBalancerFactory instead o...

2017-09-17 Thread SamanthaNguyen (Code Review) 
SamanthaNguyen has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/378640 )

Change subject: Use MediaWikiServices to get DBLoadBalancerFactory instead of 
wfGetLB
..

Use MediaWikiServices to get DBLoadBalancerFactory instead of wfGetLB

wfGetLB has been deprecated since 1.27.

Change-Id: I8ef50e410520c2f08252c17e067d1b88146460d1
---
M GlobalUserPage.body.php
M extension.json
2 files changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GlobalUserPage 
refs/changes/40/378640/1

diff --git a/GlobalUserPage.body.php b/GlobalUserPage.body.php
index 18778b0..c491342 100644
--- a/GlobalUserPage.body.php
+++ b/GlobalUserPage.body.php
@@ -1,5 +1,7 @@
 getConnectionRef( DB_REPLICA, [], 
$wgGlobalUserPageDBname );
+   $factory = 
MediaWikiServices::getInstance()->getDBLoadBalancerFactory();
+   $mainLB = $factory->getMainLB( $wgGlobalUserPageDBname );
+
+   $dbr = $mainLB->getConnectionRef( DB_REPLICA, [], 
$wgGlobalUserPageDBname );
$row = $dbr->selectRow(
[ 'page', 'page_props' ],
[ 'page_touched', 'pp_propname' ],
diff --git a/extension.json b/extension.json
index 8e55626..627f8ac 100644
--- a/extension.json
+++ b/extension.json
@@ -1,6 +1,6 @@
 {
"name": "GlobalUserPage",
-   "version": "0.11.0",
+   "version": "0.11.1",
"author": [
"Kunal Mehta",
"Jack Phoenix"

-- 
To view, visit https://gerrit.wikimedia.org/r/378640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ef50e410520c2f08252c17e067d1b88146460d1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalUserPage
Gerrit-Branch: master
Gerrit-Owner: SamanthaNguyen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits