[MediaWiki-commits] [Gerrit] mediawiki...GoogleLogin[master]: build: Bump mediawiki-codesniffer to 0.10.1

2017-07-31 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/368965 )

Change subject: build: Bump mediawiki-codesniffer to 0.10.1
..


build: Bump mediawiki-codesniffer to 0.10.1

Change-Id: I74a8ff7a7287cc4e15689da74630eba5c9d86707
---
M composer.json
M includes/GoogleLogin.body.php
M includes/GoogleLogin.hooks.php
M includes/specials/SpecialManageGoogleLogin.php
4 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index cca0acc..efd81f3 100644
--- a/composer.json
+++ b/composer.json
@@ -7,7 +7,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.0",
+   "mediawiki/mediawiki-codesniffer": "0.10.1",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/GoogleLogin.body.php b/includes/GoogleLogin.body.php
index 81edee3..7c54b9a 100755
--- a/includes/GoogleLogin.body.php
+++ b/includes/GoogleLogin.body.php
@@ -51,7 +51,7 @@
/**
 * If restriction of domains is enabled, check if the user E-Mail is 
valid before do anything.
 * @param string $mailDomain The domain of email address
-* @return boolean
+* @return bool
 */
public static function isValidDomain( $mailDomain ) {
$glConfig = self::getGLConfig();
diff --git a/includes/GoogleLogin.hooks.php b/includes/GoogleLogin.hooks.php
index 476b72a..8e06aba 100644
--- a/includes/GoogleLogin.hooks.php
+++ b/includes/GoogleLogin.hooks.php
@@ -152,7 +152,7 @@
 *
 * @param \EchoEvent $event The triggering event
 * @param String &$bundleString The message of the bundle
-* @return boolean
+* @return bool
 */
public static function onEchoGetBundleRules( \EchoEvent $event, 
&$bundleString ) {
if (
diff --git a/includes/specials/SpecialManageGoogleLogin.php 
b/includes/specials/SpecialManageGoogleLogin.php
index 39fdd54..667573a 100644
--- a/includes/specials/SpecialManageGoogleLogin.php
+++ b/includes/specials/SpecialManageGoogleLogin.php
@@ -77,7 +77,7 @@
 * Checks, if a user with the entered username exists.
 *
 * @param array $data Formdata
-* @return boolean
+* @return bool
 */
public function submitUserName( array $data ) {
$this->submitForm( $data, false );
@@ -156,7 +156,7 @@
 *
 * @param array $data Formdata
 * @param boolean $checkSession If true, checks, if the form was 
submitted by the user itself
-* @return boolean
+* @return bool
 */
public function submitForm( array $data, $checkSession = true ) {
$user = $this->getUser();

-- 
To view, visit https://gerrit.wikimedia.org/r/368965
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I74a8ff7a7287cc4e15689da74630eba5c9d86707
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GoogleLogin
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GoogleLogin[master]: build: Bump mediawiki-codesniffer to 0.10.1

2017-07-31 Thread Jforrester (Code Review) 
Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368965 )

Change subject: build: Bump mediawiki-codesniffer to 0.10.1
..

build: Bump mediawiki-codesniffer to 0.10.1

Change-Id: I74a8ff7a7287cc4e15689da74630eba5c9d86707
---
M composer.json
M includes/GoogleLogin.body.php
M includes/GoogleLogin.hooks.php
M includes/specials/SpecialManageGoogleLogin.php
4 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GoogleLogin 
refs/changes/65/368965/1

diff --git a/composer.json b/composer.json
index cca0acc..efd81f3 100644
--- a/composer.json
+++ b/composer.json
@@ -7,7 +7,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.0",
+   "mediawiki/mediawiki-codesniffer": "0.10.1",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/GoogleLogin.body.php b/includes/GoogleLogin.body.php
index 81edee3..7c54b9a 100755
--- a/includes/GoogleLogin.body.php
+++ b/includes/GoogleLogin.body.php
@@ -51,7 +51,7 @@
/**
 * If restriction of domains is enabled, check if the user E-Mail is 
valid before do anything.
 * @param string $mailDomain The domain of email address
-* @return boolean
+* @return bool
 */
public static function isValidDomain( $mailDomain ) {
$glConfig = self::getGLConfig();
diff --git a/includes/GoogleLogin.hooks.php b/includes/GoogleLogin.hooks.php
index 476b72a..8e06aba 100644
--- a/includes/GoogleLogin.hooks.php
+++ b/includes/GoogleLogin.hooks.php
@@ -152,7 +152,7 @@
 *
 * @param \EchoEvent $event The triggering event
 * @param String &$bundleString The message of the bundle
-* @return boolean
+* @return bool
 */
public static function onEchoGetBundleRules( \EchoEvent $event, 
&$bundleString ) {
if (
diff --git a/includes/specials/SpecialManageGoogleLogin.php 
b/includes/specials/SpecialManageGoogleLogin.php
index 39fdd54..667573a 100644
--- a/includes/specials/SpecialManageGoogleLogin.php
+++ b/includes/specials/SpecialManageGoogleLogin.php
@@ -77,7 +77,7 @@
 * Checks, if a user with the entered username exists.
 *
 * @param array $data Formdata
-* @return boolean
+* @return bool
 */
public function submitUserName( array $data ) {
$this->submitForm( $data, false );
@@ -156,7 +156,7 @@
 *
 * @param array $data Formdata
 * @param boolean $checkSession If true, checks, if the form was 
submitted by the user itself
-* @return boolean
+* @return bool
 */
public function submitForm( array $data, $checkSession = true ) {
$user = $this->getUser();

-- 
To view, visit https://gerrit.wikimedia.org/r/368965
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I74a8ff7a7287cc4e15689da74630eba5c9d86707
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GoogleLogin
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits