[MediaWiki-commits] [Gerrit] mediawiki...ImageTweaks[master]: Fix extension ImageTweaks failing tests
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/332038 )
Change subject: Fix extension ImageTweaks failing tests
..
Fix extension ImageTweaks failing tests
Extension ImageTweaks failing tests due to missing apihelp messages
Bug: T155049
Change-Id: I30c45582f499a67bf83c896427ab9bcd53367f6d
---
M ApiImageTweaks.php
M i18n/en.json
M i18n/qqq.json
3 files changed, 16 insertions(+), 11 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/ApiImageTweaks.php b/ApiImageTweaks.php
index 7fc9727..e3eb1aa 100644
--- a/ApiImageTweaks.php
+++ b/ApiImageTweaks.php
@@ -108,13 +108,4 @@
),
);
}
-
- public function getDescription() {
- return 'Create a derivative image based on an image already on
the wiki. Note: There is a strong likelihood that you will go over the URL
length limit with a request to this API module, so you should use a POST
request instead.';
- }
-
- public function getExamples() {
- return array(
- );
- }
}
diff --git a/i18n/en.json b/i18n/en.json
index 2fccee6..c192e61 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -17,5 +17,12 @@
"imagetweaks-editor-flip-h": "Flip horizontally",
"imagetweaks-editor-crop": "Crop",
"imagetweaks-editor-crop-button": "Crop",
- "imagetweaks-editor-cancel": "Cancel"
+ "imagetweaks-editor-cancel": "Cancel",
+ "apihelp-imagetweaks-description": "Create a derivative image based on
an image already on the wiki. Note: There is a strong likelihood that you will
go over the URL length limit with a request to this API module, so you should
use a POST request instead.",
+ "apihelp-imagetweaks-param-text": "Initial page text for new files.",
+ "apihelp-imagetweaks-param-comment": "Upload comment. Also used as the
initial page text for new files if $1text is not specified.",
+ "apihelp-imagetweaks-param-file": "File contents.",
+ "apihelp-imagetweaks-param-destfile": "Target file.",
+ "apihelp-imagetweaks-param-filters": "What filters to add to the
image.",
+ "apihelp-imagetweaks-param-stash": "If set, the server will stash the
file temporarily instead of adding it to the repository."
}
diff --git a/i18n/qqq.json b/i18n/qqq.json
index a685189..21c9fac 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -20,5 +20,12 @@
"imagetweaks-editor-flip-h": "Button for flipping an image horizontally
(over the Y axis) in the image editor.",
"imagetweaks-editor-crop": "Opens a cropping interface in the image
editor.\n{{Identical|Crop}}",
"imagetweaks-editor-crop-button": "Finishes a crop in the image
editor.\n{{Identical|Crop}}",
- "imagetweaks-editor-cancel": "Cancels an interactive editing action,
like cropping.\n{{Identical|Cancel}}"
+ "imagetweaks-editor-cancel": "Cancels an interactive editing action,
like cropping.\n{{Identical|Cancel}}",
+ "apihelp-imagetweaks-description":
"{{doc-apihelp-description|imagetweaks}}",
+ "apihelp-imagetweaks-param-text":
"{{doc-apihelp-param|imagetweaks|text}}",
+ "apihelp-imagetweaks-param-comment":
"{{doc-apihelp-param|imagetweaks|comment}}",
+ "apihelp-imagetweaks-param-file":
"{{doc-apihelp-param|imagetweaks|file}}",
+ "apihelp-imagetweaks-param-destfile":
"{{doc-apihelp-param|imagetweaks|destfile}}",
+ "apihelp-imagetweaks-param-filters":
"{{doc-apihelp-param|imagetweaks|filters}}",
+ "apihelp-imagetweaks-param-stash":
"{{doc-apihelp-param|imagetweaks|stash}}"
}
--
To view, visit https://gerrit.wikimedia.org/r/332038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30c45582f499a67bf83c896427ab9bcd53367f6d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ImageTweaks
Gerrit-Branch: master
Gerrit-Owner: DatGuy
Gerrit-Reviewer: DatGuy
Gerrit-Reviewer: Hashar
Gerrit-Reviewer: Jforrester
Gerrit-Reviewer: MarkTraceur
Gerrit-Reviewer: Siebrand
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...ImageTweaks[master]: Fix extension ImageTweaks failing tests
DatGuy has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/332038 )
Change subject: Fix extension ImageTweaks failing tests
..
Fix extension ImageTweaks failing tests
Extension ImageTweaks failing tests due to missing apihelp messages
Bug: T155049
Change-Id: I30c45582f499a67bf83c896427ab9bcd53367f6d
---
M ApiImageTweaks.php
M i18n/en.json
M i18n/qqq.json
3 files changed, 19 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ImageTweaks
refs/changes/38/332038/1
diff --git a/ApiImageTweaks.php b/ApiImageTweaks.php
index 7fc9727..6be4646 100644
--- a/ApiImageTweaks.php
+++ b/ApiImageTweaks.php
@@ -109,10 +109,9 @@
);
}
- public function getDescription() {
- return 'Create a derivative image based on an image already on
the wiki. Note: There is a strong likelihood that you will go over the URL
length limit with a request to this API module, so you should use a POST
request instead.';
- }
-
+ /**
+ * @deprecated since MediaWiki core 1.25
+ */
public function getExamples() {
return array(
);
diff --git a/i18n/en.json b/i18n/en.json
index 2fccee6..c192e61 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -17,5 +17,12 @@
"imagetweaks-editor-flip-h": "Flip horizontally",
"imagetweaks-editor-crop": "Crop",
"imagetweaks-editor-crop-button": "Crop",
- "imagetweaks-editor-cancel": "Cancel"
+ "imagetweaks-editor-cancel": "Cancel",
+ "apihelp-imagetweaks-description": "Create a derivative image based on
an image already on the wiki. Note: There is a strong likelihood that you will
go over the URL length limit with a request to this API module, so you should
use a POST request instead.",
+ "apihelp-imagetweaks-param-text": "Initial page text for new files.",
+ "apihelp-imagetweaks-param-comment": "Upload comment. Also used as the
initial page text for new files if $1text is not specified.",
+ "apihelp-imagetweaks-param-file": "File contents.",
+ "apihelp-imagetweaks-param-destfile": "Target file.",
+ "apihelp-imagetweaks-param-filters": "What filters to add to the
image.",
+ "apihelp-imagetweaks-param-stash": "If set, the server will stash the
file temporarily instead of adding it to the repository."
}
diff --git a/i18n/qqq.json b/i18n/qqq.json
index a685189..21c9fac 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -20,5 +20,12 @@
"imagetweaks-editor-flip-h": "Button for flipping an image horizontally
(over the Y axis) in the image editor.",
"imagetweaks-editor-crop": "Opens a cropping interface in the image
editor.\n{{Identical|Crop}}",
"imagetweaks-editor-crop-button": "Finishes a crop in the image
editor.\n{{Identical|Crop}}",
- "imagetweaks-editor-cancel": "Cancels an interactive editing action,
like cropping.\n{{Identical|Cancel}}"
+ "imagetweaks-editor-cancel": "Cancels an interactive editing action,
like cropping.\n{{Identical|Cancel}}",
+ "apihelp-imagetweaks-description":
"{{doc-apihelp-description|imagetweaks}}",
+ "apihelp-imagetweaks-param-text":
"{{doc-apihelp-param|imagetweaks|text}}",
+ "apihelp-imagetweaks-param-comment":
"{{doc-apihelp-param|imagetweaks|comment}}",
+ "apihelp-imagetweaks-param-file":
"{{doc-apihelp-param|imagetweaks|file}}",
+ "apihelp-imagetweaks-param-destfile":
"{{doc-apihelp-param|imagetweaks|destfile}}",
+ "apihelp-imagetweaks-param-filters":
"{{doc-apihelp-param|imagetweaks|filters}}",
+ "apihelp-imagetweaks-param-stash":
"{{doc-apihelp-param|imagetweaks|stash}}"
}
--
To view, visit https://gerrit.wikimedia.org/r/332038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30c45582f499a67bf83c896427ab9bcd53367f6d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ImageTweaks
Gerrit-Branch: master
Gerrit-Owner: DatGuy
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
