[MediaWiki-commits] [Gerrit] mediawiki...MathSearch[master]: Fix: Use new generator for IDs

2017-07-13 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364981 )

Change subject: Fix: Use new generator for IDs
..


Fix: Use new generator for IDs

Before, all formulae had ID 0.

Change-Id: I8366ce34367960bdcb20504cd05d1d5db195b259
---
M maintenance/UpdateMath.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Physikerwelt: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/maintenance/UpdateMath.php b/maintenance/UpdateMath.php
index 129549e..f3941b6 100755
--- a/maintenance/UpdateMath.php
+++ b/maintenance/UpdateMath.php
@@ -153,7 +153,6 @@
 */
private function doUpdate( $pid, $pText, $pTitle = "", $revId = 0 ) {
$notused = '';
-   $eId=0;
$parser = new Parser();
$parser->mLinkID = 0;
$parser->mRevisionId = $revId;
@@ -203,6 +202,8 @@
Hooks::run( 'MathFormulaPostRender', [ 
$parser, &$renderer, &$notused ] );
$this->time( "hooks" );
} else {
+   $eId = null;
+   MathSearchHooks::setMathId( $eId, 
$renderer, $revId );
MathSearchHooks::writeMathIndex( 
$revId, $eId, $renderer->getInputHash(), '' );
$this->time( "index" );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/364981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8366ce34367960bdcb20504cd05d1d5db195b259
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MathSearch
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt 
Gerrit-Reviewer: Physikerwelt 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MathSearch[master]: Fix: Use new generator for IDs

2017-07-13 Thread Physikerwelt (Code Review) 
Physikerwelt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364981 )

Change subject: Fix: Use new generator for IDs
..

Fix: Use new generator for IDs

Before, all formulae had ID 0.

Change-Id: I8366ce34367960bdcb20504cd05d1d5db195b259
---
M maintenance/UpdateMath.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MathSearch 
refs/changes/81/364981/1

diff --git a/maintenance/UpdateMath.php b/maintenance/UpdateMath.php
index 129549e..f3941b6 100755
--- a/maintenance/UpdateMath.php
+++ b/maintenance/UpdateMath.php
@@ -153,7 +153,6 @@
 */
private function doUpdate( $pid, $pText, $pTitle = "", $revId = 0 ) {
$notused = '';
-   $eId=0;
$parser = new Parser();
$parser->mLinkID = 0;
$parser->mRevisionId = $revId;
@@ -203,6 +202,8 @@
Hooks::run( 'MathFormulaPostRender', [ 
$parser, &$renderer, &$notused ] );
$this->time( "hooks" );
} else {
+   $eId = null;
+   MathSearchHooks::setMathId( $eId, 
$renderer, $revId );
MathSearchHooks::writeMathIndex( 
$revId, $eId, $renderer->getInputHash(), '' );
$this->time( "index" );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/364981
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8366ce34367960bdcb20504cd05d1d5db195b259
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MathSearch
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits