[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Use preg_replace instead of str_replace for replacing extension
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395888 ) Change subject: Use preg_replace instead of str_replace for replacing extension .. Use preg_replace instead of str_replace for replacing extension Bug: T166684 Change-Id: I233be410486276f30b08034180eb54cb08e04076 --- M includes/skins/SkinMinerva.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: jenkins-bot: Verified Thiemo Mättig (WMDE): Looks good to me, approved diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index 62cd5be..439d47c 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -56,7 +56,7 @@ if ( isset( $customLogos['copyright-fallback'] ) ) { $attributes['src'] = $customLogos['copyright-fallback']; } else { - $attributes['src'] = str_replace( '.svg', '.png', $customLogos['copyright'] ); + $attributes['src'] = preg_replace( '/\.svg$/i', '.png', $customLogos['copyright'] ); } } if ( isset( $customLogos['copyright-height'] ) ) { -- To view, visit https://gerrit.wikimedia.org/r/395888 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I233be410486276f30b08034180eb54cb08e04076 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/skins/MinervaNeue Gerrit-Branch: master Gerrit-Owner: DivadsnGerrit-Reviewer: Divadsn Gerrit-Reviewer: Jdlrobson Gerrit-Reviewer: Pmiazga Gerrit-Reviewer: Thiemo Mättig (WMDE) Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Use preg_replace instead of str_replace for replacing extension
Divadsn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395888 ) Change subject: Use preg_replace instead of str_replace for replacing extension .. Use preg_replace instead of str_replace for replacing extension Bug: T166684 Change-Id: I233be410486276f30b08034180eb54cb08e04076 --- M includes/skins/SkinMinerva.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue refs/changes/88/395888/1 diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index 62cd5be..ea4625b 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -56,7 +56,7 @@ if ( isset( $customLogos['copyright-fallback'] ) ) { $attributes['src'] = $customLogos['copyright-fallback']; } else { - $attributes['src'] = str_replace( '.svg', '.png', $customLogos['copyright'] ); + $attributes['src'] = preg_replace( '"\.svg$"', '.png', $customLogos['copyright'] ); } } if ( isset( $customLogos['copyright-height'] ) ) { -- To view, visit https://gerrit.wikimedia.org/r/395888 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I233be410486276f30b08034180eb54cb08e04076 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/MinervaNeue Gerrit-Branch: master Gerrit-Owner: Divadsn___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits