[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove VisualEditor browser test inside MobileFrontend

2017-01-14 Thread MtDu (Code Review)
MtDu has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/332082 )

Change subject: Remove VisualEditor browser test inside MobileFrontend
..

Remove VisualEditor browser test inside MobileFrontend

There is a test in tests/browser/features/editor_ve.feature.
However, it is skipped on all environments. This patch removes this test.

Bug: T150338
Change-Id: I58152a592b3ca94586907d4e852055db10308a85
---
D tests/browser/features/editor_ve.feature
1 file changed, 0 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/82/332082/1

diff --git a/tests/browser/features/editor_ve.feature 
b/tests/browser/features/editor_ve.feature
deleted file mode 100644
index fb5e845..000
--- a/tests/browser/features/editor_ve.feature
+++ /dev/null
@@ -1,23 +0,0 @@
-@chrome @editing @en.m.wikipedia.beta.wmflabs.org @extension-visualeditor 
@firefox @skip @vagrant @login
-Feature: VisualEditor Mobile
-
-  # Tests are skipped due to https://phabricator.wikimedia.org/T88559
-  Background:
-Given I am logged into the mobile website
-  And I am in beta mode
-  And I am editing a new article with VisualEditor
-
-  Scenario: Switch from VisualEditor to source editor
-When I switch to editing the source
-  And I see the wikitext editor overlay
-  And I click the wikitext editor overlay close button
-Then I should not see the wikitext editor overlay
-
-  Scenario: I can edit a page using VisualEditor
-When I edit the article using VisualEditor
-Then I should see the edit reflected in the article content
-
-  Scenario: Going back from save screen in VisualEditor
-When I click the escape button
-Then I should see the article content
-  And I should no longer see the VisualEditor

-- 
To view, visit https://gerrit.wikimedia.org/r/332082
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I58152a592b3ca94586907d4e852055db10308a85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: MtDu 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove VisualEditor browser test inside MobileFrontend

2017-01-16 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/332082 )

Change subject: Remove VisualEditor browser test inside MobileFrontend
..


Remove VisualEditor browser test inside MobileFrontend

There is a test in tests/browser/features/editor_ve.feature.
However, it is skipped on all environments. This patch removes this test.

Bug: T150338
Change-Id: I58152a592b3ca94586907d4e852055db10308a85
---
D tests/browser/features/editor_ve.feature
1 file changed, 0 insertions(+), 23 deletions(-)

Approvals:
  Filip: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/tests/browser/features/editor_ve.feature 
b/tests/browser/features/editor_ve.feature
deleted file mode 100644
index fb5e845..000
--- a/tests/browser/features/editor_ve.feature
+++ /dev/null
@@ -1,23 +0,0 @@
-@chrome @editing @en.m.wikipedia.beta.wmflabs.org @extension-visualeditor 
@firefox @skip @vagrant @login
-Feature: VisualEditor Mobile
-
-  # Tests are skipped due to https://phabricator.wikimedia.org/T88559
-  Background:
-Given I am logged into the mobile website
-  And I am in beta mode
-  And I am editing a new article with VisualEditor
-
-  Scenario: Switch from VisualEditor to source editor
-When I switch to editing the source
-  And I see the wikitext editor overlay
-  And I click the wikitext editor overlay close button
-Then I should not see the wikitext editor overlay
-
-  Scenario: I can edit a page using VisualEditor
-When I edit the article using VisualEditor
-Then I should see the edit reflected in the article content
-
-  Scenario: Going back from save screen in VisualEditor
-When I click the escape button
-Then I should see the article content
-  And I should no longer see the VisualEditor

-- 
To view, visit https://gerrit.wikimedia.org/r/332082
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I58152a592b3ca94586907d4e852055db10308a85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: MtDu 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: Filip 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: MtDu 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits