Pppery has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401418 )
Change subject: Add unit test for removing publishers via API ...................................................................... Add unit test for removing publishers via API Bug: T183817 Bug: T183821 Depends-on: I1fc356db895c84d15b2f74aa34cfb24f5d8ff4df Change-Id: Iafab9073a1b07a7b45b3ed4d6837053d20f92d55 --- M tests/content/NewsletterAPIEditTest.php 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter refs/changes/18/401418/1 diff --git a/tests/content/NewsletterAPIEditTest.php b/tests/content/NewsletterAPIEditTest.php index 94113e7..94c9afc 100644 --- a/tests/content/NewsletterAPIEditTest.php +++ b/tests/content/NewsletterAPIEditTest.php @@ -154,4 +154,32 @@ $this->assertEquals( $newsletter->getPublishers(), $expectedUsers ); $this->assertEquals( $newsletter->getSubscribers(), $expectedUsers ); } + public function testRemovePublisher() { + # Set up + $newsletter = $this->createNewsletter(); + $firstUser = User::newFromName( 'UTSysop' ); + $secondUser = User::newFromName( 'Second User' ); + $secondUser->addToDatabase(); + $publisherIds = [ $firstUser->getId(), $secondUser->getId() ]; + NewsletterStore::getDefaultInstance()->addPublisher( $newsletter, $publisherIds ); + + # Modify the publishers + $newText = '{ + "description": "' . self::DESCRIPTION . '", + "mainpage": "UTPage", + "publishers": [ + ] + }'; + $this->doApiRequestWithToken( + [ + 'action' => 'edit', + 'title' => "Newsletter:Test", + 'text' => $newText, + ] + ); + + # Check that users were correctly removed + $newsletter = Newsletter::newFromName( "Test" ); + $this->assertEquals( $newsletter->getPublishers(), [] ); + } } -- To view, visit https://gerrit.wikimedia.org/r/401418 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iafab9073a1b07a7b45b3ed4d6837053d20f92d55 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Newsletter Gerrit-Branch: master Gerrit-Owner: Pppery <maprea...@olum.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits