[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Unit test NewsletterDb::removePublisher

2017-12-28 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/400609 )

Change subject: Unit test NewsletterDb::removePublisher
..


Unit test NewsletterDb::removePublisher

Bug: T183616
Change-Id: I2f1cd5820178c9eafad1bbcdc7c0f3b3e87eff94
---
M tests/NewsletterDbTest.php
1 file changed, 27 insertions(+), 0 deletions(-)

Approvals:
  01tonythomas: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/NewsletterDbTest.php b/tests/NewsletterDbTest.php
index 78c80a6..01c904b 100644
--- a/tests/NewsletterDbTest.php
+++ b/tests/NewsletterDbTest.php
@@ -138,6 +138,33 @@
}
 
/**
+* @covers NewsletterDb::removePublisher
+*/
+   public function testRemovePublisher() {
+   $mockWriteDb = $this->getMockIDatabase();
+   $user = User::newFromName( 'Test User' );
+   $user->addtoDatabase();
+
+   $mockWriteDb
+   ->expects( $this->once() )
+   ->method( 'delete' )
+   ->with(
+   'nl_publishers',
+   [ 'nlp_newsletter_id' => 1, 'nlp_publisher_id' 
=> $user->getId() ]
+   );
+   $mockWriteDb
+   ->expects( $this->once() )
+   ->method( 'affectedRows' )
+   ->will( $this->returnValue( 1 ) );
+
+   $table = new NewsletterDb( $this->getMockLoadBalancer( 
$mockWriteDb ) );
+
+   $result = $table->removePublisher( $this->getTestNewsletter(), 
$user );
+
+   $this->assertTrue( $result );
+   }
+
+   /**
 * @covers NewsletterDb::addNewsletter
 */
public function testAddNewsletter() {

-- 
To view, visit https://gerrit.wikimedia.org/r/400609
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2f1cd5820178c9eafad1bbcdc7c0f3b3e87eff94
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Ryan10145 
Gerrit-Reviewer: 01tonythomas <01tonytho...@gmail.com>
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Unit test NewsletterDb::removePublisher

2017-12-28 Thread Ryan10145 (Code Review) 
Ryan10145 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400609 )

Change subject: Unit test NewsletterDb::removePublisher
..

Unit test NewsletterDb::removePublisher

Bug: T183616
Change-Id: I2f1cd5820178c9eafad1bbcdc7c0f3b3e87eff94
---
M tests/NewsletterDbTest.php
1 file changed, 27 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter 
refs/changes/09/400609/1

diff --git a/tests/NewsletterDbTest.php b/tests/NewsletterDbTest.php
index 78c80a6..8701f53 100644
--- a/tests/NewsletterDbTest.php
+++ b/tests/NewsletterDbTest.php
@@ -138,6 +138,33 @@
}
 
/**
+* @covers NewsletterDb::removePublisher
+*/
+   public function testRemovePublisher() {
+   $mockWriteDb = $this->getMockIDatabase();
+   $user = User::newFromName( 'Test User' );
+   $user->addtoDatabase();
+
+   $mockWriteDb
+   ->expects( $this->once() )
+   ->method( 'delete' )
+   ->with(
+   'nl_publishers',
+   [ 'nlp_newsletter_id' => 1, 'nlp_publisher_id' 
=> $user->getId() ]
+   );
+   $mockWriteDb
+   ->expects( $this->once() )
+   ->method( 'affectedRows' )
+   ->will ($this->returnValue( 1 ) );
+
+   $table = new NewsletterDb( $this->getMockLoadBalancer( 
$mockWriteDb ) );
+
+   $result = $table->removePublisher( $this->getTestNewsletter(), 
$user );
+
+   $this->assertTrue( $result );
+   }
+
+   /**
 * @covers NewsletterDb::addNewsletter
 */
public function testAddNewsletter() {

-- 
To view, visit https://gerrit.wikimedia.org/r/400609
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f1cd5820178c9eafad1bbcdc7c0f3b3e87eff94
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Ryan10145 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits