[MediaWiki-commits] [Gerrit] mediawiki...OAuth[master]: Fix restriction validation bug

2017-01-27 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/334501 )

Change subject: Fix restriction validation bug
..


Fix restriction validation bug

Introduced in I8c2a2713e94b.

Change-Id: I567204fa1c615f215722a4bd6ee9a4e89dccaf45
---
M control/MWOAuthSubmitControl.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/control/MWOAuthSubmitControl.php b/control/MWOAuthSubmitControl.php
index 1864b1f..57d5af0 100644
--- a/control/MWOAuthSubmitControl.php
+++ b/control/MWOAuthSubmitControl.php
@@ -178,7 +178,7 @@
if ( !isset( $this->vals[$field] ) ) {
// @TODO: check for field-specific message first
return $this->failure( "missing_field_$field", 
'mwoauth-missing-field', $field );
-   } elseif ( !is_scalar( $this->vals[$field] ) ) {
+   } elseif ( !is_scalar( $this->vals[$field] ) && $field 
!== 'restrictions' ) {
// @TODO: check for field-specific message first
return $this->failure( "invalid_field_$field", 
'mwoauth-invalid-field', $field );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/334501
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I567204fa1c615f215722a4bd6ee9a4e89dccaf45
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuth
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...OAuth[master]: Fix restriction validation bug

2017-01-26 Thread Code Review 
Gergő Tisza has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/334501 )

Change subject: Fix restriction validation bug
..

Fix restriction validation bug

Introduced in I8c2a2713e94b.

Change-Id: I567204fa1c615f215722a4bd6ee9a4e89dccaf45
---
M control/MWOAuthSubmitControl.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OAuth 
refs/changes/01/334501/1

diff --git a/control/MWOAuthSubmitControl.php b/control/MWOAuthSubmitControl.php
index 1864b1f..57d5af0 100644
--- a/control/MWOAuthSubmitControl.php
+++ b/control/MWOAuthSubmitControl.php
@@ -178,7 +178,7 @@
if ( !isset( $this->vals[$field] ) ) {
// @TODO: check for field-specific message first
return $this->failure( "missing_field_$field", 
'mwoauth-missing-field', $field );
-   } elseif ( !is_scalar( $this->vals[$field] ) ) {
+   } elseif ( !is_scalar( $this->vals[$field] ) && $field 
!== 'restrictions' ) {
// @TODO: check for field-specific message first
return $this->failure( "invalid_field_$field", 
'mwoauth-invalid-field', $field );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/334501
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I567204fa1c615f215722a4bd6ee9a4e89dccaf45
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuth
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits