[MediaWiki-commits] [Gerrit] mediawiki...ParserFunctions[master]: Remove 'UnitTestList' hook

2016-08-05 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove 'UnitTestList' hook
..


Remove 'UnitTestList' hook

No longer needed now that extension unittests are autodiscovered.

Bug: T142120
Bug: T142121
Change-Id: I075b7f6b5e11ead988b0baba5d85745dbb9ac480
---
M ParserFunctions.hooks.php
M extension.json
R tests/phpunit/ExpressionTest.php
3 files changed, 0 insertions(+), 12 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/ParserFunctions.hooks.php b/ParserFunctions.hooks.php
index 63ff756..b204333 100644
--- a/ParserFunctions.hooks.php
+++ b/ParserFunctions.hooks.php
@@ -50,15 +50,6 @@
return true;
}
 
-   /**
-* @param $files array
-* @return bool
-*/
-   public static function onUnitTestsList( &$files ) {
-   $files[] = __DIR__ . '/tests/ExpressionTest.php';
-   return true;
-   }
-
public static function onScribuntoExternalLibraries( $engine, array 
&$extraLibraries ) {
if ( $engine === 'lua' ) {
$extraLibraries['mw.ext.ParserFunctions'] = 
'Scribunto_LuaParserFunctionsLibrary';
diff --git a/extension.json b/extension.json
index 3667962..6a5464a 100644
--- a/extension.json
+++ b/extension.json
@@ -31,9 +31,6 @@
"ParserFirstCallInit": [
"ParserFunctionsHooks::onParserFirstCallInit"
],
-   "UnitTestsList": [
-   "ParserFunctionsHooks::onUnitTestsList"
-   ],
"ScribuntoExternalLibraries": [
"ParserFunctionsHooks::onScribuntoExternalLibraries"
]
diff --git a/tests/ExpressionTest.php b/tests/phpunit/ExpressionTest.php
similarity index 100%
rename from tests/ExpressionTest.php
rename to tests/phpunit/ExpressionTest.php

-- 
To view, visit https://gerrit.wikimedia.org/r/303268
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I075b7f6b5e11ead988b0baba5d85745dbb9ac480
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ParserFunctions
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ParserFunctions[master]: Remove 'UnitTestList' hook

2016-08-05 Thread Reedy (Code Review) 
Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/303268

Change subject: Remove 'UnitTestList' hook
..

Remove 'UnitTestList' hook

No longer needed now that extension unittests are autodiscovered.

Bug: T142120
Bug: T142121
Change-Id: I075b7f6b5e11ead988b0baba5d85745dbb9ac480
---
M ParserFunctions.hooks.php
M extension.json
R tests/phpunit/ExpressionTest.php
3 files changed, 0 insertions(+), 12 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ParserFunctions 
refs/changes/68/303268/1

diff --git a/ParserFunctions.hooks.php b/ParserFunctions.hooks.php
index 63ff756..b204333 100644
--- a/ParserFunctions.hooks.php
+++ b/ParserFunctions.hooks.php
@@ -50,15 +50,6 @@
return true;
}
 
-   /**
-* @param $files array
-* @return bool
-*/
-   public static function onUnitTestsList( &$files ) {
-   $files[] = __DIR__ . '/tests/ExpressionTest.php';
-   return true;
-   }
-
public static function onScribuntoExternalLibraries( $engine, array 
&$extraLibraries ) {
if ( $engine === 'lua' ) {
$extraLibraries['mw.ext.ParserFunctions'] = 
'Scribunto_LuaParserFunctionsLibrary';
diff --git a/extension.json b/extension.json
index 3667962..6a5464a 100644
--- a/extension.json
+++ b/extension.json
@@ -31,9 +31,6 @@
"ParserFirstCallInit": [
"ParserFunctionsHooks::onParserFirstCallInit"
],
-   "UnitTestsList": [
-   "ParserFunctionsHooks::onUnitTestsList"
-   ],
"ScribuntoExternalLibraries": [
"ParserFunctionsHooks::onScribuntoExternalLibraries"
]
diff --git a/tests/ExpressionTest.php b/tests/phpunit/ExpressionTest.php
similarity index 100%
rename from tests/ExpressionTest.php
rename to tests/phpunit/ExpressionTest.php

-- 
To view, visit https://gerrit.wikimedia.org/r/303268
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I075b7f6b5e11ead988b0baba5d85745dbb9ac480
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ParserFunctions
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits