[MediaWiki-commits] [Gerrit] mediawiki...PictureGame[master]: Use addModuleStyles() instead of addModules() for loading CS...
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/334731 ) Change subject: Use addModuleStyles() instead of addModules() for loading CSS-only RL modules to prevent Flash of Unstyled Content .. Use addModuleStyles() instead of addModules() for loading CSS-only RL modules to prevent Flash of Unstyled Content Change-Id: I80213a2a23b6c9d7d114dced2eb7ce1923a7b949 --- M PictureGameHome.body.php 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Jack Phoenix: Looks good to me, approved jenkins-bot: Verified diff --git a/PictureGameHome.body.php b/PictureGameHome.body.php index 66761a3..9978497 100644 --- a/PictureGameHome.body.php +++ b/PictureGameHome.body.php @@ -45,6 +45,7 @@ $out->readOnlyPage(); return false; } + // https://phabricator.wikimedia.org/T155405 // Throws error message when SocialProfile extension is not installed if( !class_exists( 'UserStats' ) ) { @@ -344,7 +345,7 @@ $output = ''; - $out->addModules( 'ext.pictureGame.editPanel' ); + $out->addModuleStyles( 'ext.pictureGame.editPanel' ); $out->setPageTitle( $this->msg( 'picturegame-editgame-editing-title', $title_text )->text() ); @@ -479,7 +480,7 @@ var __admin_panel_key__ = "' . $key . '"; '; - $out->addModules( 'ext.pictureGame.adminPanel' ); + $out->addModuleStyles( 'ext.pictureGame.adminPanel' ); $out->setPageTitle( $this->msg( 'picturegame-adminpaneltitle' )->text() ); $output .= ' @@ -745,7 +746,7 @@ } // Add CSS - $out->addModules( 'ext.pictureGame.gallery' ); + $out->addModuleStyles( 'ext.pictureGame.gallery' ); $output = ''; @@ -1666,7 +1667,7 @@ ); if( $mycount == 0 ) { - $out->addModules( 'ext.pictureGame.mainGame' ); + $out->addModuleStyles( 'ext.pictureGame.mainGame' ); $output = ' ' . $this->msg( 'picturegame-permalinkflagged' )->text() . ' @@ -1681,7 +1682,7 @@ } } - $out->addModules( 'ext.pictureGame.mainGame' ); + $out->addModuleStyles( 'ext.pictureGame.mainGame' ); $output = '' . $this->getImageDivs( $isPermalink, $permalinkID, $lastId ) . @@ -1785,7 +1786,7 @@ $out->setHTMLTitle( $this->msg( 'pagetitle', $this->msg( 'picturegame-creategametitle' )->text() )->text() ); $out->setPageTitle( $this->msg( 'picturegame-creategametitle' )->text() ); - $out->addModules( 'ext.pictureGame.startGame' ); + $out->addModuleStyles( 'ext.pictureGame.startGame' ); $output = "\t\t" . ''; $output .= $this->msg( 'picturegame-creategamewelcome' )->text(); -- To view, visit https://gerrit.wikimedia.org/r/334731 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80213a2a23b6c9d7d114dced2eb7ce1923a7b949 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PictureGame Gerrit-Branch: master Gerrit-Owner: Jack Phoenix Gerrit-Reviewer: Jack Phoenix Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...PictureGame[master]: Use addModuleStyles() instead of addModules() for loading CS...
Jack Phoenix has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334731 ) Change subject: Use addModuleStyles() instead of addModules() for loading CSS-only RL modules to prevent Flash of Unstyled Content .. Use addModuleStyles() instead of addModules() for loading CSS-only RL modules to prevent Flash of Unstyled Content Change-Id: I80213a2a23b6c9d7d114dced2eb7ce1923a7b949 --- M PictureGameHome.body.php 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PictureGame refs/changes/31/334731/1 diff --git a/PictureGameHome.body.php b/PictureGameHome.body.php index 66761a3..9978497 100644 --- a/PictureGameHome.body.php +++ b/PictureGameHome.body.php @@ -45,6 +45,7 @@ $out->readOnlyPage(); return false; } + // https://phabricator.wikimedia.org/T155405 // Throws error message when SocialProfile extension is not installed if( !class_exists( 'UserStats' ) ) { @@ -344,7 +345,7 @@ $output = ''; - $out->addModules( 'ext.pictureGame.editPanel' ); + $out->addModuleStyles( 'ext.pictureGame.editPanel' ); $out->setPageTitle( $this->msg( 'picturegame-editgame-editing-title', $title_text )->text() ); @@ -479,7 +480,7 @@ var __admin_panel_key__ = "' . $key . '"; '; - $out->addModules( 'ext.pictureGame.adminPanel' ); + $out->addModuleStyles( 'ext.pictureGame.adminPanel' ); $out->setPageTitle( $this->msg( 'picturegame-adminpaneltitle' )->text() ); $output .= ' @@ -745,7 +746,7 @@ } // Add CSS - $out->addModules( 'ext.pictureGame.gallery' ); + $out->addModuleStyles( 'ext.pictureGame.gallery' ); $output = ''; @@ -1666,7 +1667,7 @@ ); if( $mycount == 0 ) { - $out->addModules( 'ext.pictureGame.mainGame' ); + $out->addModuleStyles( 'ext.pictureGame.mainGame' ); $output = ' ' . $this->msg( 'picturegame-permalinkflagged' )->text() . ' @@ -1681,7 +1682,7 @@ } } - $out->addModules( 'ext.pictureGame.mainGame' ); + $out->addModuleStyles( 'ext.pictureGame.mainGame' ); $output = '' . $this->getImageDivs( $isPermalink, $permalinkID, $lastId ) . @@ -1785,7 +1786,7 @@ $out->setHTMLTitle( $this->msg( 'pagetitle', $this->msg( 'picturegame-creategametitle' )->text() )->text() ); $out->setPageTitle( $this->msg( 'picturegame-creategametitle' )->text() ); - $out->addModules( 'ext.pictureGame.startGame' ); + $out->addModuleStyles( 'ext.pictureGame.startGame' ); $output = "\t\t" . ''; $output .= $this->msg( 'picturegame-creategamewelcome' )->text(); -- To view, visit https://gerrit.wikimedia.org/r/334731 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I80213a2a23b6c9d7d114dced2eb7ce1923a7b949 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PictureGame Gerrit-Branch: master Gerrit-Owner: Jack Phoenix ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits