[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/368055 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
..
build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
Change-Id: Icf865f9b4d44f088bdb39ccd2576d171834eeaf5
---
M ProofreadPage.body.php
M composer.json
M phpcs.xml
M tests/phpunit/index/ProofreadIndexPageTest.php
4 files changed, 6 insertions(+), 8 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/ProofreadPage.body.php b/ProofreadPage.body.php
index f8c1ede..eda957a 100644
--- a/ProofreadPage.body.php
+++ b/ProofreadPage.body.php
@@ -312,20 +312,20 @@
$title = $article->getTitle();
// if it's an index, update pr_index table
- if ( $title->inNamespace( ProofreadPage::getIndexNamespaceId()
) ) {
+ if ( $title->inNamespace( self::getIndexNamespaceId() ) ) {
// Move this part to EditProofreadIndexPage
- ProofreadPage::updatePrIndex( $article );
+ self::updatePrIndex( $article );
return true;
}
// return if it is not a page
- if ( !$title->inNamespace( ProofreadPage::getPageNamespaceId()
) ) {
+ if ( !$title->inNamespace( self::getPageNamespaceId() ) ) {
return true;
}
/* check if there is an index */
if ( !isset( $title->prpIndexPage ) ) {
- ProofreadPage::loadIndex( $title );
+ self::loadIndex( $title );
}
if ( $title->prpIndexPage === null ) {
return true;
diff --git a/composer.json b/composer.json
index b5e294c..c12a316 100644
--- a/composer.json
+++ b/composer.json
@@ -9,7 +9,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.10.0",
+ "mediawiki/mediawiki-codesniffer": "0.10.1",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/phpcs.xml b/phpcs.xml
index 0a5187b..868ce12 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -13,6 +13,4 @@
.
- node_modules/
- vendor/
diff --git a/tests/phpunit/index/ProofreadIndexPageTest.php
b/tests/phpunit/index/ProofreadIndexPageTest.php
index 3e6c32a..8173f52 100644
--- a/tests/phpunit/index/ProofreadIndexPageTest.php
+++ b/tests/phpunit/index/ProofreadIndexPageTest.php
@@ -200,7 +200,7 @@
}
public function testGetLinksToPageNamespace() {
- $page = ProofreadIndexPageTest::newIndexPage(
+ $page = self::newIndexPage(
'Test',
"{{\n|Pages=[[Page:Test 1.jpg|TOC]] [[Page:Test
2.tiff|1]] [[Page:Test:3.png|2]]" .
"\n|Author=[[Author:Me]]\n}}"
--
To view, visit https://gerrit.wikimedia.org/r/368055
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf865f9b4d44f088bdb39ccd2576d171834eeaf5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Umherirrender
Gerrit-Reviewer: Jforrester
Gerrit-Reviewer: Legoktm
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368055 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
..
build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
Change-Id: Icf865f9b4d44f088bdb39ccd2576d171834eeaf5
---
M ProofreadPage.body.php
M composer.json
M phpcs.xml
M tests/phpunit/index/ProofreadIndexPageTest.php
4 files changed, 6 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage
refs/changes/55/368055/1
diff --git a/ProofreadPage.body.php b/ProofreadPage.body.php
index f8c1ede..eda957a 100644
--- a/ProofreadPage.body.php
+++ b/ProofreadPage.body.php
@@ -312,20 +312,20 @@
$title = $article->getTitle();
// if it's an index, update pr_index table
- if ( $title->inNamespace( ProofreadPage::getIndexNamespaceId()
) ) {
+ if ( $title->inNamespace( self::getIndexNamespaceId() ) ) {
// Move this part to EditProofreadIndexPage
- ProofreadPage::updatePrIndex( $article );
+ self::updatePrIndex( $article );
return true;
}
// return if it is not a page
- if ( !$title->inNamespace( ProofreadPage::getPageNamespaceId()
) ) {
+ if ( !$title->inNamespace( self::getPageNamespaceId() ) ) {
return true;
}
/* check if there is an index */
if ( !isset( $title->prpIndexPage ) ) {
- ProofreadPage::loadIndex( $title );
+ self::loadIndex( $title );
}
if ( $title->prpIndexPage === null ) {
return true;
diff --git a/composer.json b/composer.json
index b5e294c..c12a316 100644
--- a/composer.json
+++ b/composer.json
@@ -9,7 +9,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.10.0",
+ "mediawiki/mediawiki-codesniffer": "0.10.1",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/phpcs.xml b/phpcs.xml
index 0a5187b..868ce12 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -13,6 +13,4 @@
.
- node_modules/
- vendor/
diff --git a/tests/phpunit/index/ProofreadIndexPageTest.php
b/tests/phpunit/index/ProofreadIndexPageTest.php
index 3e6c32a..8173f52 100644
--- a/tests/phpunit/index/ProofreadIndexPageTest.php
+++ b/tests/phpunit/index/ProofreadIndexPageTest.php
@@ -200,7 +200,7 @@
}
public function testGetLinksToPageNamespace() {
- $page = ProofreadIndexPageTest::newIndexPage(
+ $page = self::newIndexPage(
'Test',
"{{\n|Pages=[[Page:Test 1.jpg|TOC]] [[Page:Test
2.tiff|1]] [[Page:Test:3.png|2]]" .
"\n|Author=[[Author:Me]]\n}}"
--
To view, visit https://gerrit.wikimedia.org/r/368055
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf865f9b4d44f088bdb39ccd2576d171834eeaf5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Umherirrender
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
