[MediaWiki-commits] [Gerrit] mediawiki...QuickGV[master]: Fix for windows system to find php.exe

2017-10-11 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/383509 )

Change subject: Fix for windows system to find php.exe
..


Fix for windows system to find php.exe

Bug: T177828
Change-Id: Ia7fbe335e571b93f321aa989cd7294d4f2088482
---
M QuickGV.body.php
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  小璋丸: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/QuickGV.body.php b/QuickGV.body.php
index 1058711..b004015 100644
--- a/QuickGV.body.php
+++ b/QuickGV.body.php
@@ -70,7 +70,10 @@
if ($dotcmd=='') return self::showError();
 
// PHP 環境檢查
-   $phpcmd = self::findExecutable('php', self::PHP_PATH);
+   if (PHP_OS=='WINNT')
+$phpcmd = dirname(PHP_BINARY) . "\php.exe"; //php-cgi.exe 
might be used but we want php.exe
+   else $phpcmd = self::findExecutable('php', self::PHP_PATH);   
+   
if ($phpcmd=='') return self::showError();
 
// $in 上限管制

-- 
To view, visit https://gerrit.wikimedia.org/r/383509
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7fbe335e571b93f321aa989cd7294d4f2088482
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/QuickGV
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader 
Gerrit-Reviewer: Aklapper 
Gerrit-Reviewer: Gerrit Patch Uploader 
Gerrit-Reviewer: jenkins-bot <>
Gerrit-Reviewer: 小璋丸 
Gerrit-Reviewer: 星耀晨曦 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...QuickGV[master]: Fix for windows system to find php.exe

2017-10-10 Thread Gerrit Patch Uploader (Code Review) 
Gerrit Patch Uploader has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383509 )

Change subject: Fix for windows system to find php.exe
..

Fix for windows system to find php.exe

Change-Id: Ia7fbe335e571b93f321aa989cd7294d4f2088482
---
M QuickGV.body.php
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuickGV 
refs/changes/09/383509/1

diff --git a/QuickGV.body.php b/QuickGV.body.php
index 1058711..b004015 100644
--- a/QuickGV.body.php
+++ b/QuickGV.body.php
@@ -70,7 +70,10 @@
if ($dotcmd=='') return self::showError();
 
// PHP 環境檢查
-   $phpcmd = self::findExecutable('php', self::PHP_PATH);
+   if (PHP_OS=='WINNT')
+$phpcmd = dirname(PHP_BINARY) . "\php.exe"; //php-cgi.exe 
might be used but we want php.exe
+   else $phpcmd = self::findExecutable('php', self::PHP_PATH);   
+   
if ($phpcmd=='') return self::showError();
 
// $in 上限管制

-- 
To view, visit https://gerrit.wikimedia.org/r/383509
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7fbe335e571b93f321aa989cd7294d4f2088482
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/QuickGV
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits