[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/368082 ) Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1 .. build: Updating mediawiki/mediawiki-codesniffer to 0.10.1 Change-Id: Ie05b9ddc3e351abf4b2b199529b714766055d161 --- M composer.json M includes/FooterHooks.php M includes/Hooks.php M includes/SidebarHooks.php M phpcs.xml 5 files changed, 9 insertions(+), 10 deletions(-) Approvals: jenkins-bot: Verified Jforrester: Looks good to me, approved diff --git a/composer.json b/composer.json index 1366381..55507be 100644 --- a/composer.json +++ b/composer.json @@ -1,7 +1,7 @@ { "require-dev": { "jakub-onderka/php-parallel-lint": "0.9.2", - "mediawiki/mediawiki-codesniffer": "0.10.0", + "mediawiki/mediawiki-codesniffer": "0.10.1", "jakub-onderka/php-console-highlighter": "0.3.2" }, "scripts": { diff --git a/includes/FooterHooks.php b/includes/FooterHooks.php index 2a76369..f43e8cc 100644 --- a/includes/FooterHooks.php +++ b/includes/FooterHooks.php @@ -21,7 +21,7 @@ * * @param array &$vars variables to be added into the output of OutputPage::headElement. * @param OutputPage $out OutputPage instance calling the hook -* @return boolean Always true +* @return bool Always true */ public static function onMakeGlobalVariablesScript( &$vars, OutputPage $out ) { $config = MediaWikiServices::getInstance()->getConfigFactory() @@ -102,7 +102,7 @@ * * @param OutputPage $out The OutputPage object * @param Skin $skin Skin object that will be used to generate the page -* @return boolean Always true +* @return bool Always true */ public static function onBeforePageDisplay( OutputPage $out, Skin $skin ) { $config = MediaWikiServices::getInstance()->getConfigFactory() @@ -153,7 +153,7 @@ * @see https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderGetConfigVars * * @param array &$vars Array of variables to be added into the output of the startup module. -* @return boolean +* @return bool */ public static function onResourceLoaderGetConfigVars( &$vars ) { $config = MediaWikiServices::getInstance()->getConfigFactory() @@ -180,7 +180,7 @@ * @see https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderRegisterModules * * @param ResourceLoader &$resourceLoader The ResourceLoader object -* @return boolean +* @return bool */ public static function onResourceLoaderRegisterModules( ResourceLoader &$resourceLoader ) { $dependencies = []; diff --git a/includes/Hooks.php b/includes/Hooks.php index e64164d..7027581 100644 --- a/includes/Hooks.php +++ b/includes/Hooks.php @@ -15,7 +15,7 @@ * {@see Hooks::onFuncRelated}). * * @param Parser &$parser Paser object -* @return boolean Always true +* @return bool Always true */ public static function onParserFirstCallInit( Parser &$parser ) { $parser->setFunctionHook( 'related', 'RelatedArticles\\Hooks::onFuncRelated' ); @@ -64,7 +64,7 @@ * * @param OutputPage &$out the OutputPage object * @param ParserOutput $parserOutput ParserOutput object -* @return boolean Always true +* @return bool Always true */ public static function onOutputPageParserOutput( OutputPage &$out, ParserOutput $parserOutput ) { $related = $parserOutput->getExtensionData( 'RelatedArticles' ); diff --git a/includes/SidebarHooks.php b/includes/SidebarHooks.php index 7ccaefa..2b73e74 100644 --- a/includes/SidebarHooks.php +++ b/includes/SidebarHooks.php @@ -19,7 +19,7 @@ * * @param Skin $skin Skin object * @param array &$bar Sidebar contents -* @return boolean Always true +* @return bool Always true */ public static function onSidebarBeforeOutput( Skin $skin, &$bar ) { $out = $skin->getOutput(); diff --git a/phpcs.xml b/phpcs.xml index ea36036..b0464c3 100644 --- a/phpcs.xml +++ b/phpcs.xml @@ -4,6 +4,5 @@ . - - vendor + -- To view, visit https://gerrit.wikimedia.org/r/368082 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie05b9ddc3e351abf4b2b199529b714766055d161 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/RelatedArticles Gerrit-Branch: master Gerrit-Owner: UmherirrenderGerrit-Reviewer: Jforrester Gerrit-Reviewer: Legoktm Gerrit-Reviewer: Niedzielski
[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1
Umherirrender has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368082 ) Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.10.1 .. build: Updating mediawiki/mediawiki-codesniffer to 0.10.1 Change-Id: Ie05b9ddc3e351abf4b2b199529b714766055d161 --- M composer.json M includes/FooterHooks.php M includes/Hooks.php M includes/SidebarHooks.php M phpcs.xml 5 files changed, 9 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RelatedArticles refs/changes/82/368082/1 diff --git a/composer.json b/composer.json index 1366381..55507be 100644 --- a/composer.json +++ b/composer.json @@ -1,7 +1,7 @@ { "require-dev": { "jakub-onderka/php-parallel-lint": "0.9.2", - "mediawiki/mediawiki-codesniffer": "0.10.0", + "mediawiki/mediawiki-codesniffer": "0.10.1", "jakub-onderka/php-console-highlighter": "0.3.2" }, "scripts": { diff --git a/includes/FooterHooks.php b/includes/FooterHooks.php index 2a76369..f43e8cc 100644 --- a/includes/FooterHooks.php +++ b/includes/FooterHooks.php @@ -21,7 +21,7 @@ * * @param array &$vars variables to be added into the output of OutputPage::headElement. * @param OutputPage $out OutputPage instance calling the hook -* @return boolean Always true +* @return bool Always true */ public static function onMakeGlobalVariablesScript( &$vars, OutputPage $out ) { $config = MediaWikiServices::getInstance()->getConfigFactory() @@ -102,7 +102,7 @@ * * @param OutputPage $out The OutputPage object * @param Skin $skin Skin object that will be used to generate the page -* @return boolean Always true +* @return bool Always true */ public static function onBeforePageDisplay( OutputPage $out, Skin $skin ) { $config = MediaWikiServices::getInstance()->getConfigFactory() @@ -153,7 +153,7 @@ * @see https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderGetConfigVars * * @param array &$vars Array of variables to be added into the output of the startup module. -* @return boolean +* @return bool */ public static function onResourceLoaderGetConfigVars( &$vars ) { $config = MediaWikiServices::getInstance()->getConfigFactory() @@ -180,7 +180,7 @@ * @see https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderRegisterModules * * @param ResourceLoader &$resourceLoader The ResourceLoader object -* @return boolean +* @return bool */ public static function onResourceLoaderRegisterModules( ResourceLoader &$resourceLoader ) { $dependencies = []; diff --git a/includes/Hooks.php b/includes/Hooks.php index e64164d..7027581 100644 --- a/includes/Hooks.php +++ b/includes/Hooks.php @@ -15,7 +15,7 @@ * {@see Hooks::onFuncRelated}). * * @param Parser &$parser Paser object -* @return boolean Always true +* @return bool Always true */ public static function onParserFirstCallInit( Parser &$parser ) { $parser->setFunctionHook( 'related', 'RelatedArticles\\Hooks::onFuncRelated' ); @@ -64,7 +64,7 @@ * * @param OutputPage &$out the OutputPage object * @param ParserOutput $parserOutput ParserOutput object -* @return boolean Always true +* @return bool Always true */ public static function onOutputPageParserOutput( OutputPage &$out, ParserOutput $parserOutput ) { $related = $parserOutput->getExtensionData( 'RelatedArticles' ); diff --git a/includes/SidebarHooks.php b/includes/SidebarHooks.php index 7ccaefa..2b73e74 100644 --- a/includes/SidebarHooks.php +++ b/includes/SidebarHooks.php @@ -19,7 +19,7 @@ * * @param Skin $skin Skin object * @param array &$bar Sidebar contents -* @return boolean Always true +* @return bool Always true */ public static function onSidebarBeforeOutput( Skin $skin, &$bar ) { $out = $skin->getOutput(); diff --git a/phpcs.xml b/phpcs.xml index ea36036..b0464c3 100644 --- a/phpcs.xml +++ b/phpcs.xml @@ -4,6 +4,5 @@ . - - vendor + -- To view, visit https://gerrit.wikimedia.org/r/368082 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie05b9ddc3e351abf4b2b199529b714766055d161 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/RelatedArticles Gerrit-Branch: master Gerrit-Owner: Umherirrender___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org