[MediaWiki-commits] [Gerrit] mediawiki...Score[master]: Add score count to 'score' page property

2017-12-18 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/398701 )

Change subject: Add score count to 'score' page property
..


Add score count to 'score' page property

This change removes the value of 1 listed after each page with a
score, replacing it by a useful number, that of the amount of
scores on the page.

Bug: T183078
Change-Id: I2977e19388479d64b877c631cfaade9f4abf05a6
---
M includes/Score.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Score.php b/includes/Score.php
index bede431..e3b76c8 100644
--- a/includes/Score.php
+++ b/includes/Score.php
@@ -298,7 +298,8 @@
 
// Mark the page as using the score extension, it makes easier
// to track all those pages.
-   $parser->getOutput()->setProperty( 'score', true );
+   $scoreNum = $parser->getOutput()->getProperty( 'score' );
+   $parser->getOutput()->setProperty( 'score', $scoreNum += 1 );
 
return $html;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/398701
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2977e19388479d64b877c631cfaade9f4abf05a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Score
Gerrit-Branch: master
Gerrit-Owner: Ebe123 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...Score[master]: Add score count to 'score' page property

2017-12-17 Thread Ebe123 (Code Review)
Ebe123 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398701 )

Change subject: Add score count to 'score' page property
..

Add score count to 'score' page property

This change removes the value of 1 listed after each page with a
score, replacing it by a useful number, that of the amount of
scores on the page.

Bug: T183078
Change-Id: I2977e19388479d64b877c631cfaade9f4abf05a6
---
M includes/Score.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Score 
refs/changes/01/398701/1

diff --git a/includes/Score.php b/includes/Score.php
index bede431..e3b76c8 100644
--- a/includes/Score.php
+++ b/includes/Score.php
@@ -298,7 +298,8 @@
 
// Mark the page as using the score extension, it makes easier
// to track all those pages.
-   $parser->getOutput()->setProperty( 'score', true );
+   $scoreNum = $parser->getOutput()->getProperty( 'score' );
+   $parser->getOutput()->setProperty( 'score', $scoreNum += 1 );
 
return $html;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/398701
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2977e19388479d64b877c631cfaade9f4abf05a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Score
Gerrit-Branch: master
Gerrit-Owner: Ebe123 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits