[MediaWiki-commits] [Gerrit] mediawiki...Score[master]: Improve style

2017-01-08 Thread Dereckson (Code Review) 
Dereckson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/331218 )

Change subject: Improve style
..

Improve style

Change-Id: Ib2da89d38ac02ca4f34642d8db27bbdd56ff0b59
---
M Score.body.php
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Score 
refs/changes/18/331218/1

diff --git a/Score.body.php b/Score.body.php
index fd1e27c..1cb109b 100644
--- a/Score.body.php
+++ b/Score.body.php
@@ -384,7 +384,7 @@
$midiFileName = "{$options['file_name_prefix']}.midi";
$metaDataFileName = 
"{$options['file_name_prefix']}.json";
 
-   if( isset( $existingFiles[$metaDataFileName] ) ) {
+   if ( isset( $existingFiles[$metaDataFileName] ) ) {
$metaDataFile = $backend->getFileContents(
array( 'src' => 
"{$options['dest_storage_path']}/$metaDataFileName" ) );
if ( $metaDataFile === false ) {
@@ -480,8 +480,8 @@
$link = Html::rawElement( 'a', array( 'href' => 
$url ), $link );
}
if ( $options['generate_ogg'] ) {
-   $length = 
$metaData[basename($oggPath)]['length'];
-   if ( class_exists( 'TimedMediaTransformOutput' 
) ){
+   $length = $metaData[basename( $oggPath 
)]['length'];
+   if ( class_exists( 'TimedMediaTransformOutput' 
) ) {
$player = new 
TimedMediaTransformOutput( array(
'length' => $length,
'sources' => array(
@@ -799,7 +799,7 @@
'dst' => $remoteDest );
 
// Create metadata json
-   $metaData[basename($remoteDest)]['length'] = self::getLength( 
$factoryOgg );
+   $metaData[basename( $remoteDest )]['length'] = self::getLength( 
$factoryOgg );
$dstFileName = "{$options['file_name_prefix']}.json";
$dest = "{$options['dest_storage_path']}/$dstFileName";
$ops[] = array(
@@ -905,7 +905,7 @@
 * @return float duration in seconds
 */
private static function getLength( $path ) {
-   //File_Ogg is packaged in TimedMediaHandler and OggHandler
+   // File_Ogg is packaged in TimedMediaHandler and OggHandler
if ( !class_exists( 'File_Ogg' ) ) {
require( 'File/Ogg.php' );
}
@@ -943,7 +943,7 @@
 * @return Bool true on success, false on error
 */
private static function eraseFactory( $dir ) {
-   if( file_exists( $dir ) ) {
+   if ( file_exists( $dir ) ) {
array_map( 'unlink', glob( "$dir/*", GLOB_NOSORT ) );
$rc = rmdir( $dir );
if ( !$rc ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/331218
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2da89d38ac02ca4f34642d8db27bbdd56ff0b59
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Score
Gerrit-Branch: master
Gerrit-Owner: Dereckson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Score[master]: Improve style

2017-01-17 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/331218 )

Change subject: Improve style
..


Improve style

Change-Id: Ib2da89d38ac02ca4f34642d8db27bbdd56ff0b59
---
M Score.body.php
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/Score.body.php b/Score.body.php
index fd1e27c..1cb109b 100644
--- a/Score.body.php
+++ b/Score.body.php
@@ -384,7 +384,7 @@
$midiFileName = "{$options['file_name_prefix']}.midi";
$metaDataFileName = 
"{$options['file_name_prefix']}.json";
 
-   if( isset( $existingFiles[$metaDataFileName] ) ) {
+   if ( isset( $existingFiles[$metaDataFileName] ) ) {
$metaDataFile = $backend->getFileContents(
array( 'src' => 
"{$options['dest_storage_path']}/$metaDataFileName" ) );
if ( $metaDataFile === false ) {
@@ -480,8 +480,8 @@
$link = Html::rawElement( 'a', array( 'href' => 
$url ), $link );
}
if ( $options['generate_ogg'] ) {
-   $length = 
$metaData[basename($oggPath)]['length'];
-   if ( class_exists( 'TimedMediaTransformOutput' 
) ){
+   $length = $metaData[basename( $oggPath 
)]['length'];
+   if ( class_exists( 'TimedMediaTransformOutput' 
) ) {
$player = new 
TimedMediaTransformOutput( array(
'length' => $length,
'sources' => array(
@@ -799,7 +799,7 @@
'dst' => $remoteDest );
 
// Create metadata json
-   $metaData[basename($remoteDest)]['length'] = self::getLength( 
$factoryOgg );
+   $metaData[basename( $remoteDest )]['length'] = self::getLength( 
$factoryOgg );
$dstFileName = "{$options['file_name_prefix']}.json";
$dest = "{$options['dest_storage_path']}/$dstFileName";
$ops[] = array(
@@ -905,7 +905,7 @@
 * @return float duration in seconds
 */
private static function getLength( $path ) {
-   //File_Ogg is packaged in TimedMediaHandler and OggHandler
+   // File_Ogg is packaged in TimedMediaHandler and OggHandler
if ( !class_exists( 'File_Ogg' ) ) {
require( 'File/Ogg.php' );
}
@@ -943,7 +943,7 @@
 * @return Bool true on success, false on error
 */
private static function eraseFactory( $dir ) {
-   if( file_exists( $dir ) ) {
+   if ( file_exists( $dir ) ) {
array_map( 'unlink', glob( "$dir/*", GLOB_NOSORT ) );
$rc = rmdir( $dir );
if ( !$rc ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/331218
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2da89d38ac02ca4f34642d8db27bbdd56ff0b59
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Score
Gerrit-Branch: master
Gerrit-Owner: Dereckson 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits