[MediaWiki-commits] [Gerrit] mediawiki...SideBarMenu[master]: build: add grunt-contrib-jshint

2017-04-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/349696 )

Change subject: build: add grunt-contrib-jshint
..


build: add grunt-contrib-jshint

See T119973

Change-Id: I357d3e41bf3941777dedbcb60839e04fccf35cc4
---
M Gruntfile.js
M package.json
2 files changed, 10 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/Gruntfile.js b/Gruntfile.js
index a45071e..2db815f 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -1,11 +1,19 @@
 /*jshint node:true */
 module.exports = function ( grunt ) {
grunt.loadNpmTasks( 'grunt-jsonlint' );
+   grunt.loadNpmTasks( 'grunt-contrib-jshint' );
grunt.loadNpmTasks( 'grunt-banana-checker' );
 
grunt.initConfig( {
banana: {
all: 'i18n/'
+   },
+   jshint: {
+   all: [
+   '**/*.js',
+   '!node_modules/**',
+   '!vendor/**'
+   ]
},
jsonlint: {
all: [
@@ -16,6 +24,6 @@
}
} );
 
-   grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
+   grunt.registerTask( 'test', [ 'jsonlint', 'banana', 'jshint' ] );
grunt.registerTask( 'default', 'test' );
 };
diff --git a/package.json b/package.json
index bcf5b13..e87548c 100644
--- a/package.json
+++ b/package.json
@@ -6,6 +6,7 @@
"devDependencies": {
"grunt": "1.0.1",
"grunt-banana-checker": "0.5.0",
+   "grunt-contrib-jshint": "1.1.0",
"grunt-jsonlint": "1.1.0"
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/349696
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I357d3e41bf3941777dedbcb60839e04fccf35cc4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SideBarMenu
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SideBarMenu[master]: build: add grunt-contrib-jshint

2017-04-21 Thread Hashar (Code Review) 
Hashar has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/349696 )

Change subject: build: add grunt-contrib-jshint
..

build: add grunt-contrib-jshint

See T119973

Change-Id: I357d3e41bf3941777dedbcb60839e04fccf35cc4
---
M Gruntfile.js
M package.json
2 files changed, 10 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SideBarMenu 
refs/changes/96/349696/1

diff --git a/Gruntfile.js b/Gruntfile.js
index a45071e..2db815f 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -1,11 +1,19 @@
 /*jshint node:true */
 module.exports = function ( grunt ) {
grunt.loadNpmTasks( 'grunt-jsonlint' );
+   grunt.loadNpmTasks( 'grunt-contrib-jshint' );
grunt.loadNpmTasks( 'grunt-banana-checker' );
 
grunt.initConfig( {
banana: {
all: 'i18n/'
+   },
+   jshint: {
+   all: [
+   '**/*.js',
+   '!node_modules/**',
+   '!vendor/**'
+   ]
},
jsonlint: {
all: [
@@ -16,6 +24,6 @@
}
} );
 
-   grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
+   grunt.registerTask( 'test', [ 'jsonlint', 'banana', 'jshint' ] );
grunt.registerTask( 'default', 'test' );
 };
diff --git a/package.json b/package.json
index bcf5b13..e87548c 100644
--- a/package.json
+++ b/package.json
@@ -6,6 +6,7 @@
"devDependencies": {
"grunt": "1.0.1",
"grunt-banana-checker": "0.5.0",
+   "grunt-contrib-jshint": "1.1.0",
"grunt-jsonlint": "1.1.0"
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/349696
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I357d3e41bf3941777dedbcb60839e04fccf35cc4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SideBarMenu
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits