[MediaWiki-commits] [Gerrit] mediawiki...SpamBlacklist[master]: Escape url in Special:Log

2017-01-27 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/333484 )

Change subject: Escape url in Special:Log
..


Escape url in Special:Log

When there is a "$1" in the url, it is treated like a message parameter
and replaced.

See 
https://www.wikidata.org/w/index.php?title=Special:Log&type=spamblacklist&page=Property:P2536.

Change-Id: Ia223a89e12c652a87d52a18c78e612b4b12871bc
---
A SpamBlacklistLogFormatter.php
M extension.json
2 files changed, 13 insertions(+), 1 deletion(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SpamBlacklistLogFormatter.php b/SpamBlacklistLogFormatter.php
new file mode 100644
index 000..187ec1a
--- /dev/null
+++ b/SpamBlacklistLogFormatter.php
@@ -0,0 +1,11 @@
+https://gerrit.wikimedia.org/r/333484
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia223a89e12c652a87d52a18c78e612b4b12871bc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SpamBlacklist
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Glaisher 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Matěj Suchánek 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...SpamBlacklist[master]: Escape url in Special:Log

2017-01-22 Thread Code Review
Matěj Suchánek has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/333484 )

Change subject: Escape url in Special:Log
..

Escape url in Special:Log

When there is a "$1" in the url, it is treated like a message parameter
and replaced.

See 
https://www.wikidata.org/w/index.php?title=Special:Log&type=spamblacklist&page=Property:P2536.

Change-Id: Ia223a89e12c652a87d52a18c78e612b4b12871bc
---
A SpamBlacklistLogFormatter.php
M extension.json
2 files changed, 13 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SpamBlacklist 
refs/changes/84/333484/2

diff --git a/SpamBlacklistLogFormatter.php b/SpamBlacklistLogFormatter.php
new file mode 100644
index 000..187ec1a
--- /dev/null
+++ b/SpamBlacklistLogFormatter.php
@@ -0,0 +1,11 @@
+https://gerrit.wikimedia.org/r/333484
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia223a89e12c652a87d52a18c78e612b4b12871bc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SpamBlacklist
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...SpamBlacklist[master]: Escape url in Special:Log

2017-01-21 Thread Code Review
Matěj Suchánek has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/88 )

Change subject: Escape url in Special:Log
..

Escape url in Special:Log

When "$1" or similar are in the url, they are replaced with the message
parameters.

See 
https://www.wikidata.org/w/index.php?title=Special:Log&type=spamblacklist&page=Property:P2536.

Change-Id: I5539b1e53f15446477af088a6f697f6a684552a4
---
M SpamBlacklist_body.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SpamBlacklist 
refs/changes/88/88/2

diff --git a/SpamBlacklist_body.php b/SpamBlacklist_body.php
index e14fa44..24243da 100644
--- a/SpamBlacklist_body.php
+++ b/SpamBlacklist_body.php
@@ -324,7 +324,7 @@
$logEntry->setPerformer( $wgUser );
$logEntry->setTarget( $title );
$logEntry->setParameters( array(
-   '4::url' => $url,
+   '4:raw:url' => htmlspecialchars( $url ),
) );
$logid = $logEntry->insert();
$logEntry->publish( $logid, "rc" );

-- 
To view, visit https://gerrit.wikimedia.org/r/88
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5539b1e53f15446477af088a6f697f6a684552a4
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SpamBlacklist
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits