[MediaWiki-commits] [Gerrit] mediawiki...SpamRegex[master]: build: add grunt-contrib-jshint

2017-04-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/349633 )

Change subject: build: add grunt-contrib-jshint
..


build: add grunt-contrib-jshint

See T119973

Change-Id: I542fb8b20f0e5e4a3fecb3a22844367724df0311
---
M Gruntfile.js
M package.json
2 files changed, 10 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/Gruntfile.js b/Gruntfile.js
index 8859cd3..237b9d7 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -1,9 +1,17 @@
 /* eslint-env node */
 module.exports = function ( grunt ) {
grunt.loadNpmTasks( 'grunt-jsonlint' );
+   grunt.loadNpmTasks( 'grunt-contrib-jshint' );
// grunt.loadNpmTasks( 'grunt-banana-checker' );
 
grunt.initConfig( {
+   jshint: {
+   all: [
+   '**/*.js',
+   '!node_modules/**',
+   '!vendor/**'
+   ]
+   },
jsonlint: {
all: [
'*.json',
@@ -16,6 +24,6 @@
} */
} );
 
-   grunt.registerTask( 'test', [ 'jsonlint' /* 'banana' */ ] );
+   grunt.registerTask( 'test', [ 'jshint', 'jsonlint' /* 'banana' */ ] );
grunt.registerTask( 'default', 'test' );
 };
diff --git a/package.json b/package.json
index 8528003..4108670 100644
--- a/package.json
+++ b/package.json
@@ -5,6 +5,7 @@
   },
   "devDependencies": {
 "grunt": "1.0.1",
+"grunt-contrib-jshint": "1.1.0",
 "grunt-jsonlint": "1.1.0"
   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/349633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I542fb8b20f0e5e4a3fecb3a22844367724df0311
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SpamRegex
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SpamRegex[master]: build: add grunt-contrib-jshint

2017-04-21 Thread Hashar (Code Review) 
Hashar has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/349633 )

Change subject: build: add grunt-contrib-jshint
..

build: add grunt-contrib-jshint

See T119973

Change-Id: I542fb8b20f0e5e4a3fecb3a22844367724df0311
---
M Gruntfile.js
M package.json
2 files changed, 10 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SpamRegex 
refs/changes/33/349633/1

diff --git a/Gruntfile.js b/Gruntfile.js
index 8859cd3..755f157 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -1,9 +1,17 @@
 /* eslint-env node */
 module.exports = function ( grunt ) {
grunt.loadNpmTasks( 'grunt-jsonlint' );
+   grunt.loadNpmTasks( 'grunt-contrib-jshint' );
// grunt.loadNpmTasks( 'grunt-banana-checker' );
 
grunt.initConfig( {
+   jshint: {
+   all: [
+   '**/*.js',
+   '!node_modules/**',
+   '!vendor/**'
+   ]
+   },
jsonlint: {
all: [
'*.json',
@@ -16,6 +24,6 @@
} */
} );
 
-   grunt.registerTask( 'test', [ 'jsonlint' /* 'banana' */ ] );
+   grunt.registerTask( 'test', [ 'jsonlint' /* 'banana', 'jshint' */ ] );
grunt.registerTask( 'default', 'test' );
 };
diff --git a/package.json b/package.json
index 8528003..4108670 100644
--- a/package.json
+++ b/package.json
@@ -5,6 +5,7 @@
   },
   "devDependencies": {
 "grunt": "1.0.1",
+"grunt-contrib-jshint": "1.1.0",
 "grunt-jsonlint": "1.1.0"
   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/349633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I542fb8b20f0e5e4a3fecb3a22844367724df0311
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SpamRegex
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits