[MediaWiki-commits] [Gerrit] mediawiki...ThrottleOverride[master]: Log when actions hit an exemption

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/380422 )

Change subject: Log when actions hit an exemption
..


Log when actions hit an exemption

Whenever a user performs an action which is allowed because of an
exemption set with ThrottleOverride, log this with structured logging.

Bug: T176566
Change-Id: Iecd8b58d72cabecb61488e1e13f8093d2f34741e
---
M ThrottleOverride.hooks.php
1 file changed, 10 insertions(+), 1 deletion(-)

Approvals:
  BryanDavis: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/ThrottleOverride.hooks.php b/ThrottleOverride.hooks.php
index a2db662..c52a353 100644
--- a/ThrottleOverride.hooks.php
+++ b/ThrottleOverride.hooks.php
@@ -18,6 +18,8 @@
  * along with this program.  If not, see .
  */
 
+use MediaWiki\Logger\LoggerFactory;
+
 class ThrottleOverrideHooks {
/**
 * @param string $ip
@@ -71,8 +73,15 @@
 
if ( $expiry > wfTimestampNow() ) {
// Valid exemption. Disable the throttle.
-   $result = false;
 
+   $logger = LoggerFactory::getInstance( 
'throttleOverride' );
+   $logger->info( 'User {user} (ip: {ip}) exempted from 
throttle {action}', [
+   'user' => $user,
+   'ip' => $ip,
+   'action' => $action,
+   ] );
+
+   $result = false;
return false;
} elseif ( $expiry !== false ) {
// Expired exemption. Delete it from the DB.

-- 
To view, visit https://gerrit.wikimedia.org/r/380422
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iecd8b58d72cabecb61488e1e13f8093d2f34741e
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/ThrottleOverride
Gerrit-Branch: master
Gerrit-Owner: EddieGP 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: EddieGP 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ThrottleOverride[master]: Log when actions hit an exemption

[EddieGP (Code Review)]

EddieGP has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/380422 )

Change subject: Log when actions hit an exemption
..

Log when actions hit an exemption

Whenever a user performs an action which is allowed because of an
exemption set with ThrottleOverride, log this with wfDebug();

Bug: T176566
Change-Id: Iecd8b58d72cabecb61488e1e13f8093d2f34741e
---
M ThrottleOverride.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ThrottleOverride 
refs/changes/22/380422/1

diff --git a/ThrottleOverride.hooks.php b/ThrottleOverride.hooks.php
index 58dabd8..dc4110c 100644
--- a/ThrottleOverride.hooks.php
+++ b/ThrottleOverride.hooks.php
@@ -71,8 +71,8 @@
 
if ( $expiry > wfTimestampNow() ) {
// Valid exemption. Disable the throttle.
+   wfDebug( __METHOD__.": exempted user $user (ip: $ip) 
from $action throttle" );
$result = false;
-
return false;
} elseif ( $expiry !== false ) {
// Expired exemption. Delete it from the DB.

-- 
To view, visit https://gerrit.wikimedia.org/r/380422
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecd8b58d72cabecb61488e1e13f8093d2f34741e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ThrottleOverride
Gerrit-Branch: master
Gerrit-Owner: EddieGP 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits