[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: Remove duplicate hook for extension schema updates

2017-04-04 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/343625 )

Change subject: Remove duplicate hook for extension schema updates
..


Remove duplicate hook for extension schema updates

Change-Id: I50c7d55e5113e8aedcb0757f684f18dce8b5eb59
---
M TimedMediaHandler.hooks.php
1 file changed, 0 insertions(+), 12 deletions(-)

Approvals:
  Paladox: Looks good to me, but someone else must approve
  Brion VIBBER: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/TimedMediaHandler.hooks.php b/TimedMediaHandler.hooks.php
index 1a1d46e..78a5f1e 100644
--- a/TimedMediaHandler.hooks.php
+++ b/TimedMediaHandler.hooks.php
@@ -351,8 +351,6 @@
$wgExcludeFromThumbnailPurge[] = 'log';
}
 
-   $wgHooks['LoadExtensionSchemaUpdates'][] = 
'TimedMediaHandlerHooks::loadExtensionSchemaUpdates';
-
// Add unit tests
$wgHooks['UnitTestsList'][] = 
'TimedMediaHandlerHooks::registerUnitTests';
$wgHooks['ParserTestTables'][] = 
'TimedMediaHandlerHooks::onParserTestTables';
@@ -652,16 +650,6 @@
WebVideoTranscode::cleanupTranscodes( $file );
}
}
-   return true;
-   }
-
-   /**
-* Adds the transcode sql
-* @param $updater DatabaseUpdater
-* @return bool
-*/
-   public static function loadExtensionSchemaUpdates( $updater ) {
-   $updater->addExtensionTable( 'transcode', __DIR__ . 
'/TimedMediaHandler.sql' );
return true;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/343625
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I50c7d55e5113e8aedcb0757f684f18dce8b5eb59
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: TheDJ 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: Remove duplicate hook for extension schema updates

2017-03-20 Thread TheDJ (Code Review)
TheDJ has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/343625 )

Change subject: Remove duplicate hook for extension schema updates
..

Remove duplicate hook for extension schema updates

Change-Id: I50c7d55e5113e8aedcb0757f684f18dce8b5eb59
---
M TimedMediaHandler.hooks.php
1 file changed, 0 insertions(+), 12 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/25/343625/1

diff --git a/TimedMediaHandler.hooks.php b/TimedMediaHandler.hooks.php
index 1a1d46e..78a5f1e 100644
--- a/TimedMediaHandler.hooks.php
+++ b/TimedMediaHandler.hooks.php
@@ -351,8 +351,6 @@
$wgExcludeFromThumbnailPurge[] = 'log';
}
 
-   $wgHooks['LoadExtensionSchemaUpdates'][] = 
'TimedMediaHandlerHooks::loadExtensionSchemaUpdates';
-
// Add unit tests
$wgHooks['UnitTestsList'][] = 
'TimedMediaHandlerHooks::registerUnitTests';
$wgHooks['ParserTestTables'][] = 
'TimedMediaHandlerHooks::onParserTestTables';
@@ -652,16 +650,6 @@
WebVideoTranscode::cleanupTranscodes( $file );
}
}
-   return true;
-   }
-
-   /**
-* Adds the transcode sql
-* @param $updater DatabaseUpdater
-* @return bool
-*/
-   public static function loadExtensionSchemaUpdates( $updater ) {
-   $updater->addExtensionTable( 'transcode', __DIR__ . 
'/TimedMediaHandler.sql' );
return true;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/343625
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I50c7d55e5113e8aedcb0757f684f18dce8b5eb59
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: TheDJ 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits